[v2,4/5] dt-bindings: serial: Add a new compatible string for SC9863A
diff mbox series

Message ID 20191111090230.3402-5-chunyan.zhang@unisoc.com
State Not Applicable
Headers show
Series
  • Add Unisoc's SC9863A support
Related show

Checks

Context Check Description
robh/checkpatch success

Commit Message

Chunyan Zhang Nov. 11, 2019, 9:02 a.m. UTC
SC9863A use the same serial device which SC9836 uses.

Signed-off-by: Chunyan Zhang <chunyan.zhang@unisoc.com>
---
 Documentation/devicetree/bindings/serial/sprd-uart.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Rob Herring Nov. 12, 2019, 12:56 a.m. UTC | #1
On Mon, 11 Nov 2019 17:02:29 +0800, Chunyan Zhang wrote:
> 
> SC9863A use the same serial device which SC9836 uses.
> 
> Signed-off-by: Chunyan Zhang <chunyan.zhang@unisoc.com>
> ---
>  Documentation/devicetree/bindings/serial/sprd-uart.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 

Please add Acked-by/Reviewed-by tags when posting new versions. However,
there's no need to repost patches *only* to add the tags. The upstream
maintainer will do that for acks received on the version they apply.

If a tag was not added on purpose, please state why and what changed.
Chunyan Zhang Nov. 12, 2019, 1:38 a.m. UTC | #2
On Tue, 12 Nov 2019 at 08:56, Rob Herring <robh@kernel.org> wrote:
>
> On Mon, 11 Nov 2019 17:02:29 +0800, Chunyan Zhang wrote:
> >
> > SC9863A use the same serial device which SC9836 uses.
> >
> > Signed-off-by: Chunyan Zhang <chunyan.zhang@unisoc.com>
> > ---
> >  Documentation/devicetree/bindings/serial/sprd-uart.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> >
>
> Please add Acked-by/Reviewed-by tags when posting new versions. However,

Yes, I know.

> there's no need to repost patches *only* to add the tags. The upstream
> maintainer will do that for acks received on the version they apply.
>
> If a tag was not added on purpose, please state why and what changed.

The reason was that I switched to yaml rather than txt in last version
which recieved your Acked-by.
Not sure for this kind of case I can still add your Acked-by.

Thanks,
Chunyan
Rob Herring Nov. 14, 2019, 12:06 a.m. UTC | #3
On Mon, Nov 11, 2019 at 7:38 PM Chunyan Zhang <zhang.lyra@gmail.com> wrote:
>
> On Tue, 12 Nov 2019 at 08:56, Rob Herring <robh@kernel.org> wrote:
> >
> > On Mon, 11 Nov 2019 17:02:29 +0800, Chunyan Zhang wrote:
> > >
> > > SC9863A use the same serial device which SC9836 uses.
> > >
> > > Signed-off-by: Chunyan Zhang <chunyan.zhang@unisoc.com>
> > > ---
> > >  Documentation/devicetree/bindings/serial/sprd-uart.yaml | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> >
> > Please add Acked-by/Reviewed-by tags when posting new versions. However,
>
> Yes, I know.
>
> > there's no need to repost patches *only* to add the tags. The upstream
> > maintainer will do that for acks received on the version they apply.
> >
> > If a tag was not added on purpose, please state why and what changed.
>
> The reason was that I switched to yaml rather than txt in last version
> which recieved your Acked-by.
> Not sure for this kind of case I can still add your Acked-by.

This was a semi-automated reply. I do review it first, but if the
changelog is not in the patch I may miss the reason.

Anyways,

Acked-by: Rob Herring <robh@kernel.org>
Chunyan Zhang Nov. 14, 2019, 7:56 a.m. UTC | #4
On Thu, 14 Nov 2019 at 08:06, Rob Herring <robh@kernel.org> wrote:
>
> On Mon, Nov 11, 2019 at 7:38 PM Chunyan Zhang <zhang.lyra@gmail.com> wrote:
> >
> > On Tue, 12 Nov 2019 at 08:56, Rob Herring <robh@kernel.org> wrote:
> > >
> > > On Mon, 11 Nov 2019 17:02:29 +0800, Chunyan Zhang wrote:
> > > >
> > > > SC9863A use the same serial device which SC9836 uses.
> > > >
> > > > Signed-off-by: Chunyan Zhang <chunyan.zhang@unisoc.com>
> > > > ---
> > > >  Documentation/devicetree/bindings/serial/sprd-uart.yaml | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > >
> > >
> > > Please add Acked-by/Reviewed-by tags when posting new versions. However,
> >
> > Yes, I know.
> >
> > > there's no need to repost patches *only* to add the tags. The upstream
> > > maintainer will do that for acks received on the version they apply.
> > >
> > > If a tag was not added on purpose, please state why and what changed.
> >
> > The reason was that I switched to yaml rather than txt in last version
> > which recieved your Acked-by.
> > Not sure for this kind of case I can still add your Acked-by.
>
> This was a semi-automated reply. I do review it first, but if the

Thanks for the review!

Can you please also have a look at other binding patches in this
series when convenient?

Thanks,
Chunyan

> changelog is not in the patch I may miss the reason.
>
> Anyways,
>
> Acked-by: Rob Herring <robh@kernel.org>

Patch
diff mbox series

diff --git a/Documentation/devicetree/bindings/serial/sprd-uart.yaml b/Documentation/devicetree/bindings/serial/sprd-uart.yaml
index 0cc4668a9b9c..a6cce10c8b9d 100644
--- a/Documentation/devicetree/bindings/serial/sprd-uart.yaml
+++ b/Documentation/devicetree/bindings/serial/sprd-uart.yaml
@@ -18,6 +18,7 @@  properties:
       - items:
           - enum:
               - sprd,sc9860-uart
+              - sprd,sc9863a-uart
           - const: sprd,sc9836-uart
       - const: sprd,sc9836-uart