[U-Boot] ARM: omapl138_lcdk: Allow early init to start instruction cache
diff mbox series

Message ID 20191110161758.614-1-aford173@gmail.com
State Accepted
Commit 69acc36864d55229b9520bb620fdc546488ab78d
Delegated to: Tom Rini
Headers show
Series
  • [U-Boot] ARM: omapl138_lcdk: Allow early init to start instruction cache
Related show

Commit Message

Adam Ford Nov. 10, 2019, 4:17 p.m. UTC
Currently the omapl138_lcdk has SKIP_LOWLEVEL_INIT set.
The README states there is a variation of this for the ARM926EJ-S
which allows the board to just skip the call to lowlevel_init()
and do the normal CP15 init which enables the instruction cache.

On the da850evm, this was shown to improve startup time.

This patch switches SKIP_LOWLEVEL_INIT to SKIP_LOWLEVEL_INIT_ONLY
thus, enabling the cache.

Signed-off-by: Adam Ford <aford173@gmail.com>

Comments

Bartosz Golaszewski Nov. 13, 2019, 1:36 p.m. UTC | #1
niedz., 10 lis 2019 o 17:18 Adam Ford <aford173@gmail.com> napisaƂ(a):
>
> Currently the omapl138_lcdk has SKIP_LOWLEVEL_INIT set.
> The README states there is a variation of this for the ARM926EJ-S
> which allows the board to just skip the call to lowlevel_init()
> and do the normal CP15 init which enables the instruction cache.
>
> On the da850evm, this was shown to improve startup time.
>
> This patch switches SKIP_LOWLEVEL_INIT to SKIP_LOWLEVEL_INIT_ONLY
> thus, enabling the cache.
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
>
> diff --git a/include/configs/omapl138_lcdk.h b/include/configs/omapl138_lcdk.h
> index 1c41e7e97a..3b5c085a24 100644
> --- a/include/configs/omapl138_lcdk.h
> +++ b/include/configs/omapl138_lcdk.h
> @@ -23,7 +23,7 @@
>  #define CONFIG_SYS_TIMERBASE           DAVINCI_TIMER0_BASE
>  #define CONFIG_SYS_HZ_CLOCK            clk_get(DAVINCI_AUXCLK_CLKID)
>  #define CONFIG_SYS_HZ                  1000
> -#define CONFIG_SKIP_LOWLEVEL_INIT
> +#define CONFIG_SKIP_LOWLEVEL_INIT_ONLY
>
>  /*
>   * Memory Info
> --
> 2.20.1
>

Tested-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Reviewed-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Tom Rini Dec. 4, 2019, 4 a.m. UTC | #2
On Sun, Nov 10, 2019 at 10:17:58AM -0600, Adam Ford wrote:

> Currently the omapl138_lcdk has SKIP_LOWLEVEL_INIT set.
> The README states there is a variation of this for the ARM926EJ-S
> which allows the board to just skip the call to lowlevel_init()
> and do the normal CP15 init which enables the instruction cache.
> 
> On the da850evm, this was shown to improve startup time.
> 
> This patch switches SKIP_LOWLEVEL_INIT to SKIP_LOWLEVEL_INIT_ONLY
> thus, enabling the cache.
> 
> Signed-off-by: Adam Ford <aford173@gmail.com>
> Tested-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> Reviewed-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> 
> diff --git a/include/configs/omapl138_lcdk.h b/include/configs/omapl138_lcdk.h
> index 1c41e7e97a..3b5c085a24 100644

Applied to u-boot/master, thanks!

Patch
diff mbox series

diff --git a/include/configs/omapl138_lcdk.h b/include/configs/omapl138_lcdk.h
index 1c41e7e97a..3b5c085a24 100644
--- a/include/configs/omapl138_lcdk.h
+++ b/include/configs/omapl138_lcdk.h
@@ -23,7 +23,7 @@ 
 #define CONFIG_SYS_TIMERBASE		DAVINCI_TIMER0_BASE
 #define CONFIG_SYS_HZ_CLOCK		clk_get(DAVINCI_AUXCLK_CLKID)
 #define CONFIG_SYS_HZ			1000
-#define CONFIG_SKIP_LOWLEVEL_INIT
+#define CONFIG_SKIP_LOWLEVEL_INIT_ONLY
 
 /*
  * Memory Info