package/jailhouse: fix misc details in Config.in
diff mbox series

Message ID 20191110132627.15985-1-thomas.petazzoni@bootlin.com
State Accepted
Headers show
Series
  • package/jailhouse: fix misc details in Config.in
Related show

Commit Message

Thomas Petazzoni Nov. 10, 2019, 1:26 p.m. UTC
This commit fixes a number of small minor details in the jailhouse
Config.in file:

 - The Config.in comment is in the middle of the main
   BR2_PACKAGE_JAILHOUSE option and its sub-options, causing the
   sub-options to not be indented properly in menuconfig

 - jailhouse was capitalized as Jailhouse, while all Buildroot
   packages in menuconfig use small letters, so use "jailhouse"
   everywhere

 - no need to repeat "jailhouse" in the prompt of the sub-option for
   helper scripts, since it is not properly indented under the main
   jailhouse option.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
 package/jailhouse/Config.in | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

Comments

Yann E. MORIN Nov. 10, 2019, 6:33 p.m. UTC | #1
Thomas, All,

On 2019-11-10 14:26 +0100, Thomas Petazzoni spake thusly:
> This commit fixes a number of small minor details in the jailhouse
> Config.in file:
> 
>  - The Config.in comment is in the middle of the main
>    BR2_PACKAGE_JAILHOUSE option and its sub-options, causing the
>    sub-options to not be indented properly in menuconfig
> 
>  - jailhouse was capitalized as Jailhouse, while all Buildroot
>    packages in menuconfig use small letters, so use "jailhouse"
>    everywhere
> 
>  - no need to repeat "jailhouse" in the prompt of the sub-option for
>    helper scripts, since it is not properly indented under the main
>    jailhouse option.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Applied to master, thanks. I have however done a slight modification,
see below...

> ---
>  package/jailhouse/Config.in | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/package/jailhouse/Config.in b/package/jailhouse/Config.in
> index 5b9ecc7b7b..e792900d76 100644
> --- a/package/jailhouse/Config.in
> +++ b/package/jailhouse/Config.in
> @@ -1,5 +1,5 @@
>  config BR2_PACKAGE_JAILHOUSE
> -	bool "Jailhouse"
> +	bool "jailhouse"
>  	depends on BR2_aarch64 || BR2_x86_64
>  	depends on BR2_LINUX_KERNEL
>  	help
> @@ -7,21 +7,21 @@ config BR2_PACKAGE_JAILHOUSE
>  
>  	  https://github.com/siemens/jailhouse
>  
> -comment "Jailhouse needs a Linux kernel to be built"
> -	depends on BR2_aarch64 || BR2_x86_64
> -	depends on !BR2_LINUX_KERNEL
> -
>  if BR2_PACKAGE_JAILHOUSE
>  
>  config BR2_PACKAGE_JAILHOUSE_HELPER_SCRIPTS
> -	bool "Jailhouse helper scripts"
> +	bool "helper scripts"
>  	depends on BR2_PACKAGE_PYTHON
>  	help
>  	  Python-based helpers for the Jailhouse Hypervisor.
>  
>  	  https://github.com/siemens/jailhouse
>  
> -comment "Jailhouse helper scripts require Python"
> +comment "jailhouse helper scripts require Python"

I've also dropped 'jailhouse' from this comment.

Regards,
Yann E. MORIN.

>  	depends on !BR2_PACKAGE_PYTHON
>  
>  endif
> +
> +comment "jailhouse needs a Linux kernel to be built"
> +	depends on BR2_aarch64 || BR2_x86_64
> +	depends on !BR2_LINUX_KERNEL
> -- 
> 2.21.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Peter Korsgaard Nov. 18, 2019, 12:50 p.m. UTC | #2
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

 > This commit fixes a number of small minor details in the jailhouse
 > Config.in file:

 >  - The Config.in comment is in the middle of the main
 >    BR2_PACKAGE_JAILHOUSE option and its sub-options, causing the
 >    sub-options to not be indented properly in menuconfig

 >  - jailhouse was capitalized as Jailhouse, while all Buildroot
 >    packages in menuconfig use small letters, so use "jailhouse"
 >    everywhere

 >  - no need to repeat "jailhouse" in the prompt of the sub-option for
 >    helper scripts, since it is not properly indented under the main
 >    jailhouse option.

 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Committed to 2019.08.x, thanks.

Patch
diff mbox series

diff --git a/package/jailhouse/Config.in b/package/jailhouse/Config.in
index 5b9ecc7b7b..e792900d76 100644
--- a/package/jailhouse/Config.in
+++ b/package/jailhouse/Config.in
@@ -1,5 +1,5 @@ 
 config BR2_PACKAGE_JAILHOUSE
-	bool "Jailhouse"
+	bool "jailhouse"
 	depends on BR2_aarch64 || BR2_x86_64
 	depends on BR2_LINUX_KERNEL
 	help
@@ -7,21 +7,21 @@  config BR2_PACKAGE_JAILHOUSE
 
 	  https://github.com/siemens/jailhouse
 
-comment "Jailhouse needs a Linux kernel to be built"
-	depends on BR2_aarch64 || BR2_x86_64
-	depends on !BR2_LINUX_KERNEL
-
 if BR2_PACKAGE_JAILHOUSE
 
 config BR2_PACKAGE_JAILHOUSE_HELPER_SCRIPTS
-	bool "Jailhouse helper scripts"
+	bool "helper scripts"
 	depends on BR2_PACKAGE_PYTHON
 	help
 	  Python-based helpers for the Jailhouse Hypervisor.
 
 	  https://github.com/siemens/jailhouse
 
-comment "Jailhouse helper scripts require Python"
+comment "jailhouse helper scripts require Python"
 	depends on !BR2_PACKAGE_PYTHON
 
 endif
+
+comment "jailhouse needs a Linux kernel to be built"
+	depends on BR2_aarch64 || BR2_x86_64
+	depends on !BR2_LINUX_KERNEL