[U-Boot] ARM: omapl138_lcdk: Shrink code size by building with Thumb
diff mbox series

Message ID 20191110123340.9992-1-aford173@gmail.com
State Accepted
Delegated to: Tom Rini
Headers show
Series
  • [U-Boot] ARM: omapl138_lcdk: Shrink code size by building with Thumb
Related show

Commit Message

Adam Ford Nov. 10, 2019, 12:33 p.m. UTC
SPL has limited available resources, and the performance between
ARM and Thumb isn't that significant.

This patch builds using Thumb instruction set to reduce the code
size by nearly 6K.

Original:
   text	   data	    bss	    dec	    hex	filename
  26526	   4004	   1376	  31906	   7ca2	spl/u-boot-spl

Thumb:

   text	   data	    bss	    dec	    hex	filename
  20232	   4004	   1376	  25612	   640c	spl/u-boot-spl

Signed-off-by: Adam Ford <aford173@gmail.com>

Comments

Bartosz Golaszewski Nov. 13, 2019, 1:35 p.m. UTC | #1
niedz., 10 lis 2019 o 13:33 Adam Ford <aford173@gmail.com> napisaƂ(a):
>
> SPL has limited available resources, and the performance between
> ARM and Thumb isn't that significant.
>
> This patch builds using Thumb instruction set to reduce the code
> size by nearly 6K.
>
> Original:
>    text    data     bss     dec     hex filename
>   26526    4004    1376   31906    7ca2 spl/u-boot-spl
>
> Thumb:
>
>    text    data     bss     dec     hex filename
>   20232    4004    1376   25612    640c spl/u-boot-spl
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
>
> diff --git a/configs/omapl138_lcdk_defconfig b/configs/omapl138_lcdk_defconfig
> index 9821df9884..16287a4ac2 100644
> --- a/configs/omapl138_lcdk_defconfig
> +++ b/configs/omapl138_lcdk_defconfig
> @@ -1,4 +1,5 @@
>  CONFIG_ARM=y
> +CONFIG_SYS_THUMB_BUILD=y
>  CONFIG_ARCH_DAVINCI=y
>  CONFIG_SYS_TEXT_BASE=0xc1080000
>  CONFIG_TARGET_OMAPL138_LCDK=y
> --
> 2.20.1
>

Tested-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Reviewed-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Tom Rini Dec. 5, 2019, 10:08 p.m. UTC | #2
On Sun, Nov 10, 2019 at 06:33:40AM -0600, Adam Ford wrote:

> SPL has limited available resources, and the performance between
> ARM and Thumb isn't that significant.
> 
> This patch builds using Thumb instruction set to reduce the code
> size by nearly 6K.
> 
> Original:
>    text	   data	    bss	    dec	    hex	filename
>   26526	   4004	   1376	  31906	   7ca2	spl/u-boot-spl
> 
> Thumb:
> 
>    text	   data	    bss	    dec	    hex	filename
>   20232	   4004	   1376	  25612	   640c	spl/u-boot-spl
> 
> Signed-off-by: Adam Ford <aford173@gmail.com>
> Tested-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> Reviewed-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> 
> diff --git a/configs/omapl138_lcdk_defconfig b/configs/omapl138_lcdk_defconfig
> index 9821df9884..16287a4ac2 100644

Applied to u-boot/master, thanks!

Patch
diff mbox series

diff --git a/configs/omapl138_lcdk_defconfig b/configs/omapl138_lcdk_defconfig
index 9821df9884..16287a4ac2 100644
--- a/configs/omapl138_lcdk_defconfig
+++ b/configs/omapl138_lcdk_defconfig
@@ -1,4 +1,5 @@ 
 CONFIG_ARM=y
+CONFIG_SYS_THUMB_BUILD=y
 CONFIG_ARCH_DAVINCI=y
 CONFIG_SYS_TEXT_BASE=0xc1080000
 CONFIG_TARGET_OMAPL138_LCDK=y