board/beaglebone: fix boot on BeagleBone Black
diff mbox series

Message ID 20191109152254.15562-1-unixmania@gmail.com
State Accepted
Headers show
Series
  • board/beaglebone: fix boot on BeagleBone Black
Related show

Commit Message

Carlos Santos Nov. 9, 2019, 3:22 p.m. UTC
From: Carlos Santos <unixmania@gmail.com>

Commit 68b5b79b2f has set the getty port to the default console but left
"ttyO0" in bootargs, in the U-Boot environment. Use "ttyS0", instead.

Also set loadaddr to 0x82000000 and fdtaddr to 0x88000000, replacing the
values that were valid for the ancient U-Boot and Linux pre-installed on
old boards but cause boot hangs with the current versions.

Signed-off-by: Carlos Santos <unixmania@gmail.com>
---
CC: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
CC: Lothar Felten <lothar.felten@gmail.com>
---
Changes v1->v2:
- Clarify the explanation about old U-Boot versions in the commit
  message.
---
 board/beaglebone/uEnv.txt | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comments

Thomas Petazzoni Nov. 15, 2019, 10:38 p.m. UTC | #1
On Sat,  9 Nov 2019 12:22:54 -0300
unixmania@gmail.com wrote:

> From: Carlos Santos <unixmania@gmail.com>
> 
> Commit 68b5b79b2f has set the getty port to the default console but left
> "ttyO0" in bootargs, in the U-Boot environment. Use "ttyS0", instead.
> 
> Also set loadaddr to 0x82000000 and fdtaddr to 0x88000000, replacing the
> values that were valid for the ancient U-Boot and Linux pre-installed on
> old boards but cause boot hangs with the current versions.
> 
> Signed-off-by: Carlos Santos <unixmania@gmail.com>
> ---
> CC: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> CC: Lothar Felten <lothar.felten@gmail.com>
> ---
> Changes v1->v2:
> - Clarify the explanation about old U-Boot versions in the commit
>   message.
> ---
>  board/beaglebone/uEnv.txt | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

Applied to master, thanks.

Thomas
Peter Korsgaard Nov. 22, 2019, 6:28 p.m. UTC | #2
>>>>> "unixmania" == unixmania  <unixmania@gmail.com> writes:

 > From: Carlos Santos <unixmania@gmail.com>
 > Commit 68b5b79b2f has set the getty port to the default console but left
 > "ttyO0" in bootargs, in the U-Boot environment. Use "ttyS0", instead.

 > Also set loadaddr to 0x82000000 and fdtaddr to 0x88000000, replacing the
 > values that were valid for the ancient U-Boot and Linux pre-installed on
 > old boards but cause boot hangs with the current versions.

 > Signed-off-by: Carlos Santos <unixmania@gmail.com>
 > ---
 > CC: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
 > CC: Lothar Felten <lothar.felten@gmail.com>
 > ---
 > Changes v1->v2:
 > - Clarify the explanation about old U-Boot versions in the commit
 >   message.

Committed to 2019.02.x and 2019.08.x, thanks.

Patch
diff mbox series

diff --git a/board/beaglebone/uEnv.txt b/board/beaglebone/uEnv.txt
index a665f20889..8fce54d87e 100644
--- a/board/beaglebone/uEnv.txt
+++ b/board/beaglebone/uEnv.txt
@@ -3,6 +3,9 @@  devtype=mmc
 bootdir=
 bootfile=zImage
 bootpartition=mmcblk0p2
+console=ttyS0,115200n8
+loadaddr=0x82000000
+fdtaddr=0x88000000
 set_mmc1=if test $board_name = A33515BB; then setenv bootpartition mmcblk1p2; fi
-set_bootargs=setenv bootargs console=ttyO0,115200n8 root=/dev/${bootpartition} rw rootfstype=ext4 rootwait
+set_bootargs=setenv bootargs console=${console} root=/dev/${bootpartition} rw rootfstype=ext4 rootwait
 uenvcmd=run set_mmc1; run set_bootargs;run loadimage;run loadfdt;printenv bootargs;bootz ${loadaddr} - ${fdtaddr}