[net-next,3/3] net: dsa: sja1105: Disallow management xmit during switch reset
diff mbox series

Message ID 20191109113224.6495-4-olteanv@gmail.com
State Accepted
Delegated to: David Miller
Headers show
  • [net-next,1/3] net: dsa: sja1105: Implement the .gettimex64 system call for PTP
Related show

Commit Message

Vladimir Oltean Nov. 9, 2019, 11:32 a.m. UTC
The purpose here is to avoid ptp4l fail due to this condition:

  timed out while polling for tx timestamp
  increasing tx_timestamp_timeout may correct this issue, but it is likely caused by a driver bug
  port 1: send peer delay request failed

So either reset the switch before the management frame was sent, or
after it was timestamped as well, but not in the middle.

The condition may arise either due to a true timeout (i.e. because
re-uploading the static config takes time), or due to the TX timestamp
actually getting lost due to reset. For the former we can increase
tx_timestamp_timeout in userspace, for the latter we need this patch.

Locking all traffic during switch reset does not make sense at all,
though. Forcing all CPU-originated traffic to potentially block waiting
for a sleepable context to send > 800 bytes over SPI is not a good idea.
Flows that are autonomously forwarded by the switch will get dropped
anyway during switch reset no matter what. So just let all other
CPU-originated traffic be dropped as well.

Signed-off-by: Vladimir Oltean <olteanv@gmail.com>
 drivers/net/dsa/sja1105/sja1105_main.c | 4 ++++
 1 file changed, 4 insertions(+)

diff mbox series

diff --git a/drivers/net/dsa/sja1105/sja1105_main.c b/drivers/net/dsa/sja1105/sja1105_main.c
index 2b8919a25392..475cc2d8b0e8 100644
--- a/drivers/net/dsa/sja1105/sja1105_main.c
+++ b/drivers/net/dsa/sja1105/sja1105_main.c
@@ -1359,6 +1359,8 @@  int sja1105_static_config_reload(struct sja1105_private *priv)
 	int rc, i;
 	s64 now;
+	mutex_lock(&priv->mgmt_lock);
 	mac = priv->static_config.tables[BLK_IDX_MAC_CONFIG].entries;
 	/* Back up the dynamic link speed changed by sja1105_adjust_port_config
@@ -1417,6 +1419,8 @@  int sja1105_static_config_reload(struct sja1105_private *priv)
 			goto out;
+	mutex_unlock(&priv->mgmt_lock);
 	return rc;