[v2] tcp: remove redundant new line from tcp_event_sk_skb
diff mbox series

Message ID 20191109104305.92898-1-tonylu@linux.alibaba.com
State Accepted
Delegated to: David Miller
Headers show
Series
  • [v2] tcp: remove redundant new line from tcp_event_sk_skb
Related show

Commit Message

Tony Lu Nov. 9, 2019, 10:43 a.m. UTC
This removes '\n' from trace event class tcp_event_sk_skb to avoid
redundant new blank line and make output compact.

Fixes: af4325ecc24f ("tcp: expose sk_state in tcp_retransmit_skb tracepoint")
Reviewed-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Yafang Shao <laoar.shao@gmail.com>
Signed-off-by: Tony Lu <tonylu@linux.alibaba.com>
---
v1->v2:
- append Fixes tag
---
 include/trace/events/tcp.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

David Miller Nov. 10, 2019, 3:56 a.m. UTC | #1
From: Tony Lu <tonylu@linux.alibaba.com>
Date: Sat,  9 Nov 2019 18:43:06 +0800

> This removes '\n' from trace event class tcp_event_sk_skb to avoid
> redundant new blank line and make output compact.
> 
> Fixes: af4325ecc24f ("tcp: expose sk_state in tcp_retransmit_skb tracepoint")
> Reviewed-by: Eric Dumazet <edumazet@google.com>
> Reviewed-by: Yafang Shao <laoar.shao@gmail.com>
> Signed-off-by: Tony Lu <tonylu@linux.alibaba.com>
> ---
> v1->v2:
> - append Fixes tag

Applied and queued up for -stable, thanks.

Patch
diff mbox series

diff --git a/include/trace/events/tcp.h b/include/trace/events/tcp.h
index 2bc9960a31aa..cf97f6339acb 100644
--- a/include/trace/events/tcp.h
+++ b/include/trace/events/tcp.h
@@ -86,7 +86,7 @@  DECLARE_EVENT_CLASS(tcp_event_sk_skb,
 			      sk->sk_v6_rcv_saddr, sk->sk_v6_daddr);
 	),
 
-	TP_printk("sport=%hu dport=%hu saddr=%pI4 daddr=%pI4 saddrv6=%pI6c daddrv6=%pI6c state=%s\n",
+	TP_printk("sport=%hu dport=%hu saddr=%pI4 daddr=%pI4 saddrv6=%pI6c daddrv6=%pI6c state=%s",
 		  __entry->sport, __entry->dport, __entry->saddr, __entry->daddr,
 		  __entry->saddr_v6, __entry->daddr_v6,
 		  show_tcp_state_name(__entry->state))