Patchwork pata_arasan_cf: remove bogus to_platform_device() calls

login
register
mail settings
Submitter Sergei Shtylyov
Date Oct. 12, 2011, 3:09 p.m.
Message ID <201110121909.09664.sshtylyov@ru.mvista.com>
Download mbox | patch
Permalink /patch/119229/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Sergei Shtylyov - Oct. 12, 2011, 3:09 p.m.
The suspend()/resume() methods already get the right 'struct device' to get the
driver data from -- there's no need to get to the 'struct platform_device' that
contains that 'struct device' just to call dev_get_drvdata()...

Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>

---
This patch is against the recent Linus' tree.

 drivers/ata/pata_arasan_cf.c |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Viresh KUMAR - Oct. 13, 2011, 3:33 a.m.
On 10/12/2011 8:39 PM, Sergei Shtylyov wrote:
> The suspend()/resume() methods already get the right 'struct device' to get the
> driver data from -- there's no need to get to the 'struct platform_device' that
> contains that 'struct device' just to call dev_get_drvdata()...
> 
> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
> 
> ---
> This patch is against the recent Linus' tree.
> 
>  drivers/ata/pata_arasan_cf.c |    6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> Index: linux-2.6/drivers/ata/pata_arasan_cf.c
> ===================================================================
> --- linux-2.6.orig/drivers/ata/pata_arasan_cf.c
> +++ linux-2.6/drivers/ata/pata_arasan_cf.c
> @@ -922,8 +922,7 @@ static int __devexit arasan_cf_remove(st
>  #ifdef CONFIG_PM
>  static int arasan_cf_suspend(struct device *dev)
>  {
> -	struct platform_device *pdev = to_platform_device(dev);
> -	struct ata_host *host = dev_get_drvdata(&pdev->dev);
> +	struct ata_host *host = dev_get_drvdata(dev);
>  	struct arasan_cf_dev *acdev = host->ports[0]->private_data;
>  
>  	if (acdev->dma_chan) {
> @@ -937,8 +936,7 @@ static int arasan_cf_suspend(struct devi
>  
>  static int arasan_cf_resume(struct device *dev)
>  {
> -	struct platform_device *pdev = to_platform_device(dev);
> -	struct ata_host *host = dev_get_drvdata(&pdev->dev);
> +	struct ata_host *host = dev_get_drvdata(dev);
>  	struct arasan_cf_dev *acdev = host->ports[0]->private_data;
>  
>  	cf_init(acdev);
> .
> 

Acked-by: Viresh Kumar <viresh.kumar@st.com>

Patch

Index: linux-2.6/drivers/ata/pata_arasan_cf.c
===================================================================
--- linux-2.6.orig/drivers/ata/pata_arasan_cf.c
+++ linux-2.6/drivers/ata/pata_arasan_cf.c
@@ -922,8 +922,7 @@  static int __devexit arasan_cf_remove(st
 #ifdef CONFIG_PM
 static int arasan_cf_suspend(struct device *dev)
 {
-	struct platform_device *pdev = to_platform_device(dev);
-	struct ata_host *host = dev_get_drvdata(&pdev->dev);
+	struct ata_host *host = dev_get_drvdata(dev);
 	struct arasan_cf_dev *acdev = host->ports[0]->private_data;
 
 	if (acdev->dma_chan) {
@@ -937,8 +936,7 @@  static int arasan_cf_suspend(struct devi
 
 static int arasan_cf_resume(struct device *dev)
 {
-	struct platform_device *pdev = to_platform_device(dev);
-	struct ata_host *host = dev_get_drvdata(&pdev->dev);
+	struct ata_host *host = dev_get_drvdata(dev);
 	struct arasan_cf_dev *acdev = host->ports[0]->private_data;
 
 	cf_init(acdev);