From patchwork Wed Oct 12 14:45:34 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartlomiej Zolnierkiewicz X-Patchwork-Id: 119225 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id A5389B6F76 for ; Thu, 13 Oct 2011 01:52:54 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752041Ab1JLOwo (ORCPT ); Wed, 12 Oct 2011 10:52:44 -0400 Received: from mail-ey0-f174.google.com ([209.85.215.174]:46008 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751880Ab1JLOwm (ORCPT ); Wed, 12 Oct 2011 10:52:42 -0400 Received: by eye27 with SMTP id 27so824142eye.19 for ; Wed, 12 Oct 2011 07:52:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:content-transfer-encoding:message-id; bh=E2ouXrGevF42Hzmj+XDgR9oreaPMymkr0cCI/dY0TSY=; b=DeJc+mRJaRIyetTA9Rxovl54iGJzLUUOI1uwwQJBmQeJ8akHz4l1+kuBzqhyXA1XY0 ngd7gzDkyV+Yv816Aq14SU+cpZFEq6Lf/gP3YXDh1WF8QGpoRVPxiUaecg2P5qJzEdEY iKOWuSfdwDxI6mtAGqq+g3e9ElA8Sx5N60bHw= Received: by 10.223.92.144 with SMTP id r16mr47254917fam.23.1318431160920; Wed, 12 Oct 2011 07:52:40 -0700 (PDT) Received: from linux-mhg7.site (89-74-122-41.dynamic.chello.pl. [89.74.122.41]) by mx.google.com with ESMTPS id n12sm4099566fan.9.2011.10.12.07.52.38 (version=SSLv3 cipher=OTHER); Wed, 12 Oct 2011 07:52:38 -0700 (PDT) From: Bartlomiej Zolnierkiewicz To: David Miller Subject: Re: [PATCH] icside: DMA support fix Date: Wed, 12 Oct 2011 16:45:34 +0200 User-Agent: KMail/1.13.6 (Linux/2.6.37.6-0.7-desktop-dirty; KDE/4.6.0; x86_64; ; ) Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org References: <201110111933.48430.bzolnier@gmail.com> <20111011.145523.1844316617273586111.davem@davemloft.net> In-Reply-To: <20111011.145523.1844316617273586111.davem@davemloft.net> MIME-Version: 1.0 Message-Id: <201110121645.47490.bzolnier@gmail.com> Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org David Miller wrote: > From: Bartlomiej Zolnierkiewicz > Date: Tue, 11 Oct 2011 19:33:48 +0200 > > > From: Bartlomiej Zolnierkiewicz > > Subject: [PATCH] icside: DMA support fix > > > > Signed-off-by: Bartlomiej Zolnierkiewicz > > You're going to have to give me a more verbose commit message than > that. From: Bartlomiej Zolnierkiewicz Subject: [PATCH v2] icside: DMA support fix Fix problem introduced by commit 5e37bdc ("ide: add struct ide_dma_ops (take 3)"): d.dma_ops shouldn't be cleared if we are going to use DMA. Signed-off-by: Bartlomiej Zolnierkiewicz --- v2: updated patch description drivers/ide/icside.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Index: b/drivers/ide/icside.c =================================================================== --- a/drivers/ide/icside.c +++ b/drivers/ide/icside.c @@ -521,8 +521,8 @@ icside_register_v6(struct icside_state * if (ec->dma != NO_DMA && !request_dma(ec->dma, DRV_NAME)) { d.init_dma = icside_dma_init; d.port_ops = &icside_v6_port_ops; + } else d.dma_ops = NULL; - } ret = ide_host_register(host, &d, hws); if (ret)