[iproute2-next] man: remove ppp from list of devices not allowed to change netns
diff mbox series

Message ID beefb89b340483d75c39c46a9ec69384e839f663.1573248448.git.gnault@redhat.com
State Accepted
Delegated to: stephen hemminger
Headers show
Series
  • [iproute2-next] man: remove ppp from list of devices not allowed to change netns
Related show

Commit Message

Guillaume Nault Nov. 8, 2019, 9:28 p.m. UTC
PPP devices can be moved to different network namespaces. The feature
was added by commit 79c441ae505c ("ppp: implement x-netns support")
in Linux 4.3.

Signed-off-by: Guillaume Nault <gnault@redhat.com>
---
 man/man8/ip-link.8.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stephen Hemminger Nov. 8, 2019, 11:31 p.m. UTC | #1
On Fri, 8 Nov 2019 22:28:04 +0100
Guillaume Nault <gnault@redhat.com> wrote:

> PPP devices can be moved to different network namespaces. The feature
> was added by commit 79c441ae505c ("ppp: implement x-netns support")
> in Linux 4.3.
> 
> Signed-off-by: Guillaume Nault <gnault@redhat.com>
> ---
>  man/man8/ip-link.8.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/man/man8/ip-link.8.in b/man/man8/ip-link.8.in
> index 9629a649..939e2ad4 100644
> --- a/man/man8/ip-link.8.in
> +++ b/man/man8/ip-link.8.in
> @@ -1921,7 +1921,7 @@ move the device to the network namespace associated with name
>  .RI process " PID".
>  
>  Some devices are not allowed to change network namespace: loopback, bridge,
> -ppp, wireless. These are network namespace local devices. In such case
> +wireless. These are network namespace local devices. In such case
>  .B ip
>  tool will return "Invalid argument" error. It is possible to find out
>  if device is local to a single network namespace by checking

This doesn't have to wait for net-next
Guillaume Nault Nov. 9, 2019, 5:01 p.m. UTC | #2
On Fri, Nov 08, 2019 at 03:31:59PM -0800, Stephen Hemminger wrote:
> On Fri, 8 Nov 2019 22:28:04 +0100
> Guillaume Nault <gnault@redhat.com> wrote:
> > diff --git a/man/man8/ip-link.8.in b/man/man8/ip-link.8.in
> > index 9629a649..939e2ad4 100644
> > --- a/man/man8/ip-link.8.in
> > +++ b/man/man8/ip-link.8.in
> > @@ -1921,7 +1921,7 @@ move the device to the network namespace associated with name
> >  .RI process " PID".
> >  
> >  Some devices are not allowed to change network namespace: loopback, bridge,
> > -ppp, wireless. These are network namespace local devices. In such case
> > +wireless. These are network namespace local devices. In such case
> >  .B ip
> >  tool will return "Invalid argument" error. It is possible to find out
> >  if device is local to a single network namespace by checking
> 
> This doesn't have to wait for net-next
Right, I should have posted it for -iproute2, sorry. The patch applies
cleanly there though. Do you want to take it as is, or do you prefer
that I submit it again?
Stephen Hemminger Nov. 9, 2019, 8:02 p.m. UTC | #3
On Sat, 9 Nov 2019 18:01:23 +0100
Guillaume Nault <gnault@redhat.com> wrote:

> On Fri, Nov 08, 2019 at 03:31:59PM -0800, Stephen Hemminger wrote:
> > On Fri, 8 Nov 2019 22:28:04 +0100
> > Guillaume Nault <gnault@redhat.com> wrote:  
> > > diff --git a/man/man8/ip-link.8.in b/man/man8/ip-link.8.in
> > > index 9629a649..939e2ad4 100644
> > > --- a/man/man8/ip-link.8.in
> > > +++ b/man/man8/ip-link.8.in
> > > @@ -1921,7 +1921,7 @@ move the device to the network namespace associated with name
> > >  .RI process " PID".
> > >  
> > >  Some devices are not allowed to change network namespace: loopback, bridge,
> > > -ppp, wireless. These are network namespace local devices. In such case
> > > +wireless. These are network namespace local devices. In such case
> > >  .B ip
> > >  tool will return "Invalid argument" error. It is possible to find out
> > >  if device is local to a single network namespace by checking  
> > 
> > This doesn't have to wait for net-next  
> Right, I should have posted it for -iproute2, sorry. The patch applies
> cleanly there though. Do you want to take it as is, or do you prefer
> that I submit it again?
> 

I will merge it as is

Patch
diff mbox series

diff --git a/man/man8/ip-link.8.in b/man/man8/ip-link.8.in
index 9629a649..939e2ad4 100644
--- a/man/man8/ip-link.8.in
+++ b/man/man8/ip-link.8.in
@@ -1921,7 +1921,7 @@  move the device to the network namespace associated with name
 .RI process " PID".
 
 Some devices are not allowed to change network namespace: loopback, bridge,
-ppp, wireless. These are network namespace local devices. In such case
+wireless. These are network namespace local devices. In such case
 .B ip
 tool will return "Invalid argument" error. It is possible to find out
 if device is local to a single network namespace by checking