diff mbox series

[1/1] utils/scanpypi: sort alphabetically list of required packages

Message ID 20191108161043.342378-1-b.bilas@grinn-global.com
State Accepted
Headers show
Series [1/1] utils/scanpypi: sort alphabetically list of required packages | expand

Commit Message

Bartosz Bilas Nov. 8, 2019, 4:10 p.m. UTC
That change will alphabetically set list order
of required packages in Config.in file automatically.

Example below:

before: ['python-pyserial', 'python-pyaes', 'python-ecdsa']
after:  ['python-ecdsa', 'python-pyaes', 'python-pyserial']

Signed-off-by: Bartosz Bilas <b.bilas@grinn-global.com>
---
 utils/scanpypi | 1 +
 1 file changed, 1 insertion(+)

Comments

Yegor Yefremov Nov. 8, 2019, 4:45 p.m. UTC | #1
On Fri, Nov 8, 2019 at 5:10 PM Bartosz Bilas <b.bilas@grinn-global.com> wrote:
>
> That change will alphabetically set list order
> of required packages in Config.in file automatically.
>
> Example below:
>
> before: ['python-pyserial', 'python-pyaes', 'python-ecdsa']
> after:  ['python-ecdsa', 'python-pyaes', 'python-pyserial']
>
> Signed-off-by: Bartosz Bilas <b.bilas@grinn-global.com>

Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com>

> ---
>  utils/scanpypi | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/utils/scanpypi b/utils/scanpypi
> index b48eda49aa..796ce1d60c 100755
> --- a/utils/scanpypi
> +++ b/utils/scanpypi
> @@ -612,6 +612,7 @@ class BuildrootPackage():
>          bool_line = '\tbool "{name}"\n'.format(name=self.buildroot_name)
>          lines.append(bool_line)
>          if self.pkg_req:
> +            self.pkg_req.sort()
>              for dep in self.pkg_req:
>                  dep_line = '\tselect BR2_PACKAGE_{req} # runtime\n'.format(
>                      req=dep.upper().replace('-', '_'))
> --
> 2.24.0
>
Thomas Petazzoni Nov. 8, 2019, 8:54 p.m. UTC | #2
On Fri,  8 Nov 2019 17:10:43 +0100
Bartosz Bilas <b.bilas@grinn-global.com> wrote:

> That change will alphabetically set list order
> of required packages in Config.in file automatically.
> 
> Example below:
> 
> before: ['python-pyserial', 'python-pyaes', 'python-ecdsa']
> after:  ['python-ecdsa', 'python-pyaes', 'python-pyserial']
> 
> Signed-off-by: Bartosz Bilas <b.bilas@grinn-global.com>
> ---
>  utils/scanpypi | 1 +
>  1 file changed, 1 insertion(+)

Applied to next, thanks.

Thomas
diff mbox series

Patch

diff --git a/utils/scanpypi b/utils/scanpypi
index b48eda49aa..796ce1d60c 100755
--- a/utils/scanpypi
+++ b/utils/scanpypi
@@ -612,6 +612,7 @@  class BuildrootPackage():
         bool_line = '\tbool "{name}"\n'.format(name=self.buildroot_name)
         lines.append(bool_line)
         if self.pkg_req:
+            self.pkg_req.sort()
             for dep in self.pkg_req:
                 dep_line = '\tselect BR2_PACKAGE_{req} # runtime\n'.format(
                     req=dep.upper().replace('-', '_'))