| Message ID | 20191108130123.6839-47-linux@rasmusvillemoes.dk (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | QUICC Engine support on ARM and ARM64 | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch powerpc/merge (85c5b0984ebb104ec7a0a853ec1e63c19f500313) |
| snowpatch_ozlabs/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
On Fri, Nov 8, 2019 at 7:04 AM Rasmus Villemoes <linux@rasmusvillemoes.dk> wrote: > > Currently, QUICC_ENGINE depends on PPC32, so this in itself does not > change anything. In order to allow removing the PPC32 dependency from > QUICC_ENGINE and avoid allmodconfig build failures, add this explicit > dependency. Can you add an explanation why we don't want ucc_geth on non-PowerPC platforms?
On Thu, Nov 14, 2019 at 10:37 PM Timur Tabi <timur@kernel.org> wrote: > > On Fri, Nov 8, 2019 at 7:04 AM Rasmus Villemoes > <linux@rasmusvillemoes.dk> wrote: > > > > Currently, QUICC_ENGINE depends on PPC32, so this in itself does not > > change anything. In order to allow removing the PPC32 dependency from > > QUICC_ENGINE and avoid allmodconfig build failures, add this explicit > > dependency. > > Can you add an explanation why we don't want ucc_geth on non-PowerPC platforms? I think it is because the QE Ethernet was never integrated in any non-PowerPC SoC and most likely will not be in the future. We probably can make it compile for other architectures for general code quality but it is not a priority. Regards, Leo
On 15/11/2019 06.44, Li Yang wrote: > On Thu, Nov 14, 2019 at 10:37 PM Timur Tabi <timur@kernel.org> wrote: >> >> On Fri, Nov 8, 2019 at 7:04 AM Rasmus Villemoes >> <linux@rasmusvillemoes.dk> wrote: >>> >>> Currently, QUICC_ENGINE depends on PPC32, so this in itself does not >>> change anything. In order to allow removing the PPC32 dependency from >>> QUICC_ENGINE and avoid allmodconfig build failures, add this explicit >>> dependency. >> >> Can you add an explanation why we don't want ucc_geth on non-PowerPC platforms? It's not that "we" don't want to allow building this on non-PPC per se, but making it build requires some surgery that I think should be done by whoever might eventually want it. So _my_ reason for lowering this dependency from QUICC_ENGINE to UCC_GETH is exactly what it says above. > I think it is because the QE Ethernet was never integrated in any > non-PowerPC SoC and most likely will not be in the future. Well, that kind of thing is impossible to know for outsiders like me. Maybe one can amend the commit log with that info: "Also, the QE Ethernet has never been integrated on any non-PowerPC SoC and most likely will not be in the future." Rasmus
On 11/14/19 11:44 PM, Li Yang wrote: >> Can you add an explanation why we don't want ucc_geth on non-PowerPC platforms? > I think it is because the QE Ethernet was never integrated in any > non-PowerPC SoC and most likely will not be in the future. We > probably can make it compile for other architectures for general code > quality but it is not a priority. This explanation belongs in the commit message.
On 11/15/19 1:54 AM, Rasmus Villemoes wrote: > "Also, the QE Ethernet has never been integrated on any non-PowerPC SoC > and most likely will not be in the future." That works for me, thanks.
diff --git a/drivers/net/ethernet/freescale/Kconfig b/drivers/net/ethernet/freescale/Kconfig index 6a7e8993119f..2bd7ace0a953 100644 --- a/drivers/net/ethernet/freescale/Kconfig +++ b/drivers/net/ethernet/freescale/Kconfig @@ -74,7 +74,7 @@ config FSL_XGMAC_MDIO config UCC_GETH tristate "Freescale QE Gigabit Ethernet" - depends on QUICC_ENGINE + depends on QUICC_ENGINE && PPC32 select FSL_PQ_MDIO select PHYLIB ---help---
Currently, QUICC_ENGINE depends on PPC32, so this in itself does not change anything. In order to allow removing the PPC32 dependency from QUICC_ENGINE and avoid allmodconfig build failures, add this explicit dependency. Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> --- drivers/net/ethernet/freescale/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)