Patchwork [C++] PR 50594 (C++ front-end bits)

login
register
mail settings
Submitter Paolo Carlini
Date Oct. 12, 2011, 12:57 p.m.
Message ID <4E958EB8.8080505@oracle.com>
Download mbox | patch
Permalink /patch/119195/
State New
Headers show

Comments

Paolo Carlini - Oct. 12, 2011, 12:57 p.m.
Hi,
> +    delattrs
> +      = build_tree_list (get_identifier ("externally_visible"),
> +             build_tree_list (NULL_TREE, integer_one_node));
>>> Why integer_one_node?
>> To be honest? No idea, I copied what pre-existed for operator new. Shall I
>> test (NULL_TREE, NULL_TREE)??
> build_tree_list (get_identifier ("externally_visible"), NULL_TREE)
Thanks Richard. Ah, now I see: for new, the integer_one_node is for the 
alloc_size attribute itself. externally_visible has no parameters of its 
own. Sorry about my laziness ;)

Thus I'm testing the below. Looks better?

Thanks,
Paolo.

///////////////////////

Patch

Index: decl.c
===================================================================
--- decl.c	(revision 179842)
+++ decl.c	(working copy)
@@ -3654,7 +3654,7 @@  cxx_init_decl_processing (void)
   current_lang_name = lang_name_cplusplus;
 
   {
-    tree newattrs;
+    tree newattrs, delattrs;
     tree newtype, deltype;
     tree ptr_ftype_sizetype;
     tree new_eh_spec;
@@ -3687,9 +3687,14 @@  cxx_init_decl_processing (void)
     newattrs
       = build_tree_list (get_identifier ("alloc_size"),
 			 build_tree_list (NULL_TREE, integer_one_node));
+    newattrs = chainon (newattrs, build_tree_list
+			(get_identifier ("externally_visible"), NULL_TREE));
     newtype = cp_build_type_attribute_variant (ptr_ftype_sizetype, newattrs);
     newtype = build_exception_variant (newtype, new_eh_spec);
-    deltype = build_exception_variant (void_ftype_ptr, empty_except_spec);
+    delattrs = build_tree_list (get_identifier ("externally_visible"),
+				NULL_TREE);
+    deltype = cp_build_type_attribute_variant (void_ftype_ptr, delattrs);
+    deltype = build_exception_variant (deltype, empty_except_spec);
     push_cp_library_fn (NEW_EXPR, newtype);
     push_cp_library_fn (VEC_NEW_EXPR, newtype);
     global_delete_fndecl = push_cp_library_fn (DELETE_EXPR, deltype);