Patchwork [TRIVIAL] ARM: imx: Fix typo 'MACH_MX31_3DS_MXC_NAND_USE_BBT'

login
register
mail settings
Submitter Paul Bolle
Date Oct. 12, 2011, 12:04 p.m.
Message ID <1318421062.2336.4.camel@x61.thuisdomein>
Download mbox | patch
Permalink /patch/119192/
State New
Headers show

Comments

Paul Bolle - Oct. 12, 2011, 12:04 p.m.
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
This is trivial because this is what apparently was intended. On the
other hand this should open code paths that were hidden until now. So
perhaps this needs the maintainer's approval. (I cannot meaningfully
test this.)

 arch/arm/mach-imx/mach-mx31_3ds.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Jiri Kosina - Oct. 31, 2011, 10:12 a.m.
On Wed, 12 Oct 2011, Paul Bolle wrote:

> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> This is trivial because this is what apparently was intended. On the
> other hand this should open code paths that were hidden until now. So
> perhaps this needs the maintainer's approval. (I cannot meaningfully
> test this.)

I'd like to have this tested by some relevant people before taking it 
myself (added some CCs).

> 
>  arch/arm/mach-imx/mach-mx31_3ds.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/mach-imx/mach-mx31_3ds.c b/arch/arm/mach-imx/mach-mx31_3ds.c
> index c20be75..5750ca5 100644
> --- a/arch/arm/mach-imx/mach-mx31_3ds.c
> +++ b/arch/arm/mach-imx/mach-mx31_3ds.c
> @@ -542,7 +542,7 @@ static const struct mxc_nand_platform_data
>  mx31_3ds_nand_board_info __initconst = {
>  	.width		= 1,
>  	.hw_ecc		= 1,
> -#ifdef MACH_MX31_3DS_MXC_NAND_USE_BBT
> +#ifdef CONFIG_MACH_MX31_3DS_MXC_NAND_USE_BBT
>  	.flash_bbt	= 1,
>  #endif
>  };
> -- 
> 1.7.4.4
> 
> 
>
Fabio Estevam - Nov. 1, 2011, 6:19 p.m.
On Mon, Oct 31, 2011 at 8:12 AM, Jiri Kosina <jkosina@suse.cz> wrote:
> On Wed, 12 Oct 2011, Paul Bolle wrote:
>
>> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
>> ---
>> This is trivial because this is what apparently was intended. On the
>> other hand this should open code paths that were hidden until now. So
>> perhaps this needs the maintainer's approval. (I cannot meaningfully
>> test this.)
>
> I'd like to have this tested by some relevant people before taking it
> myself (added some CCs).

On a mx31pdk board I get the following with this patch applied and
CONFIG_MACH_MX31_3DS_MXC_NAND_USE_BBT selected:

NAND device: Manufacturer ID: 0xec, Chip ID: 0xaa (Samsung NAND 256MiB
1,8V 8-bit)
Bad block table not found for chip 0
Bad block table not found for chip 0
Scanning device for bad blocks
Registering mxc_nand as whole device

Tested-by: Fabio Estevam <fabio.estevam@freescale.com>
Jiri Kosina - Nov. 2, 2011, 1:34 p.m.
On Tue, 1 Nov 2011, Fabio Estevam wrote:

> >> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> >> ---
> >> This is trivial because this is what apparently was intended. On the
> >> other hand this should open code paths that were hidden until now. So
> >> perhaps this needs the maintainer's approval. (I cannot meaningfully
> >> test this.)
> >
> > I'd like to have this tested by some relevant people before taking it
> > myself (added some CCs).
> 
> On a mx31pdk board I get the following with this patch applied and
> CONFIG_MACH_MX31_3DS_MXC_NAND_USE_BBT selected:
> 
> NAND device: Manufacturer ID: 0xec, Chip ID: 0xaa (Samsung NAND 256MiB
> 1,8V 8-bit)
> Bad block table not found for chip 0
> Bad block table not found for chip 0
> Scanning device for bad blocks
> Registering mxc_nand as whole device
> 
> Tested-by: Fabio Estevam <fabio.estevam@freescale.com>

Thank you, I will be appplying it.
Paul Bolle - Nov. 2, 2011, 1:43 p.m.
On Wed, 2011-11-02 at 14:34 +0100, Jiri Kosina wrote:
> Thank you, I will be appplying it.

By now this is already in mainline (commit 5328ecbb, Signed-off-by:
Sascha Hauer). This was apparently committed to a tree run by Sascha
before my resend of a few days ago. I don't recall ever seeing a message
that Sascha took it, though.



Paul Bolle

Patch

diff --git a/arch/arm/mach-imx/mach-mx31_3ds.c b/arch/arm/mach-imx/mach-mx31_3ds.c
index c20be75..5750ca5 100644
--- a/arch/arm/mach-imx/mach-mx31_3ds.c
+++ b/arch/arm/mach-imx/mach-mx31_3ds.c
@@ -542,7 +542,7 @@  static const struct mxc_nand_platform_data
 mx31_3ds_nand_board_info __initconst = {
 	.width		= 1,
 	.hw_ecc		= 1,
-#ifdef MACH_MX31_3DS_MXC_NAND_USE_BBT
+#ifdef CONFIG_MACH_MX31_3DS_MXC_NAND_USE_BBT
 	.flash_bbt	= 1,
 #endif
 };