| Message ID | 3ed3c306fc51b0073fcf3a222f7314fcaf50ccf4.1573179553.git.thehajime@gmail.com |
|---|---|
| State | Not Applicable |
| Delegated to: | Richard Weinberger |
| Headers | show |
| Series | [RFC,v2,01/37] asm-generic: atomic64: allow using generic atomic64 on 64bit platforms | expand |
On Fri, Nov 8, 2019 at 6:03 AM Hajime Tazaki <thehajime@gmail.com> wrote: > > From: Octavian Purdila <tavi.purdila@gmail.com> > > With CONFIG_64BIT enabled, atomic64 via CONFIG_GENERIC_ATOMIC64 options > are not compiled due to type conflict of atomic64_t defined in > linux/type.h. > > This commit fixes the issue and allow using generic atomic64 ops. Hmm, why is this specific to LKL? This need a review from core developers. > Signed-off-by: Octavian Purdila <tavi.purdila@gmail.com> > --- > include/asm-generic/atomic64.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/asm-generic/atomic64.h b/include/asm-generic/atomic64.h > index 370f01d4450f..9b15847baae5 100644 > --- a/include/asm-generic/atomic64.h > +++ b/include/asm-generic/atomic64.h > @@ -9,9 +9,11 @@ > #define _ASM_GENERIC_ATOMIC64_H > #include <linux/types.h> > > +#ifndef CONFIG_64BIT > typedef struct { > s64 counter; > } atomic64_t; > +#endif > > #define ATOMIC64_INIT(i) { (i) } > > -- > 2.20.1 (Apple Git-117) > > > _______________________________________________ > linux-um mailing list > linux-um@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-um
On Tue, 26 Nov 2019 07:02:04 +0900, Richard Weinberger wrote: > > On Fri, Nov 8, 2019 at 6:03 AM Hajime Tazaki <thehajime@gmail.com> wrote: > > > > From: Octavian Purdila <tavi.purdila@gmail.com> > > > > With CONFIG_64BIT enabled, atomic64 via CONFIG_GENERIC_ATOMIC64 options > > are not compiled due to type conflict of atomic64_t defined in > > linux/type.h. > > > > This commit fixes the issue and allow using generic atomic64 ops. > > Hmm, why is this specific to LKL? Currently, LKL is only the user which defines GENERIC_ATOMIC64 (lib/atomic64.c) under CONFIG_64BIT environment. Thus, there would be no issues in the current tree. If you manually define `select GENERIC_ATOMIC64` in UML's Kconfig and build it on a 64BIT host, the same problem would happen. > This need a review from core developers. I will explicitly Cc to maintainers (ATOMIC INFRASTRUCTURE) from the next round. Thanks, -- Hajime > > Signed-off-by: Octavian Purdila <tavi.purdila@gmail.com> > > --- > > include/asm-generic/atomic64.h | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/include/asm-generic/atomic64.h b/include/asm-generic/atomic64.h > > index 370f01d4450f..9b15847baae5 100644 > > --- a/include/asm-generic/atomic64.h > > +++ b/include/asm-generic/atomic64.h > > @@ -9,9 +9,11 @@ > > #define _ASM_GENERIC_ATOMIC64_H > > #include <linux/types.h> > > > > +#ifndef CONFIG_64BIT > > typedef struct { > > s64 counter; > > } atomic64_t; > > +#endif > > > > #define ATOMIC64_INIT(i) { (i) }
diff --git a/include/asm-generic/atomic64.h b/include/asm-generic/atomic64.h index 370f01d4450f..9b15847baae5 100644 --- a/include/asm-generic/atomic64.h +++ b/include/asm-generic/atomic64.h @@ -9,9 +9,11 @@ #define _ASM_GENERIC_ATOMIC64_H #include <linux/types.h> +#ifndef CONFIG_64BIT typedef struct { s64 counter; } atomic64_t; +#endif #define ATOMIC64_INIT(i) { (i) }