[pushed] login: Remove double-assignment of fl.l_whence in try_file_lock
diff mbox series

Message ID 20191107090012.7E2D325B28@gnutoolchain-gerrit.osci.io
State New
Headers show
Series
  • [pushed] login: Remove double-assignment of fl.l_whence in try_file_lock
Related show

Commit Message

Carlos O'Donell (Code Review) Nov. 7, 2019, 9 a.m. UTC
The original change was created by Florian Weimer.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/515
......................................................................

login: Remove double-assignment of fl.l_whence in try_file_lock

Since l_whence is the second member of struct flock, it is written
twice.  The double-assignment is technically undefined behavior due to
the lack of a sequence point.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Change-Id: I2baf9e70690e723c61051b25ccbd510aec15976c
---
M login/utmp_file.c
1 file changed, 1 insertion(+), 1 deletion(-)

Patch
diff mbox series

diff --git a/login/utmp_file.c b/login/utmp_file.c
index be7cc06..e627233 100644
--- a/login/utmp_file.c
+++ b/login/utmp_file.c
@@ -79,7 +79,7 @@ 
  struct flock64 fl =
    {
     .l_type = type,
-    fl.l_whence = SEEK_SET,
+    .l_whence = SEEK_SET,
    };
 
  bool status = __fcntl64_nocancel (fd, F_SETLKW, &fl) < 0;