From patchwork Tue Oct 11 20:12:35 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Miller X-Patchwork-Id: 119068 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 6BC74B6F6B for ; Wed, 12 Oct 2011 07:13:35 +1100 (EST) Received: (qmail 2413 invoked by alias); 11 Oct 2011 20:13:26 -0000 Received: (qmail 2260 invoked by uid 22791); 11 Oct 2011 20:13:24 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from shards.monkeyblade.net (HELO shards.monkeyblade.net) (198.137.202.13) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 11 Oct 2011 20:13:07 +0000 Received: from localhost (nat-pool-rdu.redhat.com [66.187.233.202]) (authenticated bits=0) by shards.monkeyblade.net (8.14.4/8.14.4) with ESMTP id p9BKCavF029757 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 11 Oct 2011 13:12:39 -0700 Date: Tue, 11 Oct 2011 16:12:35 -0400 (EDT) Message-Id: <20111011.161235.1865115470975891476.davem@davemloft.net> To: ebotcazou@adacore.com Cc: gcc-patches@gcc.gnu.org, ro@cebitec.uni-bielefeld.de Subject: Re: [PATCH] Fix VIS3 assembler check and conditionalize testsuite on VIS3 support. From: David Miller In-Reply-To: <201110112157.18986.ebotcazou@adacore.com> References: <201110112010.34459.ebotcazou@adacore.com> <20111011.145121.1163327572823593042.davem@davemloft.net> <201110112157.18986.ebotcazou@adacore.com> Mime-Version: 1.0 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org From: Eric Botcazou Date: Tue, 11 Oct 2011 21:57:18 +0200 >> I would expect that to spit out a warning. Do I need to explicitly >> add "-Wall", "-Wno-implicit" or similar? Similar tests in i386.exp don't >> seem to need this and that was what I used as my template. > > -Wall does yield a warning: > > vis.c: In function '_vis3_fpadd64': > vis.c:4:3: warning: implicit declaration of function '__builtin_vis_fpadd64' > [-Wimplicit-function-declaration] Cool, Eric could you quickly test the following? This still leaves the i386.exp case issue open, it stands to reason that something like -Wall is needed for those tests too. diff --git a/gcc/testsuite/gcc.target/sparc/sparc.exp b/gcc/testsuite/gcc.target/sparc/sparc.exp index 51c9c16..7d30dcc 100644 --- a/gcc/testsuite/gcc.target/sparc/sparc.exp +++ b/gcc/testsuite/gcc.target/sparc/sparc.exp @@ -32,7 +32,7 @@ proc check_effective_target_vis3 { } { { return __builtin_vis_fpadd64 (__X, __Y); } - } "-mcpu=niagara3 -mvis" ] + } "-mcpu=niagara3 -mvis -Wall" ] } # If a testcase doesn't have special options, use these.