Patchwork pata_cs5520: remove incorrect warning message

login
register
mail settings
Submitter Bartlomiej Zolnierkiewicz
Date Oct. 11, 2011, 6 p.m.
Message ID <201110112000.44960.bzolnier@gmail.com>
Download mbox | patch
Permalink /patch/119054/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Bartlomiej Zolnierkiewicz - Oct. 11, 2011, 6 p.m.
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Subject: [PATCH] pata_cs5520: remove incorrect warning message

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
 drivers/ata/pata_cs5520.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Alan Cox - Oct. 11, 2011, 7:56 p.m.
On Tue, 11 Oct 2011 20:00:44 +0200
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote:

> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Subject: [PATCH] pata_cs5520: remove incorrect warning message
> 
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

Nothing incorrect about it. It's rather useful information for debugging
CS5520 problems. Users should never see it - and I've not seen it
occuring on any standard VSA releases.

Do you have any examples of it confusing users or even showing up ? 

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Bartlomiej Zolnierkiewicz - Oct. 12, 2011, 3:27 p.m.
Alan Cox wrote:

> On Tue, 11 Oct 2011 20:00:44 +0200
> Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote:
> 
> > From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> > Subject: [PATCH] pata_cs5520: remove incorrect warning message
> > 
> > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> 
> Nothing incorrect about it. It's rather useful information for debugging
> CS5520 problems. Users should never see it - and I've not seen it
> occuring on any standard VSA releases.
> 
> Do you have any examples of it confusing users or even showing up ? 

This driver dooen't even use DMA mode so warning about forcing the setting
may be puzzling.  In addition we do the same thing cs5520_reinit_one()
but without warning the user this time.  Thus removal of the warning makes
it easier for *_reinit_one() replacement by ->init_host method later
(patch is ready for this).
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Alan Cox - Oct. 12, 2011, 5:50 p.m.
O> This driver dooen't even use DMA mode so warning about forcing the setting
> may be puzzling.  In addition we do the same thing cs5520_reinit_one()
> but without warning the user this time.  Thus removal of the warning makes
> it easier for *_reinit_one() replacement by ->init_host method later
> (patch is ready for this).

The re-init case won't find it mis-set. And the CS5520 is not a normal
controller even for DMA so I'd prefer it left as is.

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

Index: b/drivers/ata/pata_cs5520.c
===================================================================
--- a/drivers/ata/pata_cs5520.c
+++ b/drivers/ata/pata_cs5520.c
@@ -148,10 +148,8 @@  static int __devinit cs5520_init_one(str
 	if (pcicfg & 2)
 		ppi[1] = &pi;
 
-	if ((pcicfg & 0x40) == 0) {
-		dev_warn(&pdev->dev, "DMA mode disabled. Enabling.\n");
+	if ((pcicfg & 0x40) == 0)
 		pci_write_config_byte(pdev, 0x60, pcicfg | 0x40);
-	}
 
 	pi.mwdma_mask = id->driver_data;