[ovs-dev] jsonrpc: increase input buffer size from 512 to 4096
diff mbox series

Message ID 2ea8a79e27016abd322b4e51b98e25fbd9335140.1573031816.git.lorenzo.bianconi@redhat.com
State New
Headers show
Series
  • [ovs-dev] jsonrpc: increase input buffer size from 512 to 4096
Related show

Commit Message

Lorenzo Bianconi Nov. 6, 2019, 9:19 a.m. UTC
Increase jsonrpc input buffer size from 512 to 4096 bytes in order to
reduce the syscall overhead when downloading huge db size

Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
---
 lib/jsonrpc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mark Michelson Nov. 6, 2019, 5:02 p.m. UTC | #1
Acked-by: Mark Michelson <mmichels@redhat.com>

On 11/6/19 4:19 AM, Lorenzo Bianconi wrote:
> Increase jsonrpc input buffer size from 512 to 4096 bytes in order to
> reduce the syscall overhead when downloading huge db size
> 
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
> ---
>   lib/jsonrpc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/jsonrpc.c b/lib/jsonrpc.c
> index b9619b822..ed748dbde 100644
> --- a/lib/jsonrpc.c
> +++ b/lib/jsonrpc.c
> @@ -43,7 +43,7 @@ struct jsonrpc {
>   
>       /* Input. */
>       struct byteq input;
> -    uint8_t input_buffer[512];
> +    uint8_t input_buffer[4096];
>       struct json_parser *parser;
>   
>       /* Output. */
>
Ben Pfaff Nov. 21, 2019, 6:46 p.m. UTC | #2
On Wed, Nov 06, 2019 at 11:19:44AM +0200, Lorenzo Bianconi wrote:
> Increase jsonrpc input buffer size from 512 to 4096 bytes in order to
> reduce the syscall overhead when downloading huge db size
> 
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>

Applied to master, thanks!
Ben Pfaff Nov. 21, 2019, 6:48 p.m. UTC | #3
On Thu, Nov 21, 2019 at 10:46:59AM -0800, Ben Pfaff wrote:
> On Wed, Nov 06, 2019 at 11:19:44AM +0200, Lorenzo Bianconi wrote:
> > Increase jsonrpc input buffer size from 512 to 4096 bytes in order to
> > reduce the syscall overhead when downloading huge db size
> > 
> > Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
> 
> Applied to master, thanks!

And branch-2.12.

Patch
diff mbox series

diff --git a/lib/jsonrpc.c b/lib/jsonrpc.c
index b9619b822..ed748dbde 100644
--- a/lib/jsonrpc.c
+++ b/lib/jsonrpc.c
@@ -43,7 +43,7 @@  struct jsonrpc {
 
     /* Input. */
     struct byteq input;
-    uint8_t input_buffer[512];
+    uint8_t input_buffer[4096];
     struct json_parser *parser;
 
     /* Output. */