[v4,08/14] dt-bindings: qcom,pdc: Add compatible for sc7180
diff mbox series

Message ID 20191106065017.22144-9-rnayak@codeaurora.org
State Not Applicable
Headers show
Series
  • Add device tree support for sc7180
Related show

Checks

Context Check Description
robh/checkpatch success

Commit Message

Rajendra Nayak Nov. 6, 2019, 6:50 a.m. UTC
Add the compatible string for sc7180 SoC from Qualcomm.

Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
Cc: Lina Iyer <ilina@codeaurora.org>
Cc: Marc Zyngier <maz@kernel.org>
---
 .../devicetree/bindings/interrupt-controller/qcom,pdc.txt      | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Rob Herring Nov. 6, 2019, 4:56 p.m. UTC | #1
On Wed,  6 Nov 2019 12:20:11 +0530, Rajendra Nayak wrote:
> Add the compatible string for sc7180 SoC from Qualcomm.
> 
> Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
> Cc: Lina Iyer <ilina@codeaurora.org>
> Cc: Marc Zyngier <maz@kernel.org>
> ---
>  .../devicetree/bindings/interrupt-controller/qcom,pdc.txt      | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 

Please add Acked-by/Reviewed-by tags when posting new versions. However,
there's no need to repost patches *only* to add the tags. The upstream
maintainer will do that for acks received on the version they apply.

If a tag was not added on purpose, please state why and what changed.
Stephen Boyd Nov. 6, 2019, 7:11 p.m. UTC | #2
Quoting Rajendra Nayak (2019-11-05 22:50:11)
> Add the compatible string for sc7180 SoC from Qualcomm.
> 
> Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
> Cc: Lina Iyer <ilina@codeaurora.org>
> Cc: Marc Zyngier <maz@kernel.org>
> ---

Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Rajendra Nayak Nov. 7, 2019, 5:46 a.m. UTC | #3
On 11/6/2019 10:26 PM, Rob Herring wrote:
> On Wed,  6 Nov 2019 12:20:11 +0530, Rajendra Nayak wrote:
>> Add the compatible string for sc7180 SoC from Qualcomm.
>>
>> Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
>> Cc: Lina Iyer <ilina@codeaurora.org>
>> Cc: Marc Zyngier <maz@kernel.org>
>> ---
>>   .../devicetree/bindings/interrupt-controller/qcom,pdc.txt      | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
> 
> Please add Acked-by/Reviewed-by tags when posting new versions. However,
> there's no need to repost patches *only* to add the tags. The upstream
> maintainer will do that for acks received on the version they apply.
> 
> If a tag was not added on purpose, please state why and what changed.

Sorry I missed mentioning the delta and the reason for not including your Acked-by.
The previous patch was proposing using just a SoC specific compatible, and this
one adds a SoC independent one along with the SoC specific one as discussed here [1]

[1] https://lkml.org/lkml/2019/11/4/73
Rob Herring Nov. 8, 2019, 11:46 p.m. UTC | #4
On Wed, Nov 6, 2019 at 11:46 PM Rajendra Nayak <rnayak@codeaurora.org> wrote:
>
>
>
> On 11/6/2019 10:26 PM, Rob Herring wrote:
> > On Wed,  6 Nov 2019 12:20:11 +0530, Rajendra Nayak wrote:
> >> Add the compatible string for sc7180 SoC from Qualcomm.
> >>
> >> Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
> >> Cc: Lina Iyer <ilina@codeaurora.org>
> >> Cc: Marc Zyngier <maz@kernel.org>
> >> ---
> >>   .../devicetree/bindings/interrupt-controller/qcom,pdc.txt      | 3 ++-
> >>   1 file changed, 2 insertions(+), 1 deletion(-)
> >>
> >
> > Please add Acked-by/Reviewed-by tags when posting new versions. However,
> > there's no need to repost patches *only* to add the tags. The upstream
> > maintainer will do that for acks received on the version they apply.
> >
> > If a tag was not added on purpose, please state why and what changed.
>
> Sorry I missed mentioning the delta and the reason for not including your Acked-by.
> The previous patch was proposing using just a SoC specific compatible, and this
> one adds a SoC independent one along with the SoC specific one as discussed here [1]

Okay.

Reviewed-by: Rob Herring <robh@kernel.org>

Patch
diff mbox series

diff --git a/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.txt b/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.txt
index 8e0797cb1487..1df293953327 100644
--- a/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.txt
+++ b/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.txt
@@ -17,7 +17,8 @@  Properties:
 - compatible:
 	Usage: required
 	Value type: <string>
-	Definition: Should contain "qcom,<soc>-pdc"
+	Definition: Should contain "qcom,<soc>-pdc" and "qcom,pdc"
+		    - "qcom,sc7180-pdc": For SC7180
 		    - "qcom,sdm845-pdc": For SDM845
 
 - reg: