[SRU,D/E/F] UBUNTU: [Packaging] include iavf/i40evf in generic
diff mbox series

Message ID 20191105015647.21645-1-nobuto.murata@canonical.com
State New
Headers show
Series
  • [SRU,D/E/F] UBUNTU: [Packaging] include iavf/i40evf in generic
Related show

Commit Message

Nobuto Murata Nov. 5, 2019, 1:56 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1848481

Intel's VF drivers such as igbvf and ixgbevf are already available in
generic. It makes sense to add iavf/i40evf especially for SR-IOV enabled
clouds with Intel X710/XXV710/XL710.

Signed-off-by: Nobuto Murata <nobuto.murata@canonical.com>
---
 debian.master/control.d/generic.inclusion-list | 1 +
 1 file changed, 1 insertion(+)

Comments

Seth Forshee Nov. 11, 2019, 8:08 p.m. UTC | #1
On Tue, Nov 05, 2019 at 10:56:47AM +0900, Nobuto Murata wrote:
> BugLink: https://bugs.launchpad.net/bugs/1848481
> 
> Intel's VF drivers such as igbvf and ixgbevf are already available in
> generic. It makes sense to add iavf/i40evf especially for SR-IOV enabled
> clouds with Intel X710/XXV710/XL710.
> 
> Signed-off-by: Nobuto Murata <nobuto.murata@canonical.com>

Acked-by: Seth Forshee <seth.forshee@canonical.com>
Khaled Elmously Nov. 12, 2019, 3:54 a.m. UTC | #2
On 2019-11-05 10:56:47 , Nobuto Murata wrote:
> BugLink: https://bugs.launchpad.net/bugs/1848481
> 
> Intel's VF drivers such as igbvf and ixgbevf are already available in
> generic. It makes sense to add iavf/i40evf especially for SR-IOV enabled
> clouds with Intel X710/XXV710/XL710.
> 
> Signed-off-by: Nobuto Murata <nobuto.murata@canonical.com>
> ---
>  debian.master/control.d/generic.inclusion-list | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/debian.master/control.d/generic.inclusion-list b/debian.master/control.d/generic.inclusion-list
> index e5b770975186..64b06051f0dc 100644
> --- a/debian.master/control.d/generic.inclusion-list
> +++ b/debian.master/control.d/generic.inclusion-list
> @@ -93,6 +93,7 @@ drivers/net/ethernet/ibm/*
>  drivers/net/ethernet/intel/e1000/e1000.ko
>  drivers/net/ethernet/intel/e1000e/e1000e.ko
>  drivers/net/ethernet/intel/i40e/*
> +drivers/net/ethernet/intel/iavf/iavf.ko
>  drivers/net/ethernet/intel/igb/*
>  drivers/net/ethernet/intel/igbvf/igbvf.ko
>  drivers/net/ethernet/intel/ixgbe/*

Acked-by: Khalid Elmously <khalid.elmously@canonical.com>
Khaled Elmously Nov. 12, 2019, 3:55 a.m. UTC | #3
On 2019-11-05 10:56:47 , Nobuto Murata wrote:
> BugLink: https://bugs.launchpad.net/bugs/1848481
> 
> Intel's VF drivers such as igbvf and ixgbevf are already available in
> generic. It makes sense to add iavf/i40evf especially for SR-IOV enabled
> clouds with Intel X710/XXV710/XL710.
> 
> Signed-off-by: Nobuto Murata <nobuto.murata@canonical.com>
> ---
>  debian.master/control.d/generic.inclusion-list | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/debian.master/control.d/generic.inclusion-list b/debian.master/control.d/generic.inclusion-list
> index e5b770975186..64b06051f0dc 100644
> --- a/debian.master/control.d/generic.inclusion-list
> +++ b/debian.master/control.d/generic.inclusion-list
> @@ -93,6 +93,7 @@ drivers/net/ethernet/ibm/*
>  drivers/net/ethernet/intel/e1000/e1000.ko
>  drivers/net/ethernet/intel/e1000e/e1000e.ko
>  drivers/net/ethernet/intel/i40e/*
> +drivers/net/ethernet/intel/iavf/iavf.ko
>  drivers/net/ethernet/intel/igb/*
>  drivers/net/ethernet/intel/igbvf/igbvf.ko
>  drivers/net/ethernet/intel/ixgbe/*
> -- 
> 2.20.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
Nobuto Murata Nov. 12, 2019, 4:29 a.m. UTC | #4
> APPLIED(D,E): [PATCH][SRU][D/E/F] UBUNTU: [Packaging] include iavf/i40evf in generic

Thank you. Could you also apply the patch to Focal please? If I
understand it correctly, the patch has been merged to:
- unstable
- eoan
- disco
and backported to:
- bionic

So the focal branch is still missing it. FWIW, the bug status was a
bit messed up so I've changed status to In Progress for the branch.
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1848481

Let me know if I need to start a new thread to request that. Thanks,


On Tue, Nov 12, 2019 at 12:56 PM Khaled Elmously
<khalid.elmously@canonical.com> wrote:
>
> On 2019-11-05 10:56:47 , Nobuto Murata wrote:
> > BugLink: https://bugs.launchpad.net/bugs/1848481
> >
> > Intel's VF drivers such as igbvf and ixgbevf are already available in
> > generic. It makes sense to add iavf/i40evf especially for SR-IOV enabled
> > clouds with Intel X710/XXV710/XL710.
> >
> > Signed-off-by: Nobuto Murata <nobuto.murata@canonical.com>
> > ---
> >  debian.master/control.d/generic.inclusion-list | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/debian.master/control.d/generic.inclusion-list b/debian.master/control.d/generic.inclusion-list
> > index e5b770975186..64b06051f0dc 100644
> > --- a/debian.master/control.d/generic.inclusion-list
> > +++ b/debian.master/control.d/generic.inclusion-list
> > @@ -93,6 +93,7 @@ drivers/net/ethernet/ibm/*
> >  drivers/net/ethernet/intel/e1000/e1000.ko
> >  drivers/net/ethernet/intel/e1000e/e1000e.ko
> >  drivers/net/ethernet/intel/i40e/*
> > +drivers/net/ethernet/intel/iavf/iavf.ko
> >  drivers/net/ethernet/intel/igb/*
> >  drivers/net/ethernet/intel/igbvf/igbvf.ko
> >  drivers/net/ethernet/intel/ixgbe/*
> > --
> > 2.20.1
> >
> >
> > --
> > kernel-team mailing list
> > kernel-team@lists.ubuntu.com
> > https://lists.ubuntu.com/mailman/listinfo/kernel-team
Thadeu Lima de Souza Cascardo Nov. 14, 2019, 1:52 p.m. UTC | #5
On Tue, Nov 12, 2019 at 01:29:56PM +0900, Nobuto Murata wrote:
> > APPLIED(D,E): [PATCH][SRU][D/E/F] UBUNTU: [Packaging] include iavf/i40evf in generic
> 
> Thank you. Could you also apply the patch to Focal please? If I
> understand it correctly, the patch has been merged to:
> - unstable
> - eoan
> - disco
> and backported to:
> - bionic
> 
> So the focal branch is still missing it. FWIW, the bug status was a
> bit messed up so I've changed status to In Progress for the branch.
> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1848481
> 
> Let me know if I need to start a new thread to request that. Thanks,

If it's applied to unstable, then that's it for focal right now. At this
moment, all development is done under unstable. At some point, we have
development happening both at focal and unstable, when we need to apply patches
to both. But right now, only unstable means that when we move development to
focal, your patch will already be applied.

Hope that clarifies.
Cascardo.

> 
> 
> On Tue, Nov 12, 2019 at 12:56 PM Khaled Elmously
> <khalid.elmously@canonical.com> wrote:
> >
> > On 2019-11-05 10:56:47 , Nobuto Murata wrote:
> > > BugLink: https://bugs.launchpad.net/bugs/1848481
> > >
> > > Intel's VF drivers such as igbvf and ixgbevf are already available in
> > > generic. It makes sense to add iavf/i40evf especially for SR-IOV enabled
> > > clouds with Intel X710/XXV710/XL710.
> > >
> > > Signed-off-by: Nobuto Murata <nobuto.murata@canonical.com>
> > > ---
> > >  debian.master/control.d/generic.inclusion-list | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/debian.master/control.d/generic.inclusion-list b/debian.master/control.d/generic.inclusion-list
> > > index e5b770975186..64b06051f0dc 100644
> > > --- a/debian.master/control.d/generic.inclusion-list
> > > +++ b/debian.master/control.d/generic.inclusion-list
> > > @@ -93,6 +93,7 @@ drivers/net/ethernet/ibm/*
> > >  drivers/net/ethernet/intel/e1000/e1000.ko
> > >  drivers/net/ethernet/intel/e1000e/e1000e.ko
> > >  drivers/net/ethernet/intel/i40e/*
> > > +drivers/net/ethernet/intel/iavf/iavf.ko
> > >  drivers/net/ethernet/intel/igb/*
> > >  drivers/net/ethernet/intel/igbvf/igbvf.ko
> > >  drivers/net/ethernet/intel/ixgbe/*
> > > --
> > > 2.20.1
> > >
> > >
> > > --
> > > kernel-team mailing list
> > > kernel-team@lists.ubuntu.com
> > > https://lists.ubuntu.com/mailman/listinfo/kernel-team
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
Nobuto Murata Nov. 14, 2019, 2:44 p.m. UTC | #6
On Thu, Nov 14, 2019 at 10:52 PM Thadeu Lima de Souza Cascardo <
cascardo@canonical.com> wrote:

> If it's applied to unstable, then that's it for focal right now. At this
> moment, all development is done under unstable. At some point, we have
> development happening both at focal and unstable, when we need to apply
> patches
> to both. But right now, only unstable means that when we move development
> to
> focal, your patch will already be applied.
>

That makes perfect sense. Apologies for the noise as I wasn't familiar with
the process.

Patch
diff mbox series

diff --git a/debian.master/control.d/generic.inclusion-list b/debian.master/control.d/generic.inclusion-list
index e5b770975186..64b06051f0dc 100644
--- a/debian.master/control.d/generic.inclusion-list
+++ b/debian.master/control.d/generic.inclusion-list
@@ -93,6 +93,7 @@  drivers/net/ethernet/ibm/*
 drivers/net/ethernet/intel/e1000/e1000.ko
 drivers/net/ethernet/intel/e1000e/e1000e.ko
 drivers/net/ethernet/intel/i40e/*
+drivers/net/ethernet/intel/iavf/iavf.ko
 drivers/net/ethernet/intel/igb/*
 drivers/net/ethernet/intel/igbvf/igbvf.ko
 drivers/net/ethernet/intel/ixgbe/*