From patchwork Mon Nov 4 21:46:53 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Hubicka X-Patchwork-Id: 1189190 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-512363-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ucw.cz Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="mVODKkls"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 476RGL3HnBz9sP4 for ; Tue, 5 Nov 2019 08:47:04 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:subject:message-id:mime-version:content-type; q=dns; s= default; b=dYLxbq1z5K/8OdkIBmcszuEqVNdUAwh87TAPLDXuojG/AAyYeJXse UCtwT+HiZpOvS5ciz/Rz8DhcOoTAl0OUvnmNmEM7nsh9jTkxQZ63T47Wpu3JRbTL uLx1tb4QS2zjeAtedGWYd00qVLzBDkxWFoP6dOM3DNL4DDNe+O2XaA= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:subject:message-id:mime-version:content-type; s= default; bh=zh0F9OvnElCDPFHH4bShylnPfSM=; b=mVODKklsNyOYt+cZugPC y8QenE8V/E5P5YS9I1URWI5cJwsUk/P10sLr0CZT1hdpAopKcIQjtqcS4xtEvxhO Oh0gWytX/tCk95wKaQt/dYlbqoPFDYIlQXmg0D4gpn+r2TgGYDOVKueg1UWIMG6/ +n8ikETCFNi0NTJxunpwzt4= Received: (qmail 18528 invoked by alias); 4 Nov 2019 21:46:57 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 18517 invoked by uid 89); 4 Nov 2019 21:46:57 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-10.4 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_2, GIT_PATCH_3 autolearn=ham version=3.3.1 spammy= X-HELO: nikam.ms.mff.cuni.cz Received: from nikam.ms.mff.cuni.cz (HELO nikam.ms.mff.cuni.cz) (195.113.20.16) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 04 Nov 2019 21:46:56 +0000 Received: by nikam.ms.mff.cuni.cz (Postfix, from userid 16202) id A47F0282BE2; Mon, 4 Nov 2019 22:46:53 +0100 (CET) Date: Mon, 4 Nov 2019 22:46:53 +0100 From: Jan Hubicka To: gcc-patches@gcc.gnu.org Subject: Initialize global.statics_read in ipa-reference Message-ID: <20191104214653.ghlfu37enwqtyayv@kam.mff.cuni.cz> MIME-Version: 1.0 Content-Disposition: inline User-Agent: NeoMutt/20170113 (1.7.2) Hi, while working on allocator reorg for summaries I noticed that we never initialize statics_read in ipa-reference which is later used to bookkeep the strongly connected components. I am bit surprised that this ever worked w/o crashing, but it seems to be the case. Bootstrapped/regteted x86_64-linux, comitted. Index: ipa-reference.c =================================================================== --- ipa-reference.c (revision 277780) +++ ipa-reference.c (working copy) @@ -492,6 +493,7 @@ init_function_info (struct cgraph_node * info->local.statics_read = BITMAP_ALLOC (&local_info_obstack); info->local.statics_written = BITMAP_ALLOC (&local_info_obstack); + info->global.statics_read = NULL; return &info->local; }