From patchwork Mon Nov 4 19:27:18 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tamar Christina X-Patchwork-Id: 1189124 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-512352-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="nVlfdmtV"; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.b="Zpjg9jVp"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.b="Zpjg9jVp"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 476N9Z6t3wz9sCJ for ; Tue, 5 Nov 2019 06:27:44 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:content-type:mime-version; q=dns; s=default; b=nAgzmKFTTPKLy9hSGfFpgo1hdw50fD3LGGOHIVvnIAsgDCC6Ip 8f/FtZ0jenaZOdMvbAliB1RoFatxJ30re/j6rAdb0GX+TUqvXrJIdV+aK+mAgu7d fAc95KUJ2IOEqdzn53e29zDkRA2HOy2KRAVlvLyRPSlNWT/6MlQ6iUoHE= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:content-type:mime-version; s= default; bh=Quc3JK+4aSvojpUyIs4GgoLlBo4=; b=nVlfdmtVuO5HPtEDWyRr z1oQY4hnBRuj/W7qkRzTuuIJSwz1MUWSaNtIOUOX93YSXC5CsvuvqRzgdq+K7FFh SlX/NyOUQzr2FHOjgRUcpGirhmZKC8l1Ae64sZbdhlIkPi67lFtiTxtTrhkGYMOn 5xpx9y4LIbVn0VvB2MbVMEg= Received: (qmail 114799 invoked by alias); 4 Nov 2019 19:27:37 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 114782 invoked by uid 89); 4 Nov 2019 19:27:36 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-20.0 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy= X-HELO: EUR01-DB5-obe.outbound.protection.outlook.com Received: from mail-eopbgr150073.outbound.protection.outlook.com (HELO EUR01-DB5-obe.outbound.protection.outlook.com) (40.107.15.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 04 Nov 2019 19:27:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+fB6dXJioD1WRkX4B1yV5S5xXQntT7ingXk+eLLE1IE=; b=Zpjg9jVpduvi5T7E5ANrGqnOeka7QCEitNhpckVuE2ICpDYxy121vIgQvuJTxZniyigWPTKsdeAxrjmZHUd2UxCqfshQjCfvzXRop9dHFDriYAsJhOwA0wyNAHWdO1JWA5KL2i/vyZOKYhAb3j4rD6E/oTS3MUkzlTez93RQ4N0= Received: from VI1PR08CA0177.eurprd08.prod.outlook.com (2603:10a6:800:d1::31) by AM0PR08MB4084.eurprd08.prod.outlook.com (2603:10a6:208:129::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2408.24; Mon, 4 Nov 2019 19:27:26 +0000 Received: from DB5EUR03FT027.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e0a::208) by VI1PR08CA0177.outlook.office365.com (2603:10a6:800:d1::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2408.24 via Frontend Transport; Mon, 4 Nov 2019 19:27:26 +0000 Authentication-Results: spf=fail (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; gcc.gnu.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; gcc.gnu.org; dmarc=none action=none header.from=arm.com; Received-SPF: Fail (protection.outlook.com: domain of arm.com does not designate 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT027.mail.protection.outlook.com (10.152.20.121) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2387.20 via Frontend Transport; Mon, 4 Nov 2019 19:27:26 +0000 Received: ("Tessian outbound 3fba803f6da3:v33"); Mon, 04 Nov 2019 19:27:26 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: d8716ac867f33f24 X-CR-MTA-TID: 64aa7808 Received: from d85a23471049.2 (cr-mta-lb-1.cr-mta-net [104.47.14.50]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id BF7456C3-4BB4-4AA5-B9D6-1372A5166441.1; Mon, 04 Nov 2019 19:27:20 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2050.outbound.protection.outlook.com [104.47.14.50]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d85a23471049.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 04 Nov 2019 19:27:20 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gEE1dJEeLiRFqR/mkEFfhcIJiFby17ABKCbzC+1jZL5xI7W+8K5gbmJ+JCCLQ8FlcVeoIE0YCllEwWpYbng/mNArOA+xH8LmfN+pdOCE2Ny4ON4TsBgPbkCw5K1J032KH2wyWmXw9DYNs0tkmDJkV2ptoE9GSkWWaPgisodLGUU7840+DgpKyHM4Uq8CfluNDou3nL8rXVPNbu504mh04LDlgf9ixllTTNZOYFeoFUA3YIs6ftZvN5BXSPcQ15YXdhEUlXuS17TV671qRctvzJNnVw/iwHzUELwv+A93Wf1U/rtYPO2nsteYCtUbW3y/BPcXUbUZ7EQTThMg72gWMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+fB6dXJioD1WRkX4B1yV5S5xXQntT7ingXk+eLLE1IE=; b=OTLEPKY8JZrJnHYAKzkdgwlOzwgNxBFHCz2YXYtyMjrD+5AcZy7eVIpyjr1QQ5dm5fd5qmdddIhEwEAT55j/JywkZ1f+vwcudjeE/kUpJ/qq++BLckKh+Q9DyEziEjcDxGt5ue0Xpkfj2+Xmv8j6P8Kmp5g6MeBtQBTlV2JvOsCQ+cU5ZnnHXgaF5fz4mbQKrxHLNAwKtfVM2TEy012INwhpY4H5JKLO3+dkpXLNN4ZHwJUrTfsf3m0OWw5bDBhlA5lAiZWblWEaHHDYndRWJZ37e8TyDsUYFZPT/CGhPSRycjmg3F7/88jxN5BMbYCQLO0iUZea7EbncYR64SN99g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+fB6dXJioD1WRkX4B1yV5S5xXQntT7ingXk+eLLE1IE=; b=Zpjg9jVpduvi5T7E5ANrGqnOeka7QCEitNhpckVuE2ICpDYxy121vIgQvuJTxZniyigWPTKsdeAxrjmZHUd2UxCqfshQjCfvzXRop9dHFDriYAsJhOwA0wyNAHWdO1JWA5KL2i/vyZOKYhAb3j4rD6E/oTS3MUkzlTez93RQ4N0= Received: from DB6PR0802MB2309.eurprd08.prod.outlook.com (10.172.228.13) by DB6PR0802MB2166.eurprd08.prod.outlook.com (10.172.227.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2408.24; Mon, 4 Nov 2019 19:27:19 +0000 Received: from DB6PR0802MB2309.eurprd08.prod.outlook.com ([fe80::f1c6:c479:4e23:d31a]) by DB6PR0802MB2309.eurprd08.prod.outlook.com ([fe80::f1c6:c479:4e23:d31a%6]) with mapi id 15.20.2408.024; Mon, 4 Nov 2019 19:27:18 +0000 From: Tamar Christina To: "gcc-patches@gcc.gnu.org" CC: nd , Joel Hutton , "rguenther@suse.de" Subject: [committed][middle-end][SLP] Initialize variable to fix bootstrap after r277784. Date: Mon, 4 Nov 2019 19:27:18 +0000 Message-ID: <20191104192713.GA23000@arm.com> Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Tamar.Christina@arm.com; x-ms-exchange-transport-forked: True x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:5516;OLM:5516; X-Forefront-Antispam-Report-Untrusted: SFV:NSPM; SFS:(10009020)(4636009)(136003)(346002)(366004)(396003)(376002)(39860400002)(189003)(199004)(53754006)(54534003)(8936002)(99286004)(81156014)(81166006)(256004)(14444005)(8676002)(33656002)(2906002)(3846002)(6116002)(71200400001)(71190400001)(25786009)(6486002)(5640700003)(99936001)(4326008)(7736002)(305945005)(6436002)(6512007)(66556008)(66066001)(6916009)(86362001)(102836004)(478600001)(26005)(316002)(2351001)(52116002)(6506007)(386003)(44832011)(486006)(14454004)(36756003)(476003)(2616005)(2501003)(54906003)(186003)(1076003)(66616009)(66446008)(5660300002)(66476007)(4744005)(64756008)(66946007); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0802MB2166; H:DB6PR0802MB2309.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: IVgtIxY4f9wMM38+h9hiYMHNv3jUEJloSm5tvOfr9jJQ6kP246CsejGLWPNaKBFzbLu+QCvYx0oLhNCiDKKBoaU7xTZkGqG8IuIy0h1eeZ7Q8MoVefaNTsuUTfUpBzBKwpRDlxjmlfSMRVRgtiRtFm5ZrxLZgW5+pN9r59qHLl4si3jlogkltluyXtnyWy2DsMJNfCv09THA1n550HSNfhpM7TR36BtU+WRcDdbA1KjvOLAdFdi7F17Ky1bmz9kqMNgwYKNYK3SArNWgQljBHQi1wr2ktgfI3zfJlvcPjoN9rr7P73sL2XGCk2ir8HgvvW3X2nOb5W97yb4s6+QlVa9dwn/L5z9/ay6z2/IQ4ImJu/0hKhy/CalG8q1do7u6pLUv0gX3ArIIRFAB2mFBSJk1JLTAMZfKUXjEMjCUckPWRQTTkzvz2F6Zm7G5HKvQ MIME-Version: 1.0 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Tamar.Christina@arm.com; X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT027.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: db475e4a-1d0d-4894-f72d-08d7615d01c5 X-IsSubscribed: yes Hi All, This initializes the rstmt variable with NULL and adds an assert to check that a value has been given by one of the if cases before use. This fixes the bootstrap failure due to -Werror. Bootstrapped on aarch64-none-linux-gnu and no issues. Committed under the gcc obvious rule. gcc/ChangeLog: 2019-11-04 Tamar Christina * tree-vect-slp.c (vectorize_slp_instance_root_stmt): Initialize rstmt. diff --git a/gcc/tree-vect-slp.c b/gcc/tree-vect-slp.c index 5549d053bf3cd102a4c4fcdc2e890c596927bd55..f4b445ac1ef9cff8280964dcc8937b3b74fe2a7c 100644 --- a/gcc/tree-vect-slp.c +++ b/gcc/tree-vect-slp.c @@ -4149,7 +4149,7 @@ vect_remove_slp_scalar_calls (slp_tree node) void vectorize_slp_instance_root_stmt (slp_tree node, slp_instance instance) { - gassign *rstmt; + gassign *rstmt = NULL; if (SLP_TREE_NUMBER_OF_VEC_STMTS (node) == 1) { @@ -4183,6 +4183,9 @@ vectorize_slp_instance_root_stmt (slp_tree node, slp_instance instance) tree r_constructor = build_constructor (rtype, v); rstmt = gimple_build_assign (lhs, r_constructor); } + + gcc_assert (rstmt); + gimple_stmt_iterator rgsi = gsi_for_stmt (instance->root_stmt->stmt); gsi_replace (&rgsi, rstmt, true); }