[v1,1/7] PCI: dt: Add legacy PCI IRQ defines
diff mbox series

Message ID 20191104163834.8932-2-andrew.murray@arm.com
State Not Applicable
Headers show
Series
  • PCI: dt: Remove magic numbers for legacy PCI IRQ interrupts
Related show

Checks

Context Check Description
robh/checkpatch success

Commit Message

Andrew Murray Nov. 4, 2019, 4:38 p.m. UTC
PCI devices can trigger interrupts via 4 physical/virtual lines known
as INTA, INTB, INTC or INTD. Due to interrupt swizzling it is often
required to describe the interrupt mapping in the device tree. Let's
add a define for each type to improve device tree clarity.

Signed-off-by: Andrew Murray <andrew.murray@arm.com>
---
 include/dt-bindings/interrupt-controller/irq.h | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Rob Herring Nov. 6, 2019, 11:43 p.m. UTC | #1
On Mon,  4 Nov 2019 16:38:15 +0000, Andrew Murray wrote:
> PCI devices can trigger interrupts via 4 physical/virtual lines known
> as INTA, INTB, INTC or INTD. Due to interrupt swizzling it is often
> required to describe the interrupt mapping in the device tree. Let's
> add a define for each type to improve device tree clarity.
> 
> Signed-off-by: Andrew Murray <andrew.murray@arm.com>
> ---
>  include/dt-bindings/interrupt-controller/irq.h | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 

Acked-by: Rob Herring <robh@kernel.org>

Patch
diff mbox series

diff --git a/include/dt-bindings/interrupt-controller/irq.h b/include/dt-bindings/interrupt-controller/irq.h
index 9e3d183e1381..f9063fd661cd 100644
--- a/include/dt-bindings/interrupt-controller/irq.h
+++ b/include/dt-bindings/interrupt-controller/irq.h
@@ -17,4 +17,12 @@ 
 #define IRQ_TYPE_LEVEL_HIGH	4
 #define IRQ_TYPE_LEVEL_LOW	8
 
+/* Legacy PCI IRQ lines */
+#define IRQ_INTA		1
+#define IRQ_INTB		2
+#define IRQ_INTC		3
+#define IRQ_INTD		4
+
+#define IRQ_INT_ALL		7
+
 #endif