From patchwork Tue Oct 11 08:24:21 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felix Radensky X-Patchwork-Id: 118883 X-Patchwork-Delegate: galak@kernel.crashing.org Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from ozlabs.org (localhost [IPv6:::1]) by ozlabs.org (Postfix) with ESMTP id C16FBB70BC for ; Tue, 11 Oct 2011 20:03:06 +1100 (EST) X-Greylist: delayed 2318 seconds by postgrey-1.34 at bilbo; Tue, 11 Oct 2011 20:02:59 EST Received: from sh78.surpasshosting.com (sh78.surpasshosting.com [72.29.64.142]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id DF8EFB6F72 for ; Tue, 11 Oct 2011 20:02:59 +1100 (EST) Received: from [109.67.232.84] (port=39366 helo=felix.lan) by sh78.surpasshosting.com with esmtpa (Exim 4.69) (envelope-from ) id 1RDXdA-00061n-Sr; Tue, 11 Oct 2011 04:24:09 -0400 From: Felix Radensky To: linuxppc-dev@lists.ozlabs.org Subject: [PATCH] Fix interrupt handling in MPC8xxx GPIO driver Date: Tue, 11 Oct 2011 10:24:21 +0200 Message-Id: <1318321461-3066-1-git-send-email-felix@embedded-sol.com> X-Mailer: git-send-email 1.7.4.4 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - sh78.surpasshosting.com X-AntiAbuse: Original Domain - lists.ozlabs.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embedded-sol.com X-Source: X-Source-Args: X-Source-Dir: Cc: Felix Radensky , stable@vger.kernel.org X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Interrupt handler in MPC8xxx GPIO driver is missing the call to PIC EOI (end of interrupt) handler. As a result, at least on 85XX systems, GPIO interrupt is delivered only once. This patch adds the missing EOI call. Tested on custom P1022 board. Signed-off-by: Felix Radensky --- arch/powerpc/sysdev/mpc8xxx_gpio.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/powerpc/sysdev/mpc8xxx_gpio.c b/arch/powerpc/sysdev/mpc8xxx_gpio.c index fb4963a..d2e0e1c 100644 --- a/arch/powerpc/sysdev/mpc8xxx_gpio.c +++ b/arch/powerpc/sysdev/mpc8xxx_gpio.c @@ -153,6 +153,7 @@ static void mpc8xxx_gpio_irq_cascade(unsigned int irq, struct irq_desc *desc) if (mask) generic_handle_irq(irq_linear_revmap(mpc8xxx_gc->irq, 32 - ffs(mask))); + desc->chip->eoi(irq); } static void mpc8xxx_irq_unmask(struct irq_data *d)