[1/2] board/beaglebone: fix boot on BeagleBone Black
diff mbox series

Message ID 20191102223839.16262-2-unixmania@gmail.com
State Superseded, archived
Headers show
Series
  • [1/2] board/beaglebone: fix boot on BeagleBone Black
Related show

Commit Message

Carlos Santos Nov. 2, 2019, 10:38 p.m. UTC
From: Carlos Santos <unixmania@gmail.com>

Commit 68b5b79b2f has set the getty port to the default console but left
"ttyO0" in bootargs, in the U-Boot environment. Use "ttyS0", instead.

Also set loadaddr to 0x82000000 and fdtaddr to 0x88000000, replacing the
ancient U-Boot 2013.10-dirty default values that cause system hangs.

Signed-off-by: Carlos Santos <unixmania@gmail.com>
---
 board/beaglebone/uEnv.txt | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comments

Thomas Petazzoni Nov. 8, 2019, 9:09 p.m. UTC | #1
Hello Carlos,

On Sat,  2 Nov 2019 19:38:38 -0300
unixmania@gmail.com wrote:

> From: Carlos Santos <unixmania@gmail.com>
> 
> Commit 68b5b79b2f has set the getty port to the default console but left
> "ttyO0" in bootargs, in the U-Boot environment. Use "ttyS0", instead.
> 
> Also set loadaddr to 0x82000000 and fdtaddr to 0x88000000, replacing the
> ancient U-Boot 2013.10-dirty default values that cause system hangs.

Where are we using U-Boot 2013.10-dirty on BeagleBone ?

$ grep UBOOT_CUSTOM_VERSION_VALUE configs/beaglebone*
configs/beagleboneai_defconfig:BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2019.04"
configs/beaglebone_defconfig:BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2019.07"
configs/beaglebone_qt5_defconfig:BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2016.09.01"

And these are upstream, unpatched, versions.

Could you clarify this? Otherwise the patch looks good, of course.

Thanks!

Thomas
Carlos Santos Nov. 8, 2019, 11:05 p.m. UTC | #2
On Fri, Nov 8, 2019 at 6:09 PM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
>
> Hello Carlos,
>
> On Sat,  2 Nov 2019 19:38:38 -0300
> unixmania@gmail.com wrote:
>
> > From: Carlos Santos <unixmania@gmail.com>
> >
> > Commit 68b5b79b2f has set the getty port to the default console but left
> > "ttyO0" in bootargs, in the U-Boot environment. Use "ttyS0", instead.
> >
> > Also set loadaddr to 0x82000000 and fdtaddr to 0x88000000, replacing the
> > ancient U-Boot 2013.10-dirty default values that cause system hangs.
>
> Where are we using U-Boot 2013.10-dirty on BeagleBone ?
>
> $ grep UBOOT_CUSTOM_VERSION_VALUE configs/beaglebone*
> configs/beagleboneai_defconfig:BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2019.04"
> configs/beaglebone_defconfig:BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2019.07"
> configs/beaglebone_qt5_defconfig:BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2016.09.01"
>
> And these are upstream, unpatched, versions.
>
> Could you clarify this? Otherwise the patch looks good, of course.
>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com

That's the SPL in old Beaglebone cards. I will rephrase the commit
message to clarify it.
Carlos Santos Nov. 9, 2019, 4:42 p.m. UTC | #3
On Fri, Nov 8, 2019 at 8:05 PM Carlos Santos <unixmania@gmail.com> wrote:
>
> On Fri, Nov 8, 2019 at 6:09 PM Thomas Petazzoni
> <thomas.petazzoni@bootlin.com> wrote:
> >
> > Hello Carlos,
> >
> > On Sat,  2 Nov 2019 19:38:38 -0300
> > unixmania@gmail.com wrote:
> >
> > > From: Carlos Santos <unixmania@gmail.com>
> > >
> > > Commit 68b5b79b2f has set the getty port to the default console but left
> > > "ttyO0" in bootargs, in the U-Boot environment. Use "ttyS0", instead.
> > >
> > > Also set loadaddr to 0x82000000 and fdtaddr to 0x88000000, replacing the
> > > ancient U-Boot 2013.10-dirty default values that cause system hangs.
> >
> > Where are we using U-Boot 2013.10-dirty on BeagleBone ?
> >
> > $ grep UBOOT_CUSTOM_VERSION_VALUE configs/beaglebone*
> > configs/beagleboneai_defconfig:BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2019.04"
> > configs/beaglebone_defconfig:BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2019.07"
> > configs/beaglebone_qt5_defconfig:BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2016.09.01"
> >
> > And these are upstream, unpatched, versions.
> >
> > Could you clarify this? Otherwise the patch looks good, of course.
> >
> > Thanks!
> >
> > Thomas
> > --
> > Thomas Petazzoni, CTO, Bootlin
> > Embedded Linux and Kernel engineering
> > https://bootlin.com
>
> That's the SPL in old Beaglebone cards. I will rephrase the commit
> message to clarify it.
>
> --
> Carlos Santos <unixmania@gmail.com>

Done: https://patchwork.ozlabs.org/patch/1192449/

Patch
diff mbox series

diff --git a/board/beaglebone/uEnv.txt b/board/beaglebone/uEnv.txt
index a665f20889..8fce54d87e 100644
--- a/board/beaglebone/uEnv.txt
+++ b/board/beaglebone/uEnv.txt
@@ -3,6 +3,9 @@  devtype=mmc
 bootdir=
 bootfile=zImage
 bootpartition=mmcblk0p2
+console=ttyS0,115200n8
+loadaddr=0x82000000
+fdtaddr=0x88000000
 set_mmc1=if test $board_name = A33515BB; then setenv bootpartition mmcblk1p2; fi
-set_bootargs=setenv bootargs console=ttyO0,115200n8 root=/dev/${bootpartition} rw rootfstype=ext4 rootwait
+set_bootargs=setenv bootargs console=${console} root=/dev/${bootpartition} rw rootfstype=ext4 rootwait
 uenvcmd=run set_mmc1; run set_bootargs;run loadimage;run loadfdt;printenv bootargs;bootz ${loadaddr} - ${fdtaddr}