nptl: Fix niggles with pthread_clockjoin_np
diff mbox series

Message ID 1eca4bc9d946a2aa49ed380498f2d758ceb8540b.1572685738.git-series.mac@mcrowe.com
State New
Headers show
Series
  • nptl: Fix niggles with pthread_clockjoin_np
Related show

Commit Message

Mike Crowe Nov. 2, 2019, 9:10 a.m. UTC
Joseph Myers spotted[1] that 69ca4b54c151cec42ccca5e05790efc1a8206b47 added
pthread_clockjoin_np to sysdeps/nptl/pthread.h but not to its hppa-specific
equivalent sysdeps/unix/sysv/linux/hppa/pthread.h.

Rafal Luzynski spotted[2] typos in the NEWS entry and manual updates too.

[1] https://sourceware.org/ml/libc-alpha/2019-11/msg00016.html
[2] https://sourceware.org/ml/libc-alpha/2019-11/msg00019.html

Fixes: 69ca4b54c151cec42ccca5e05790efc1a8206b47
---
 NEWS                                   |  2 +-
 manual/threads.texi                    |  2 +-
 sysdeps/unix/sysv/linux/hppa/pthread.h | 11 +++++++++++
 3 files changed, 13 insertions(+), 2 deletions(-)


base-commit: 7aeab82edb38390c2a02519d312e098f4049e867

Comments

Florian Weimer Nov. 2, 2019, 9:40 a.m. UTC | #1
* Mike Crowe:

> +extern int pthread_clockjoin_np (pthread_t __th, void **__thread_return,
> +                                 clockid_t clockid,
> +				 const struct timespec *__abstime);
>  #endif

Missing __ before clockid?  I don't think it's a reserved identifier.
It's not caught by the tests because it happens in __USE_GNU.

Rest looks okay.

Patch
diff mbox series

diff --git a/NEWS b/NEWS
index 3006b1a..2fc1f89 100644
--- a/NEWS
+++ b/NEWS
@@ -35,7 +35,7 @@  Major new features:
   tz_dsttime fields are zero.
 
 * The function pthread_clockjoin_np has been added, enabling join with a
-  terminated thread with an specific clock.  It allows waiting against
+  terminated thread with a specific clock.  It allows waiting against
   CLOCK_MONOTONIC and CLOCK_REALTIME.  This function is a GNU extension.
 
 Deprecated and removed features, and other changes affecting compatibility:
diff --git a/manual/threads.texi b/manual/threads.texi
index e40b55c..0858ef8 100644
--- a/manual/threads.texi
+++ b/manual/threads.texi
@@ -759,7 +759,7 @@  will wait forever in the same way as @code{pthread_join}.
 				      const struct timespec *@var{abstime})
 @standards{GNU, pthread.h}
 @safety{@prelim{}@mtsafe{}@asunsafe{@asulock{}}@acunsafe{@aculock{}}}
-Behaves like @code{pthread_timedjoin_np} except that time absolute time in
+Behaves like @code{pthread_timedjoin_np} except that the absolute time in
 @var{abstime} is measured against the clock specified by @var{clockid}.
 @end deftypefun
 
diff --git a/sysdeps/unix/sysv/linux/hppa/pthread.h b/sysdeps/unix/sysv/linux/hppa/pthread.h
index 424135c..38a772a 100644
--- a/sysdeps/unix/sysv/linux/hppa/pthread.h
+++ b/sysdeps/unix/sysv/linux/hppa/pthread.h
@@ -238,6 +238,17 @@  extern int pthread_tryjoin_np (pthread_t __th, void **__thread_return) __THROW;
    __THROW.  */
 extern int pthread_timedjoin_np (pthread_t __th, void **__thread_return,
 				 const struct timespec *__abstime);
+
+/* Make calling thread wait for termination of the thread TH, but only
+   until TIMEOUT measured against the clock specified by CLOCKID.  The
+   exit status of the thread is stored in *THREAD_RETURN, if
+   THREAD_RETURN is not NULL.
+
+   This function is a cancellation point and therefore not marked with
+   __THROW.  */
+extern int pthread_clockjoin_np (pthread_t __th, void **__thread_return,
+                                 clockid_t clockid,
+				 const struct timespec *__abstime);
 #endif
 
 /* Indicate that the thread TH is never to be joined with PTHREAD_JOIN.