diff mbox series

[OpenWrt-Devel,3/4] mediatek: cosmetic fixes for mt7629-lynx-rfb

Message ID 20191101032858.19013-4-gch981213@gmail.com
State Accepted, archived
Delegated to: Chuanhong Guo
Headers show
Series mediatek: add mt7629 subtarget | expand

Commit Message

Chuanhong Guo Nov. 1, 2019, 3:28 a.m. UTC
This patch did the following things:
1. rename device compatible string
2. add earlycon into cmdline
3. add mac address location according to mt7629 eeprom layout
4. rename mtd partitions

Signed-off-by: Chuanhong Guo <gch981213@gmail.com>
---
 .../files-4.19/arch/arm/boot/dts/mt7629-lynx-rfb.dts     | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

Comments

Adrian Schmutzler Nov. 1, 2019, 7:10 a.m. UTC | #1
Hi,

> @@ -75,6 +76,7 @@
>          gmac0: mac@0 {
>                  compatible = "mediatek,eth-mac";
>                  reg = <0>;
> +				mtd-mac-address = <&factory 0x2a>;

Strange indent here ...

>                  phy-mode = "sgmii";
>                  fixed-link {
>                          speed = <1000>; @@ -86,6 +88,7 @@
>          gmac1: mac@1 {
>                  compatible = "mediatek,eth-mac";
>                  reg = <1>;
> +				mtd-mac-address = <&factory 0x24>;

... and here.

Best

Adrian
Chuanhong Guo Nov. 1, 2019, 2:56 p.m. UTC | #2
On Fri, Nov 1, 2019 at 3:10 PM <mail@adrianschmutzler.de> wrote:
>
> Hi,
>
> > @@ -75,6 +76,7 @@
> >          gmac0: mac@0 {
> >                  compatible = "mediatek,eth-mac";
> >                  reg = <0>;
> > +                             mtd-mac-address = <&factory 0x2a>;
>
> Strange indent here ...

Ouch...This entire eth node uses spaces for indentation, and the tab
width in my editor is 4 spaces...
Fixed in my staging tree:
https://git.openwrt.org/?p=openwrt/staging/981213.git;a=shortlog;h=refs/heads/mt7629_target

Regards,
Chuanhong Guo
diff mbox series

Patch

diff --git a/target/linux/mediatek/files-4.19/arch/arm/boot/dts/mt7629-lynx-rfb.dts b/target/linux/mediatek/files-4.19/arch/arm/boot/dts/mt7629-lynx-rfb.dts
index f3fadd301a..17ce6046da 100644
--- a/target/linux/mediatek/files-4.19/arch/arm/boot/dts/mt7629-lynx-rfb.dts
+++ b/target/linux/mediatek/files-4.19/arch/arm/boot/dts/mt7629-lynx-rfb.dts
@@ -10,7 +10,7 @@ 
 
 / {
 	model = "MediaTek MT7629 reference board";
-	compatible = "mediatek,mt7629-rfb", "mediatek,mt7629";
+	compatible = "mediatek,mt7629-lynx-rfb", "mediatek,mt7629";
 
 	aliases {
 		serial0 = &uart0;
@@ -18,6 +18,7 @@ 
 
 	chosen {
 		stdout-path = "serial0:115200n8";
+		bootargs = "earlycon=uart8250,mmio32,0x11002000";
 	};
 
 	gpio-keys {
@@ -75,6 +76,7 @@ 
         gmac0: mac@0 {
                 compatible = "mediatek,eth-mac";
                 reg = <0>;
+				mtd-mac-address = <&factory 0x2a>;
                 phy-mode = "sgmii";
                 fixed-link {
                         speed = <1000>;
@@ -86,6 +88,7 @@ 
         gmac1: mac@1 {
                 compatible = "mediatek,eth-mac";
                 reg = <1>;
+				mtd-mac-address = <&factory 0x24>;
                 phy-handle = <&phy0>;
         };
 
@@ -153,13 +156,13 @@ 
 			};
 
 			factory: partition@70000 {
-				label = "Factory";
+				label = "factory";
 				reg = <0x70000 0x40000>;
 				read-only;
 			};
 
 			partition@b0000 {
-				label = "Kernel";
+				label = "firmware";
 				reg = <0xb0000 0xb50000>;
 			};
 		};