[SRU,Bionic,1/1] Revert "uio: use request_threaded_irq instead"
diff mbox series

Message ID 20191031162300.4003-2-kamal@canonical.com
State New
Headers show
Series
  • fix uio locking
Related show

Commit Message

Kamal Mostafa Oct. 31, 2019, 4:23 p.m. UTC
From: Xiubo Li <xiubli@redhat.com>

BugLink: https://bugs.launchpad.net/bugs/1843487

Since mutex lock in irq hanler is useless currently, here will
remove it together with it.

This reverts commit 9421e45f5ff3d558cf8b75a8cc0824530caf3453.

Reported-by: james.r.harris@intel.com
CC: Ahsan Atta <ahsan.atta@intel.com>
Signed-off-by: Xiubo Li <xiubli@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
(backported from commit 3d27c4de8d4fb2d4099ff324671792aa2578c6f9)
[kamal: applied just the mutex removal bit.]
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
---
 drivers/uio/uio.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Stefan Bader Nov. 7, 2019, 4:19 p.m. UTC | #1
On 31.10.19 17:23, Kamal Mostafa wrote:
> From: Xiubo Li <xiubli@redhat.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1843487
> 
> Since mutex lock in irq hanler is useless currently, here will
> remove it together with it.
> 
> This reverts commit 9421e45f5ff3d558cf8b75a8cc0824530caf3453.
> 
> Reported-by: james.r.harris@intel.com
> CC: Ahsan Atta <ahsan.atta@intel.com>
> Signed-off-by: Xiubo Li <xiubli@redhat.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> (backported from commit 3d27c4de8d4fb2d4099ff324671792aa2578c6f9)
> [kamal: applied just the mutex removal bit.]
> Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Acked-by: Stefan Bader <stefan.bader@canonical.com>
> ---

SRU justification in bug report!

>  drivers/uio/uio.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c
> index c7bc6b8f8d22..fb5c9701b1fb 100644
> --- a/drivers/uio/uio.c
> +++ b/drivers/uio/uio.c
> @@ -445,13 +445,10 @@ static irqreturn_t uio_interrupt(int irq, void *dev_id)
>  	struct uio_device *idev = (struct uio_device *)dev_id;
>  	irqreturn_t ret;
>  
> -	mutex_lock(&idev->info_lock);
> -
>  	ret = idev->info->handler(irq, idev->info);
>  	if (ret == IRQ_HANDLED)
>  		uio_event_notify(idev->info);
>  
> -	mutex_unlock(&idev->info_lock);
>  	return ret;
>  }
>  
>

Patch
diff mbox series

diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c
index c7bc6b8f8d22..fb5c9701b1fb 100644
--- a/drivers/uio/uio.c
+++ b/drivers/uio/uio.c
@@ -445,13 +445,10 @@  static irqreturn_t uio_interrupt(int irq, void *dev_id)
 	struct uio_device *idev = (struct uio_device *)dev_id;
 	irqreturn_t ret;
 
-	mutex_lock(&idev->info_lock);
-
 	ret = idev->info->handler(irq, idev->info);
 	if (ret == IRQ_HANDLED)
 		uio_event_notify(idev->info);
 
-	mutex_unlock(&idev->info_lock);
 	return ret;
 }