diff mbox series

[2/3] package/sysrepo: needs NPTL

Message ID 20191031121703.7628-2-fontaine.fabrice@gmail.com
State Superseded
Headers show
Series [1/3] package/sysrepo: link with libatomic when needed | expand

Commit Message

Fabrice Fontaine Oct. 31, 2019, 12:17 p.m. UTC
sysrepo needs pthread_rwlock_timedrdlock

Fixes:
 - http://autobuild.buildroot.org/results/f0e4368977f257d76aedff335af3068deafaf28f

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/sysrepo/Config.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Baruch Siach Oct. 31, 2019, 12:22 p.m. UTC | #1
Hi Fabrice,

On Thu, Oct 31, 2019 at 01:17:02PM +0100, Fabrice Fontaine wrote:
> sysrepo needs pthread_rwlock_timedrdlock
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/f0e4368977f257d76aedff335af3068deafaf28f
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/sysrepo/Config.in | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/sysrepo/Config.in b/package/sysrepo/Config.in
> index 3ad6040858..8dc4b74003 100644
> --- a/package/sysrepo/Config.in
> +++ b/package/sysrepo/Config.in
> @@ -28,8 +28,8 @@ config BR2_PACKAGE_SYSREPO_EXAMPLES
>  
>  endif
>  
> -comment "sysrepo needs a toolchain w/ C++, threads, dynamic library, gcc >= 4.8"
> +comment "sysrepo needs a toolchain w/ C++, NPTL, dynamic library, gcc >= 4.8"
>  	depends on BR2_USE_MMU
>  	depends on BR2_STATIC_LIBS || !BR2_INSTALL_LIBSTDCPP \
> -		|| !BR2_TOOLCHAIN_HAS_THREADS
> +		|| !BR2_TOOLCHAIN_HAS_NPTL

You only update the comment here. What about BR2_PACKAGE_SYSREPO itself?

baruch

>  	depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
Fabrice Fontaine Oct. 31, 2019, 1:02 p.m. UTC | #2
Dear Baruch,

Le jeu. 31 oct. 2019 à 13:37, Baruch Siach <baruch@tkos.co.il> a écrit :
>
> Hi Fabrice,
>
> On Thu, Oct 31, 2019 at 01:17:02PM +0100, Fabrice Fontaine wrote:
> > sysrepo needs pthread_rwlock_timedrdlock
> >
> > Fixes:
> >  - http://autobuild.buildroot.org/results/f0e4368977f257d76aedff335af3068deafaf28f
> >
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> > ---
> >  package/sysrepo/Config.in | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/package/sysrepo/Config.in b/package/sysrepo/Config.in
> > index 3ad6040858..8dc4b74003 100644
> > --- a/package/sysrepo/Config.in
> > +++ b/package/sysrepo/Config.in
> > @@ -28,8 +28,8 @@ config BR2_PACKAGE_SYSREPO_EXAMPLES
> >
> >  endif
> >
> > -comment "sysrepo needs a toolchain w/ C++, threads, dynamic library, gcc >= 4.8"
> > +comment "sysrepo needs a toolchain w/ C++, NPTL, dynamic library, gcc >= 4.8"
> >       depends on BR2_USE_MMU
> >       depends on BR2_STATIC_LIBS || !BR2_INSTALL_LIBSTDCPP \
> > -             || !BR2_TOOLCHAIN_HAS_THREADS
> > +             || !BR2_TOOLCHAIN_HAS_NPTL
>
> You only update the comment here. What about BR2_PACKAGE_SYSREPO itself?
Thanks for spotting this, I sent a v2.
>
> baruch
>
> >       depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
>
> --
>      http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
> =}------------------------------------------------ooO--U--Ooo------------{=
>    - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
Best Regards,

Fabrice
diff mbox series

Patch

diff --git a/package/sysrepo/Config.in b/package/sysrepo/Config.in
index 3ad6040858..8dc4b74003 100644
--- a/package/sysrepo/Config.in
+++ b/package/sysrepo/Config.in
@@ -28,8 +28,8 @@  config BR2_PACKAGE_SYSREPO_EXAMPLES
 
 endif
 
-comment "sysrepo needs a toolchain w/ C++, threads, dynamic library, gcc >= 4.8"
+comment "sysrepo needs a toolchain w/ C++, NPTL, dynamic library, gcc >= 4.8"
 	depends on BR2_USE_MMU
 	depends on BR2_STATIC_LIBS || !BR2_INSTALL_LIBSTDCPP \
-		|| !BR2_TOOLCHAIN_HAS_THREADS
+		|| !BR2_TOOLCHAIN_HAS_NPTL
 	depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"