From patchwork Mon Oct 10 12:47:36 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Paolo Carlini X-Patchwork-Id: 118731 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 0D236B71CA for ; Mon, 10 Oct 2011 23:49:44 +1100 (EST) Received: (qmail 461 invoked by alias); 10 Oct 2011 12:49:42 -0000 Received: (qmail 453 invoked by uid 22791); 10 Oct 2011 12:49:41 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from rcsinet15.oracle.com (HELO rcsinet15.oracle.com) (148.87.113.117) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 10 Oct 2011 12:49:25 +0000 Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by rcsinet15.oracle.com (Switch-3.4.4/Switch-3.4.4) with ESMTP id p9ACnIqp003271 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 10 Oct 2011 12:49:19 GMT Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id p9ACnGmQ028364 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 10 Oct 2011 12:49:17 GMT Received: from abhmt116.oracle.com (abhmt116.oracle.com [141.146.116.68]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id p9ACnBG2025148; Mon, 10 Oct 2011 07:49:11 -0500 Received: from [192.168.1.4] (/79.53.14.153) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 10 Oct 2011 05:49:11 -0700 Message-ID: <4E92E968.4020107@oracle.com> Date: Mon, 10 Oct 2011 14:47:36 +0200 From: Paolo Carlini User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0) Gecko/20110922 Thunderbird/7.0 MIME-Version: 1.0 To: "gcc-patches@gcc.gnu.org" CC: "Joseph S. Myers" , Gabriel Dos Reis , Jason Merrill Subject: Re: [C++ Patch / RFC] PR 33067 References: <4E92D995.2070907@oracle.com> <4E92E17D.4050900@oracle.com> In-Reply-To: <4E92E17D.4050900@oracle.com> X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On 10/10/2011 02:13 PM, Paolo Carlini wrote: > . looks like we want to do something else, not printing the number at > all. See audit trail. An option, for 4.7 at least, would be, instead of just closing 33067 as a duplicate of the much more general 49152, doing something like: which gives: 33067.C:2:18: error: no match for ‘operator<’ in ‘1.1e+0 < t’ Given in particular that we now have column numbers, as a user of GCC I would certainly consider it a good improvement. Just let me know... Paolo. Index: c-family/c-pretty-print.c =================================================================== --- c-family/c-pretty-print.c (revision 179745) +++ c-family/c-pretty-print.c (working copy) @@ -1019,7 +1019,7 @@ static void pp_c_floating_constant (c_pretty_printer *pp, tree r) { real_to_decimal (pp_buffer (pp)->digit_buffer, &TREE_REAL_CST (r), - sizeof (pp_buffer (pp)->digit_buffer), 0, 1); + sizeof (pp_buffer (pp)->digit_buffer), 6, 1); pp_string (pp, pp_buffer(pp)->digit_buffer); if (TREE_TYPE (r) == float_type_node) pp_character (pp, 'f');