mbox

[PULL,for-4.2,0/1] softfp patch queue

Message ID 20191030180953.24180-1-richard.henderson@linaro.org
State New
Headers show

Pull-request

https://github.com/rth7680/qemu.git tags/pull-sfp-20191030

Message

Richard Henderson Oct. 30, 2019, 6:09 p.m. UTC 
Just one easy patch that made the cutoff.


r~


The following changes since commit 16884391c750d0c5e863f55ad7aaaa146fc5181e:

  Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2019-10-29' into staging (2019-10-29 20:06:08 +0000)

are available in the Git repository at:

  https://github.com/rth7680/qemu.git tags/pull-sfp-20191030

for you to fetch changes up to 21381dcf0ca8fc822328e30570c8465ec4e52be9:

  softfp: Added hardfloat conversion from float32 to float64 (2019-10-30 19:03:37 +0100)

----------------------------------------------------------------
Use hardfloat for float32_to_float64

----------------------------------------------------------------
Matus Kysel (1):
      softfp: Added hardfloat conversion from float32 to float64

 fpu/softfloat.c | 19 ++++++++++++++++++-
 1 file changed, 18 insertions(+), 1 deletion(-)

Comments

no-reply@patchew.org Oct. 30, 2019, 9:14 p.m. UTC | #1 
Patchew URL: https://patchew.org/QEMU/20191030180953.24180-1-richard.henderson@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PULL for-4.2 0/1] softfp patch queue
Type: series
Message-id: 20191030180953.24180-1-richard.henderson@linaro.org

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
756cf34 softfp: Added hardfloat conversion from float32 to float64

=== OUTPUT BEGIN ===
ERROR: spaces required around that '*' (ctx:WxV)
#31: FILE: fpu/softfloat.c:1924:
+soft_float32_to_float64(float32 a, float_status *s)
                                                 ^

ERROR: spaces required around that '*' (ctx:WxV)
#38: FILE: fpu/softfloat.c:1931:
+float64 float32_to_float64(float32 a, float_status *s)
                                                    ^

total: 2 errors, 0 warnings, 31 lines checked

Commit 756cf34c13d0 (softfp: Added hardfloat conversion from float32 to float64) has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20191030180953.24180-1-richard.henderson@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Peter Maydell Oct. 31, 2019, 10:07 a.m. UTC | #2 
On Wed, 30 Oct 2019 at 18:09, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Just one easy patch that made the cutoff.
>
>
> r~
>
>
> The following changes since commit 16884391c750d0c5e863f55ad7aaaa146fc5181e:
>
>   Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2019-10-29' into staging (2019-10-29 20:06:08 +0000)
>
> are available in the Git repository at:
>
>   https://github.com/rth7680/qemu.git tags/pull-sfp-20191030
>
> for you to fetch changes up to 21381dcf0ca8fc822328e30570c8465ec4e52be9:
>
>   softfp: Added hardfloat conversion from float32 to float64 (2019-10-30 19:03:37 +0100)
>
> ----------------------------------------------------------------
> Use hardfloat for float32_to_float64
>
> ----------------------------------------------------------------
> Matus Kysel (1):
>       softfp: Added hardfloat conversion from float32 to float64
>
>  fpu/softfloat.c | 19 ++++++++++++++++++-


Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/4.2
for any user-visible changes.

-- PMM