diff mbox

isdn: add missing cast operator in drivers/isdn/sc/init.c

Message ID 1318244560-19213-1-git-send-email-corone.il.han@gmail.com
State Rejected, archived
Delegated to: David Miller
Headers show

Commit Message

Il Han Oct. 10, 2011, 11:02 a.m. UTC 
Add (void __iomem *) to convert the value to the proper type before passing it to readl().

Signed-off-by: Il Han <corone.il.han@gmail.com>
---
 drivers/isdn/sc/init.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

Comments

David Miller Oct. 10, 2011, 6:18 p.m. UTC | #1 
From: Il Han <corone.il.han@gmail.com>
Date: Mon, 10 Oct 2011 20:02:40 +0900

> Add (void __iomem *) to convert the value to the proper type before passing it to readl().
> 
> Signed-off-by: Il Han <corone.il.han@gmail.com>

I've rejected this patch already in the past, and this is because the correct
fix is to change the type of rambase and the variables and datastructures
it is initialized from.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/isdn/sc/init.c b/drivers/isdn/sc/init.c
index ca710ab..79bde78 100644
--- a/drivers/isdn/sc/init.c
+++ b/drivers/isdn/sc/init.c
@@ -484,7 +484,7 @@  static int identify_board(unsigned long rambase, unsigned int iobase)
 	 */
 	outb(PRI_BASEPG_VAL, pgport);
 	msleep_interruptible(1000);
-	sig = readl(rambase + SIG_OFFSET);
+	sig = readl((void __iomem *)rambase + SIG_OFFSET);
 	pr_debug("Looking for a signature, got 0x%lx\n", sig);
 	if(sig == SIGNATURE)
 		return PRI_BOARD;
@@ -494,7 +494,7 @@  static int identify_board(unsigned long rambase, unsigned int iobase)
 	 */
 	outb(BRI_BASEPG_VAL, pgport);
 	msleep_interruptible(1000);
-	sig = readl(rambase + SIG_OFFSET);
+	sig = readl((void __iomem *)rambase + SIG_OFFSET);
 	pr_debug("Looking for a signature, got 0x%lx\n", sig);
 	if(sig == SIGNATURE)
 		return BRI_BOARD;
@@ -504,7 +504,7 @@  static int identify_board(unsigned long rambase, unsigned int iobase)
 	/*
 	 * Try to spot a card
 	 */
-	sig = readl(rambase + SIG_OFFSET);
+	sig = readl((void __iomem *)rambase + SIG_OFFSET);
 	pr_debug("Looking for a signature, got 0x%lx\n", sig);
 	if(sig != SIGNATURE)
 		return -1;