[v2,1/2] mtd: spi-nor: fix silent truncation in spi_nor_read()
diff mbox series

Message ID d684c04b-7546-fe1b-7bfc-c2288f211ea8@cogentembedded.com
State Accepted
Delegated to: Ambarus Tudor
Headers show
  • Fix silent truncations in the SPI NOR driver
Related show

Commit Message

Sergei Shtylyov Oct. 30, 2019, 6:48 p.m. UTC
spi_nor_read() assigns the result of 'ssize_t spi_nor_read_data()'
to the 'int ret' variable, while 'ssize_t' is a 64-bit type and *int*
is a 32-bit type on the 64-bit machines. This silent truncation isn't
really valid, so fix up the variable's type.

Fixes: 59451e1233bd ("mtd: spi-nor: change return value of read/write")
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

Changes in version 2:
- cleaned up the patch description.

 drivers/mtd/spi-nor/spi-nor.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff mbox series

Index: linux/drivers/mtd/spi-nor/spi-nor.c
--- linux.orig/drivers/mtd/spi-nor/spi-nor.c
+++ linux/drivers/mtd/spi-nor/spi-nor.c
@@ -2544,7 +2544,7 @@  static int spi_nor_read(struct mtd_info
 			size_t *retlen, u_char *buf)
 	struct spi_nor *nor = mtd_to_spi_nor(mtd);
-	int ret;
+	ssize_t ret;
 	dev_dbg(nor->dev, "from 0x%08x, len %zd\n", (u32)from, len);