[GIT,PULL] Hisilicon driver updates for v5.5
mbox series

Message ID 5DB95DC1.50900@hisilicon.com
State New
Headers show
Series
  • [GIT,PULL] Hisilicon driver updates for v5.5
Related show

Pull-request

git://github.com/hisilicon/linux-hisi.git tags/hisi-drivers-for-5.5

Message

Wei Xu Oct. 30, 2019, 9:54 a.m. UTC
Hi ARM-SoC team,

Please consider to pull the following changes.
Thanks!

Best Regards,
Wei

---
The following changes since commit 54ecb8f7028c5eb3d740bb82b0f1d90f2df63c5c:

   Linux 5.4-rc1 (2019-09-30 10:35:40 -0700)

are available in the Git repository at:

   git://github.com/hisilicon/linux-hisi.git tags/hisi-drivers-for-5.5

for you to fetch changes up to e9541b372b229f6babd93afcc623e5428b4026a3:

   logic_pio: Build into a library (2019-10-28 20:46:05 +0800)

----------------------------------------------------------------
ARM64: hisi: SoC driver updates for 5.5

- check the LOGIC_PIO_INDIRECT region ops at registration instead of
   in the IO port accessors to optimise the lib/ligic_pio.c

- add the hisi LPC driver to the build test for the other architectures
   by updating the hisi LPC Kconfig and adding a dummy PIO_INDIRECT_SIZE

- clean the sparse complains of the hisi LPC driver

- build logic_pio into a lib to avoid including in the vmlinux when not
   referenced

----------------------------------------------------------------
John Garry (5):
       lib: logic_pio: Enforce LOGIC_PIO_INDIRECT region ops are set at 
registration
       logic_pio: Define PIO_INDIRECT_SIZE for !CONFIG_INDIRECT_PIO
       bus: hisi_lpc: Clean some types
       bus: hisi_lpc: Expand build test coverage
       logic_pio: Build into a library

  drivers/bus/Kconfig       |  4 ++--
  drivers/bus/hisi_lpc.c    |  9 ++++-----
  include/linux/logic_pio.h |  4 ++--
  lib/Makefile              |  2 +-
  lib/logic_pio.c           | 14 ++++++++------
  5 files changed, 17 insertions(+), 16 deletions(-)

Comments

John Garry Nov. 1, 2019, 10:24 a.m. UTC | #1
On 30/10/2019 09:54, Wei Xu wrote:
> Hi ARM-SoC team,
> 
> Please consider to pull the following changes.
> Thanks!
> 
> Best Regards,
> Wei
> 
> ---
> The following changes since commit 
> 54ecb8f7028c5eb3d740bb82b0f1d90f2df63c5c:
> 
>    Linux 5.4-rc1 (2019-09-30 10:35:40 -0700)
> 
> are available in the Git repository at:
> 
>    git://github.com/hisilicon/linux-hisi.git tags/hisi-drivers-for-5.5
> 
> for you to fetch changes up to e9541b372b229f6babd93afcc623e5428b4026a3:
> 
>    logic_pio: Build into a library (2019-10-28 20:46:05 +0800)
> 
> ----------------------------------------------------------------
> ARM64: hisi: SoC driver updates for 5.5
> 
> - check the LOGIC_PIO_INDIRECT region ops at registration instead of
>    in the IO port accessors to optimise the lib/ligic_pio.c
> 
> - add the hisi LPC driver to the build test for the other architectures
>    by updating the hisi LPC Kconfig and adding a dummy PIO_INDIRECT_SIZE
> 
> - clean the sparse complains of the hisi LPC driver
> 
> - build logic_pio into a lib to avoid including in the vmlinux when not
>    referenced
> 
> ----------------------------------------------------------------
> John Garry (5):
>        lib: logic_pio: Enforce LOGIC_PIO_INDIRECT region ops are set at 
> registration
>        logic_pio: Define PIO_INDIRECT_SIZE for !CONFIG_INDIRECT_PIO
>        bus: hisi_lpc: Clean some types
>        bus: hisi_lpc: Expand build test coverage

Hi xuwei,

kbuild bot is reporting a build failure for this patch:

         GCC_VERSION=7.4.0 make.cross ARCH=parisc

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

    drivers//bus/hisi_lpc.c: In function 'hisi_lpc_target_in':
 >> drivers//bus/hisi_lpc.c:137:2: error: implicit declaration of 
function 'readsb'; did you mean 'readb'? 
[-Werror=implicit-function-declaration]
      readsb(lpcdev->membase + LPC_REG_RDATA, buf, opcnt);
      ^~~~~~
      readb
    drivers//bus/hisi_lpc.c: In function 'hisi_lpc_target_out':
 >> drivers//bus/hisi_lpc.c:180:2: error: implicit declaration of 
function 'writesb'; did you mean 'writeb'? 
[-Werror=implicit-function-declaration]
      writesb(lpcdev->membase + LPC_REG_WDATA, buf, opcnt);
      ^~~~~~~
      writeb
    cc1: some warnings being treated as errors

vim +137 drivers//bus/hisi_lpc.c

It seems that parisc has no definition for {read/write}sb().

I audited io.h for all architectures, and it seems that 3 in total would 
not define {read/write}sb(): hexagon, parisc, alpha

So these don't include asm-generic/io.h and do not define their own 
version of read/writesb(). I'm thinking that they should do.

Quite frustrating.

I guess that this now can't be picked up now.

To fix, I suppose that I need not expand test coverage to these archs 
for now, and then also add {read/write}sb() definitions for these archs. 
Or they can include asm-generic.h, but this may create more problems.

Arnd, Any opinion on this?

Thanks,
John

>        logic_pio: Build into a library
> 
>   drivers/bus/Kconfig       |  4 ++--
>   drivers/bus/hisi_lpc.c    |  9 ++++-----
>   include/linux/logic_pio.h |  4 ++--
>   lib/Makefile              |  2 +-
>   lib/logic_pio.c           | 14 ++++++++------
>   5 files changed, 17 insertions(+), 16 deletions(-)
> 
> 
> 
> .
Wei Xu Nov. 4, 2019, 12:40 a.m. UTC | #2
Hi ARM-SoC team,

Sorry there are some build failures for this pull on the parisc, hexagon 
and alpha architectures.
Please ignore this pull request.
We will fix them and resend.
Thanks!

Best Regards,
Wei

On 2019/10/30 17:54, Wei Xu wrote:
> Hi ARM-SoC team,
>
> Please consider to pull the following changes.
> Thanks!
>
> Best Regards,
> Wei
>
> ---
> The following changes since commit 
> 54ecb8f7028c5eb3d740bb82b0f1d90f2df63c5c:
>
>   Linux 5.4-rc1 (2019-09-30 10:35:40 -0700)
>
> are available in the Git repository at:
>
>   git://github.com/hisilicon/linux-hisi.git tags/hisi-drivers-for-5.5
>
> for you to fetch changes up to e9541b372b229f6babd93afcc623e5428b4026a3:
>
>   logic_pio: Build into a library (2019-10-28 20:46:05 +0800)
>
> ----------------------------------------------------------------
> ARM64: hisi: SoC driver updates for 5.5
>
> - check the LOGIC_PIO_INDIRECT region ops at registration instead of
>   in the IO port accessors to optimise the lib/ligic_pio.c
>
> - add the hisi LPC driver to the build test for the other architectures
>   by updating the hisi LPC Kconfig and adding a dummy PIO_INDIRECT_SIZE
>
> - clean the sparse complains of the hisi LPC driver
>
> - build logic_pio into a lib to avoid including in the vmlinux when not
>   referenced
>
> ----------------------------------------------------------------
> John Garry (5):
>       lib: logic_pio: Enforce LOGIC_PIO_INDIRECT region ops are set at 
> registration
>       logic_pio: Define PIO_INDIRECT_SIZE for !CONFIG_INDIRECT_PIO
>       bus: hisi_lpc: Clean some types
>       bus: hisi_lpc: Expand build test coverage
>       logic_pio: Build into a library
>
>  drivers/bus/Kconfig       |  4 ++--
>  drivers/bus/hisi_lpc.c    |  9 ++++-----
>  include/linux/logic_pio.h |  4 ++--
>  lib/Makefile              |  2 +-
>  lib/logic_pio.c           | 14 ++++++++------
>  5 files changed, 17 insertions(+), 16 deletions(-)
>
>