| Message ID | 20191029220019.26773-15-digetx@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | More improvements for Tegra30 devfreq driver | expand |
On 19. 10. 30. 오전 7:00, Dmitry Osipenko wrote: > Consecutive up/down interrupt-bit is set in the interrupt status register > only if that interrupt was previously enabled. Thus enabling the already > enabled interrupt doesn't do much for us. > > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> > --- > drivers/devfreq/tegra30-devfreq.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c > index 9cbee82880ff..a9336cf4b37a 100644 > --- a/drivers/devfreq/tegra30-devfreq.c > +++ b/drivers/devfreq/tegra30-devfreq.c > @@ -261,8 +261,6 @@ static void actmon_isr_device(struct tegra_devfreq *tegra, > > if (dev->boost_freq >= tegra->max_freq) > dev->boost_freq = tegra->max_freq; > - else > - dev_ctrl |= ACTMON_DEV_CTRL_CONSECUTIVE_ABOVE_WMARK_EN; > } else if (intr_status & ACTMON_DEV_INTR_CONSECUTIVE_LOWER) { > /* > * new_boost = old_boost * down_coef > @@ -275,8 +273,6 @@ static void actmon_isr_device(struct tegra_devfreq *tegra, > > if (dev->boost_freq < (ACTMON_BOOST_FREQ_STEP >> 1)) > dev->boost_freq = 0; > - else > - dev_ctrl |= ACTMON_DEV_CTRL_CONSECUTIVE_BELOW_WMARK_EN; > } > > if (dev->config->avg_dependency_threshold) { > Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c index 9cbee82880ff..a9336cf4b37a 100644 --- a/drivers/devfreq/tegra30-devfreq.c +++ b/drivers/devfreq/tegra30-devfreq.c @@ -261,8 +261,6 @@ static void actmon_isr_device(struct tegra_devfreq *tegra, if (dev->boost_freq >= tegra->max_freq) dev->boost_freq = tegra->max_freq; - else - dev_ctrl |= ACTMON_DEV_CTRL_CONSECUTIVE_ABOVE_WMARK_EN; } else if (intr_status & ACTMON_DEV_INTR_CONSECUTIVE_LOWER) { /* * new_boost = old_boost * down_coef @@ -275,8 +273,6 @@ static void actmon_isr_device(struct tegra_devfreq *tegra, if (dev->boost_freq < (ACTMON_BOOST_FREQ_STEP >> 1)) dev->boost_freq = 0; - else - dev_ctrl |= ACTMON_DEV_CTRL_CONSECUTIVE_BELOW_WMARK_EN; } if (dev->config->avg_dependency_threshold) {
Consecutive up/down interrupt-bit is set in the interrupt status register only if that interrupt was previously enabled. Thus enabling the already enabled interrupt doesn't do much for us. Signed-off-by: Dmitry Osipenko <digetx@gmail.com> --- drivers/devfreq/tegra30-devfreq.c | 4 ---- 1 file changed, 4 deletions(-)