| Message ID | 20191029170849.GA6279@saurav |
|---|---|
| State | Changes Requested |
| Delegated to: | Miquel Raynal |
| Headers | show |
| Series | [v1] mtd: devices: phram.c: Fix multiple kfree statement from phram_setup | expand |
Saurav, Saurav Girepunje <saurav.girepunje@gmail.com> wrote on Tue, 29 Oct 2019 22:38:49 +0530: Are you a robot? > Remove multiple kfree statement from phram_setup() in phram.c This does not describe what you are doing, you don't remove them you factorize them. And honestly I am not convinced this change is useful in old code. > > Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com> > --- > > Change in v1: Your first version is v1, how can you be at v1? It is almost v3 already! > > - Add change suggested by Miquel Raynal <miquel.raynal@bootlin.com> > "The goto statement should not describe from where it is called but the > action it is supposed to take. 'goto free_nam;' would be better." This is a copy/paste of what I have said. What I want you to write is: " - Rename the goto statement to describe bla bla bla. - Fix the typo in the goto label. " > > drivers/mtd/devices/phram.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/mtd/devices/phram.c b/drivers/mtd/devices/phram.c > index c467286ca007..38f95a1517ac 100644 > --- a/drivers/mtd/devices/phram.c > +++ b/drivers/mtd/devices/phram.c > @@ -243,22 +243,22 @@ static int phram_setup(const char *val) > > ret = parse_num64(&start, token[1]); > if (ret) { > - kfree(name); > parse_err("illegal start address\n"); > + goto free_nam; Come one... Thanks, Miquèl
Hi Saurav, Saurav Girepunje <saurav.girepunje@gmail.com> wrote on Wed, 30 Oct 2019 16:57:06 +0530: > Are you a robot? > No > > Thanks for you input. Will dorp this patch if you are not convinced for > changes. > > Due to your suggestions only I learned how to add version and change log in > patch file. However I did mistake in this patch version and change log but > I learned about it.Before sending this I was totally unaware about these > things. > > Thanks again for your help.... Ok then please have a look at this, first: https://elixir.bootlin.com/linux/latest/source/Documentation/process/submitting-patches.rst And please make sure you address the comments. I told you to fix a typo, you added it in your changelog but you forgot to actually do the change. Please do not hurry when you want to submit changes and reread them before actually sending them. > > On Wed, 30 Oct, 2019, 1:50 PM Miquel Raynal, <miquel.raynal@bootlin.com> > wrote: > > > Saurav, > > > > Saurav Girepunje <saurav.girepunje@gmail.com> wrote on Tue, 29 Oct 2019 > > 22:38:49 +0530: > > > > Are you a robot? > > > > > Remove multiple kfree statement from phram_setup() in phram.c > > > > This does not describe what you are doing, you don't remove them you > > factorize them. And honestly I am not convinced this change is useful > > in old code. > > > > > > > > Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com> > > > --- > > > > > > Change in v1: > > > > Your first version is v1, how can you be at v1? It is almost v3 already! > > > > > > > > - Add change suggested by Miquel Raynal <miquel.raynal@bootlin.com> > > > "The goto statement should not describe from where it is called but the > > > action it is supposed to take. 'goto free_nam;' would be better." > > > > This is a copy/paste of what I have said. What I want you to write is: > > > > " > > - Rename the goto statement to describe bla bla bla. > > - Fix the typo in the goto label. > > " > > > > > > > > drivers/mtd/devices/phram.c | 8 ++++---- > > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > > > diff --git a/drivers/mtd/devices/phram.c b/drivers/mtd/devices/phram.c > > > index c467286ca007..38f95a1517ac 100644 > > > --- a/drivers/mtd/devices/phram.c > > > +++ b/drivers/mtd/devices/phram.c > > > @@ -243,22 +243,22 @@ static int phram_setup(const char *val) > > > > > > ret = parse_num64(&start, token[1]); > > > if (ret) { > > > - kfree(name); > > > parse_err("illegal start address\n"); > > > + goto free_nam; > > > > Come one... > > > > > > Thanks, > > Miquèl > > Thanks, Miquèl
diff --git a/drivers/mtd/devices/phram.c b/drivers/mtd/devices/phram.c index c467286ca007..38f95a1517ac 100644 --- a/drivers/mtd/devices/phram.c +++ b/drivers/mtd/devices/phram.c @@ -243,22 +243,22 @@ static int phram_setup(const char *val) ret = parse_num64(&start, token[1]); if (ret) { - kfree(name); parse_err("illegal start address\n"); + goto free_nam; } ret = parse_num64(&len, token[2]); if (ret) { - kfree(name); parse_err("illegal device length\n"); + goto free_nam; } ret = register_device(name, start, len); if (!ret) pr_info("%s device: %#llx at %#llx\n", name, len, start); - else - kfree(name); +free_nam: + kfree(name); return ret; }
Remove multiple kfree statement from phram_setup() in phram.c Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com> --- Change in v1: - Add change suggested by Miquel Raynal <miquel.raynal@bootlin.com> "The goto statement should not describe from where it is called but the action it is supposed to take. 'goto free_nam;' would be better." drivers/mtd/devices/phram.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)