Comment out initgroups from example nsswitch.conf (Bug 25146)
diff mbox series

Message ID ec6cbffc-09f5-dfab-1c92-3a38ba0d575d@redhat.com
State New
Headers show
Series
  • Comment out initgroups from example nsswitch.conf (Bug 25146)
Related show

Commit Message

Carlos O'Donell Oct. 29, 2019, 4:07 p.m. UTC
In commit 4b7c74179c8928d971d370e1137d202f891a4cf5 the nsswitch.conf
file was harmonized with downstream distributions, but this change
included adding "initgroups: files". We should not add initgroups by
default, we can have it, but it should be commented out to allow it
to inherit the settings from groups. The problem is principally that
downstream authconfig won't update initgroups and it will get out of
sync with groups.
---
 nss/nsswitch.conf | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Florian Weimer Oct. 29, 2019, 4:09 p.m. UTC | #1
* Carlos O'Donell:

> In commit 4b7c74179c8928d971d370e1137d202f891a4cf5 the nsswitch.conf
> file was harmonized with downstream distributions, but this change
> included adding "initgroups: files". We should not add initgroups by
> default, we can have it, but it should be commented out to allow it
> to inherit the settings from groups. The problem is principally that

Typo: "group"

> downstream authconfig won't update initgroups and it will get out of
> sync with groups.

Likewise.

> ---
>  nss/nsswitch.conf | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/nss/nsswitch.conf b/nss/nsswitch.conf
> index f553588114..9156af32ea 100644
> --- a/nss/nsswitch.conf
> +++ b/nss/nsswitch.conf
> @@ -58,7 +58,8 @@ ethers:     files
>  group:      files
>  gshadow:    files
>  hosts:      files dns
> -initgroups: files
> +# Allow initgroups to default to groups.
> +# initgroups: files

Typo: "group".  Or "the setting for group".

Okay with either change.

Thanks,
Florian
Carlos O'Donell Oct. 29, 2019, 5:10 p.m. UTC | #2
On 10/29/19 12:09 PM, Florian Weimer wrote:
> * Carlos O'Donell:
> 
>> In commit 4b7c74179c8928d971d370e1137d202f891a4cf5 the nsswitch.conf
>> file was harmonized with downstream distributions, but this change
>> included adding "initgroups: files". We should not add initgroups by
>> default, we can have it, but it should be commented out to allow it
>> to inherit the settings from groups. The problem is principally that
> 
> Typo: "group"

Fixed.

>> downstream authconfig won't update initgroups and it will get out of
>> sync with groups.
> 
> Likewise.

Fixed.

>> ---
>>  nss/nsswitch.conf | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/nss/nsswitch.conf b/nss/nsswitch.conf
>> index f553588114..9156af32ea 100644
>> --- a/nss/nsswitch.conf
>> +++ b/nss/nsswitch.conf
>> @@ -58,7 +58,8 @@ ethers:     files
>>  group:      files
>>  gshadow:    files
>>  hosts:      files dns
>> -initgroups: files
>> +# Allow initgroups to default to groups.
>> +# initgroups: files
> 
> Typo: "group".  Or "the setting for group".

Used "# Allow initgroups to default to the setting for group."

> Okay with either change.

Pushed. Thanks!

Patch
diff mbox series

diff --git a/nss/nsswitch.conf b/nss/nsswitch.conf
index f553588114..9156af32ea 100644
--- a/nss/nsswitch.conf
+++ b/nss/nsswitch.conf
@@ -58,7 +58,8 @@  ethers:     files
 group:      files
 gshadow:    files
 hosts:      files dns
-initgroups: files
+# Allow initgroups to default to groups.
+# initgroups: files
 netgroup:   files
 networks:   files dns
 passwd:     files