| Message ID | 20191029111615.3706-7-tudor.ambarus@microchip.com |
|---|---|
| State | Accepted |
| Delegated to: | Ambarus Tudor |
| Headers | show |
| Series | mtd: spi-nor: Quad Enable and (un)lock methods | expand |
On Tue, 29 Oct 2019 11:16:57 +0000 <Tudor.Ambarus@microchip.com> wrote: > From: Tudor Ambarus <tudor.ambarus@microchip.com> > > Print identifying information about struct device. > > Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com> > --- > drivers/mtd/spi-nor/spi-nor.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c > index e801f390728c..c794eff69fe9 100644 > --- a/drivers/mtd/spi-nor/spi-nor.c > +++ b/drivers/mtd/spi-nor/spi-nor.c > @@ -448,7 +448,7 @@ static int spi_nor_read_sr(struct spi_nor *nor) > } > > if (ret) { > - pr_err("error %d reading SR\n", ret); > + dev_err(nor->dev, "error %d reading SR\n", ret); nor->dev is not exactly what we should use since it points to the SPI NOR controller device in the !SPI_MEM case, and those controllers can be attached several SPI NOR devs. Ideally we should use mtd->dev, but that requires splitting the MTD initialization and registration steps so mtd->dev can have a valid name before registration time. Anyway, I guess this change is good enough for now, just mentioned the problem in case anyone is interested working on it. Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com> > return ret; > } > > @@ -478,7 +478,7 @@ static int spi_nor_read_fsr(struct spi_nor *nor) > } > > if (ret) { > - pr_err("error %d reading FSR\n", ret); > + dev_err(nor->dev, "error %d reading FSR\n", ret); > return ret; > } >
On 10/29/2019 01:16 PM, Tudor Ambarus - M18064 wrote: > From: Tudor Ambarus <tudor.ambarus@microchip.com> > > Print identifying information about struct device. > > Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com> > --- > drivers/mtd/spi-nor/spi-nor.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Changed subject to "mtd: spi-nor: Print device info in case of error" and applied to spi-nor/next. Thanks.
diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c index e801f390728c..c794eff69fe9 100644 --- a/drivers/mtd/spi-nor/spi-nor.c +++ b/drivers/mtd/spi-nor/spi-nor.c @@ -448,7 +448,7 @@ static int spi_nor_read_sr(struct spi_nor *nor) } if (ret) { - pr_err("error %d reading SR\n", ret); + dev_err(nor->dev, "error %d reading SR\n", ret); return ret; } @@ -478,7 +478,7 @@ static int spi_nor_read_fsr(struct spi_nor *nor) } if (ret) { - pr_err("error %d reading FSR\n", ret); + dev_err(nor->dev, "error %d reading FSR\n", ret); return ret; }