| Message ID | 1572244520-14737-1-git-send-email-jasowang@redhat.com |
|---|---|
| State | New |
| Headers | show |
On Mon, 28 Oct 2019 at 06:35, Jason Wang <jasowang@redhat.com> wrote: > > The following changes since commit 187f35512106501fe9a11057f4d8705431e0026d: > > Merge remote-tracking branch 'remotes/stsquad/tags/pull-testing-next-251019-3' into staging (2019-10-26 10:13:48 +0100) > > are available in the git repository at: > > https://github.com/jasowang/qemu.git tags/net-pull-request > > for you to fetch changes up to 5af982a47cf6b6cd9beb872e5a9b940e43df5bf9: > > COLO-compare: Fix incorrect `if` logic (2019-10-28 14:28:31 +0800) > > ---------------------------------------------------------------- > > ---------------------------------------------------------------- Hi -- I get this compile failure on some hosts (s390, aarch64, aarch32, ppc): /home/pm215/qemu/hw/net/tulip.c: In function ‘tulip_idblock_crc’: /home/pm215/qemu/hw/net/tulip.c:859:9: error: comparison is always true due to limited range of data type [-Werror=type-limits] for (bit = 15; bit >= 0; bit--) { ^ 'bit' here is of type char, which can be either signed or unsigned depending on the host. If it's unsigned (as is the case on the above architectures), then the loop will never terminate because "bit >= 0" is always true. Plain old 'int' is probably a better choice anyway. thanks -- PMM
On 2019/10/29 上午5:42, Peter Maydell wrote: > On Mon, 28 Oct 2019 at 06:35, Jason Wang <jasowang@redhat.com> wrote: >> The following changes since commit 187f35512106501fe9a11057f4d8705431e0026d: >> >> Merge remote-tracking branch 'remotes/stsquad/tags/pull-testing-next-251019-3' into staging (2019-10-26 10:13:48 +0100) >> >> are available in the git repository at: >> >> https://github.com/jasowang/qemu.git tags/net-pull-request >> >> for you to fetch changes up to 5af982a47cf6b6cd9beb872e5a9b940e43df5bf9: >> >> COLO-compare: Fix incorrect `if` logic (2019-10-28 14:28:31 +0800) >> >> ---------------------------------------------------------------- >> >> ---------------------------------------------------------------- > Hi -- I get this compile failure on some hosts (s390, aarch64, > aarch32, ppc): > > /home/pm215/qemu/hw/net/tulip.c: In function ‘tulip_idblock_crc’: > /home/pm215/qemu/hw/net/tulip.c:859:9: error: comparison is always > true due to limited range of data type [-Werror=type-limits] > for (bit = 15; bit >= 0; bit--) { > ^ > > 'bit' here is of type char, which can be either signed > or unsigned depending on the host. If it's unsigned > (as is the case on the above architectures), then the > loop will never terminate because "bit >= 0" is always true. > Plain old 'int' is probably a better choice anyway. Yes, will fix and post V2. Thanks > > thanks > -- PMM >
The following changes since commit 187f35512106501fe9a11057f4d8705431e0026d: Merge remote-tracking branch 'remotes/stsquad/tags/pull-testing-next-251019-3' into staging (2019-10-26 10:13:48 +0100) are available in the git repository at: https://github.com/jasowang/qemu.git tags/net-pull-request for you to fetch changes up to 5af982a47cf6b6cd9beb872e5a9b940e43df5bf9: COLO-compare: Fix incorrect `if` logic (2019-10-28 14:28:31 +0800) ---------------------------------------------------------------- ---------------------------------------------------------------- Fan Yang (1): COLO-compare: Fix incorrect `if` logic Michael S. Tsirkin (1): virtio: new post_load hook Mikhail Sennikovsky (1): virtio-net: prevent offloads reset on migration Sven Schnelle (1): net: add tulip (dec21143) driver MAINTAINERS | 6 + hw/net/Kconfig | 5 + hw/net/Makefile.objs | 1 + hw/net/trace-events | 14 + hw/net/tulip.c | 1029 ++++++++++++++++++++++++++++++++++++++++ hw/net/tulip.h | 267 +++++++++++ hw/net/virtio-net.c | 27 +- hw/virtio/virtio.c | 7 + include/hw/pci/pci_ids.h | 1 + include/hw/virtio/virtio-net.h | 2 + include/hw/virtio/virtio.h | 6 + net/colo-compare.c | 6 +- 12 files changed, 1365 insertions(+), 6 deletions(-) create mode 100644 hw/net/tulip.c create mode 100644 hw/net/tulip.h