[v2,18/30] ldbl-128ibm-compat: Add tests for strfroml, strtold, and wcstold
diff mbox series

Message ID 20191025153410.15405-19-gabriel@inconstante.net.br
State New
Headers show
Series
  • Add IEEE long double <-> string functions for powerpc64le
Related show

Commit Message

Gabriel F. T. Gomes Oct. 25, 2019, 3:33 p.m. UTC
From: "Gabriel F. T. Gomes" <gabrielftg@linux.ibm.com>

No changes since v1.

-- 8< --
Since the commit

commit 86a0f56158bd9cbaf2d640e2e6c66539f4cbbcc1
Author: Rajalakshmi Srinivasaraghavan <raji@linux.vnet.ibm.com>
Date:   Thu Jun 28 13:57:50 2018 +0530

    ldbl-128ibm-compat: Introduce ieee128 symbols

IEEE long double versions of strfroml, strtold, and wcstold have been
prepared, but not exposed (which will only happen when the full support
for IEEE long double is complete).  This patch adds tests for these
functions in both IBM and IEEE long double mode.
---
 sysdeps/ieee754/ldbl-128ibm-compat/Makefile   | 12 +++++
 .../ldbl-128ibm-compat/test-strfrom-ibm128.c  |  1 +
 .../ldbl-128ibm-compat/test-strfrom-ieee128.c |  1 +
 .../test-strfrom-ldbl-compat.c                | 49 +++++++++++++++++++
 .../ldbl-128ibm-compat/test-wcstold-ibm128.c  |  1 +
 .../ldbl-128ibm-compat/test-wcstold-ieee128.c |  1 +
 .../test-wcstold-ldbl-compat.c                | 36 ++++++++++++++
 7 files changed, 101 insertions(+)
 create mode 100644 sysdeps/ieee754/ldbl-128ibm-compat/test-strfrom-ibm128.c
 create mode 100644 sysdeps/ieee754/ldbl-128ibm-compat/test-strfrom-ieee128.c
 create mode 100644 sysdeps/ieee754/ldbl-128ibm-compat/test-strfrom-ldbl-compat.c
 create mode 100644 sysdeps/ieee754/ldbl-128ibm-compat/test-wcstold-ibm128.c
 create mode 100644 sysdeps/ieee754/ldbl-128ibm-compat/test-wcstold-ieee128.c
 create mode 100644 sysdeps/ieee754/ldbl-128ibm-compat/test-wcstold-ldbl-compat.c

Comments

Paul E Murphy Nov. 14, 2019, 6:25 p.m. UTC | #1
On 10/25/19 10:33 AM, Gabriel F. T. Gomes wrote:
> From: "Gabriel F. T. Gomes" <gabrielftg@linux.ibm.com>
> 
> No changes since v1.
> 
> -- 8< --
> Since the commit
> 
> commit 86a0f56158bd9cbaf2d640e2e6c66539f4cbbcc1
> Author: Rajalakshmi Srinivasaraghavan <raji@linux.vnet.ibm.com>
> Date:   Thu Jun 28 13:57:50 2018 +0530
> 
>      ldbl-128ibm-compat: Introduce ieee128 symbols
> 
> IEEE long double versions of strfroml, strtold, and wcstold have been
> prepared, but not exposed (which will only happen when the full support
> for IEEE long double is complete).  This patch adds tests for these
> functions in both IBM and IEEE long double mode.

> diff --git a/sysdeps/ieee754/ldbl-128ibm-compat/Makefile b/sysdeps/ieee754/ldbl-128ibm-compat/Makefile
> diff --git a/sysdeps/ieee754/ldbl-128ibm-compat/test-strfrom-ibm128.c b/sysdeps/ieee754/ldbl-128ibm-compat/test-strfrom-ibm128.c
> diff --git a/sysdeps/ieee754/ldbl-128ibm-compat/test-strfrom-ieee128.c b/sysdeps/ieee754/ldbl-128ibm-compat/test-strfrom-ieee128.c

OK

> diff --git a/sysdeps/ieee754/ldbl-128ibm-compat/test-strfrom-ldbl-compat.c b/sysdeps/ieee754/ldbl-128ibm-compat/test-strfrom-ldbl-compat.c
OK

> diff --git a/sysdeps/ieee754/ldbl-128ibm-compat/test-wcstold-ibm128.c b/sysdeps/ieee754/ldbl-128ibm-compat/test-wcstold-ibm128.c
> diff --git a/sysdeps/ieee754/ldbl-128ibm-compat/test-wcstold-ieee128.c b/sysdeps/ieee754/ldbl-128ibm-compat/test-wcstold-ieee128.c

OK

> diff --git a/sysdeps/ieee754/ldbl-128ibm-compat/test-wcstold-ldbl-compat.c b/sysdeps/ieee754/ldbl-128ibm-compat/test-wcstold-ldbl-compat.c
> new file mode 100644
> index 0000000000..8b9e300147
> --- /dev/null
> +++ b/sysdeps/ieee754/ldbl-128ibm-compat/test-wcstold-ldbl-compat.c
> @@ -0,0 +1,36 @@
> +/* Test for the long double variant of wcstold.
> +   Copyright (C) 2019 Free Software Foundation, Inc.
> +   This file is part of the GNU C Library.
> +
> +   The GNU C Library is free software; you can redistribute it and/or
> +   modify it under the terms of the GNU Lesser General Public
> +   License as published by the Free Software Foundation; either
> +   version 2.1 of the License, or (at your option) any later version.
> +
> +   The GNU C Library is distributed in the hope that it will be useful,
> +   but WITHOUT ANY WARRANTY; without even the implied warranty of
> +   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> +   Lesser General Public License for more details.
> +
> +   You should have received a copy of the GNU Lesser General Public
> +   License along with the GNU C Library; if not, see
> +   <http://www.gnu.org/licenses/>.  */
> +
> +#include <wchar.h>
> +
> +#include <support/check.h>
> +
> +static int
> +do_test (void)
> +{
> +  const wchar_t *input = L"-1.0000000000";
> +  long double read;
> +
> +  read = wcstold (input, NULL);
> +  if (read != (long double) -1)

Trivial nit, any reason to avoid using -1.0L directly (likewise for 
test-wcstold-ldbl-compat.c)?

> +    support_record_failure ();
> +
> +  return 0;
> +}
> +
> +#include <support/test-driver.c>
>
Gabriel F. T. Gomes Nov. 27, 2019, 5:47 p.m. UTC | #2
On Thu, 14 Nov 2019, Paul E Murphy wrote:

>On 10/25/19 10:33 AM, Gabriel F. T. Gomes wrote:
>>
>> +  if (read != (long double) -1)  
>
>Trivial nit, any reason to avoid using -1.0L directly (likewise for 
>test-wcstold-ldbl-compat.c)?

No reason, really.  I applied this suggestion locally (in both files).
Gabriel F. T. Gomes Dec. 3, 2019, 4:58 p.m. UTC | #3
On Wed, 27 Nov 2019, Gabriel F. T. Gomes wrote:

>On Thu, 14 Nov 2019, Paul E Murphy wrote:
>
>>On 10/25/19 10:33 AM, Gabriel F. T. Gomes wrote:  
>>>
>>> +  if (read != (long double) -1)    
>>
>>Trivial nit, any reason to avoid using -1.0L directly (likewise for 
>>test-wcstold-ldbl-compat.c)?  
>
>No reason, really.  I applied this suggestion locally (in both files).

Now pushed with this change.  Thanks.

Patch
diff mbox series

diff --git a/sysdeps/ieee754/ldbl-128ibm-compat/Makefile b/sysdeps/ieee754/ldbl-128ibm-compat/Makefile
index 83c2c43ea4..6f1794fac8 100644
--- a/sysdeps/ieee754/ldbl-128ibm-compat/Makefile
+++ b/sysdeps/ieee754/ldbl-128ibm-compat/Makefile
@@ -13,6 +13,12 @@  ldbl-extra-routines += isoc99_fwscanf \
 		       isoc99_vfwscanf \
 		       isoc99_vswscanf \
 		       isoc99_vwscanf
+
+tests-internal += test-wcstold-ibm128 test-wcstold-ieee128
+CFLAGS-test-wcstold-ieee128.c += -mfloat128 -mabi=ieeelongdouble -Wno-psabi
+CFLAGS-test-wcstold-ibm128.c += -mabi=ibmlongdouble -Wno-psabi
+
+$(objpfx)test-wcstold-ieee128: gnulib-tests += $(f128-loader-link)
 endif
 
 ifeq ($(subdir),stdio-common)
@@ -287,6 +293,12 @@  CFLAGS-test-strfmon-ibm128.c += -mabi=ibmlongdouble -Wno-psabi
 CFLAGS-test-strfmon-ieee128.c += -mfloat128 -mabi=ieeelongdouble -Wno-psabi
 $(objpfx)tst-strfmon-ibm128.out: $(gen-locales)
 $(objpfx)tst-strfmon-ieee128.out: $(gen-locales)
+
+tests-internal += test-strfrom-ibm128 test-strfrom-ieee128
+CFLAGS-test-strfrom-ieee128.c += -mfloat128 -mabi=ieeelongdouble -Wno-psabi
+CFLAGS-test-strfrom-ibm128.c += -mabi=ibmlongdouble -Wno-psabi
+
+$(objpfx)test-strfrom-ieee128: gnulib-tests += $(f128-loader-link)
 endif
 
 # Add IEEE binary128 files as make targets.
diff --git a/sysdeps/ieee754/ldbl-128ibm-compat/test-strfrom-ibm128.c b/sysdeps/ieee754/ldbl-128ibm-compat/test-strfrom-ibm128.c
new file mode 100644
index 0000000000..93887706b9
--- /dev/null
+++ b/sysdeps/ieee754/ldbl-128ibm-compat/test-strfrom-ibm128.c
@@ -0,0 +1 @@ 
+#include <test-strfrom-ldbl-compat.c>
diff --git a/sysdeps/ieee754/ldbl-128ibm-compat/test-strfrom-ieee128.c b/sysdeps/ieee754/ldbl-128ibm-compat/test-strfrom-ieee128.c
new file mode 100644
index 0000000000..93887706b9
--- /dev/null
+++ b/sysdeps/ieee754/ldbl-128ibm-compat/test-strfrom-ieee128.c
@@ -0,0 +1 @@ 
+#include <test-strfrom-ldbl-compat.c>
diff --git a/sysdeps/ieee754/ldbl-128ibm-compat/test-strfrom-ldbl-compat.c b/sysdeps/ieee754/ldbl-128ibm-compat/test-strfrom-ldbl-compat.c
new file mode 100644
index 0000000000..f32548fe90
--- /dev/null
+++ b/sysdeps/ieee754/ldbl-128ibm-compat/test-strfrom-ldbl-compat.c
@@ -0,0 +1,49 @@ 
+/* Test for the long double variants of strfroml and strtold.
+   Copyright (C) 2019 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, see
+   <http://www.gnu.org/licenses/>.  */
+
+#include <stdlib.h>
+
+#include <support/check.h>
+
+static int
+do_test (void)
+{
+  int written;
+  char buffer[64];
+  char *bufptr = buffer;
+  const char *expected = "-1.0000000000";
+  long double read;
+
+  /* Write to the buffer.  */
+  written = strfroml (bufptr, 64, "%.10f", (long double) -1);
+  if (written < 0)
+    support_record_failure ();
+
+  /* Compare against the expected output.  */
+  TEST_COMPARE_STRING (expected, buffer);
+
+  /* Read from the buffer.  */
+  read = strtold (expected, NULL);
+
+  if (read != (long double) -1)
+    support_record_failure ();
+
+  return 0;
+}
+
+#include <support/test-driver.c>
diff --git a/sysdeps/ieee754/ldbl-128ibm-compat/test-wcstold-ibm128.c b/sysdeps/ieee754/ldbl-128ibm-compat/test-wcstold-ibm128.c
new file mode 100644
index 0000000000..4d60692eeb
--- /dev/null
+++ b/sysdeps/ieee754/ldbl-128ibm-compat/test-wcstold-ibm128.c
@@ -0,0 +1 @@ 
+#include <test-wcstold-ldbl-compat.c>
diff --git a/sysdeps/ieee754/ldbl-128ibm-compat/test-wcstold-ieee128.c b/sysdeps/ieee754/ldbl-128ibm-compat/test-wcstold-ieee128.c
new file mode 100644
index 0000000000..4d60692eeb
--- /dev/null
+++ b/sysdeps/ieee754/ldbl-128ibm-compat/test-wcstold-ieee128.c
@@ -0,0 +1 @@ 
+#include <test-wcstold-ldbl-compat.c>
diff --git a/sysdeps/ieee754/ldbl-128ibm-compat/test-wcstold-ldbl-compat.c b/sysdeps/ieee754/ldbl-128ibm-compat/test-wcstold-ldbl-compat.c
new file mode 100644
index 0000000000..8b9e300147
--- /dev/null
+++ b/sysdeps/ieee754/ldbl-128ibm-compat/test-wcstold-ldbl-compat.c
@@ -0,0 +1,36 @@ 
+/* Test for the long double variant of wcstold.
+   Copyright (C) 2019 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, see
+   <http://www.gnu.org/licenses/>.  */
+
+#include <wchar.h>
+
+#include <support/check.h>
+
+static int
+do_test (void)
+{
+  const wchar_t *input = L"-1.0000000000";
+  long double read;
+
+  read = wcstold (input, NULL);
+  if (read != (long double) -1)
+    support_record_failure ();
+
+  return 0;
+}
+
+#include <support/test-driver.c>