| Message ID | 20191025102915.23677-3-chunyan.zhang@unisoc.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Add Unisoc's SC9863A support | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Fri, Oct 25, 2019 at 06:29:14PM +0800, Chunyan Zhang wrote: > > Added bindings for Unisoc's SC9863A board and SC9863A SoC. > > Signed-off-by: Chunyan Zhang <chunyan.zhang@unisoc.com> > --- > Documentation/devicetree/bindings/arm/sprd.txt | 8 ++++++++ > 1 file changed, 8 insertions(+) Can you please convert this to DT schema first. See Documentation/devicetree/writing-schema.rst. > > diff --git a/Documentation/devicetree/bindings/arm/sprd.txt b/Documentation/devicetree/bindings/arm/sprd.txt > index 3df034b13e28..c244c911f8df 100644 > --- a/Documentation/devicetree/bindings/arm/sprd.txt > +++ b/Documentation/devicetree/bindings/arm/sprd.txt > @@ -12,3 +12,11 @@ Required root node properties: > SP9860G 3GFHD Board > Required root node properties: > - compatible = "sprd,sp9860g-1h10", "sprd,sc9860"; > + > +SC9863A SoC > +Required root node properties: > + - compatible = "sprd,sc9863a" > + > +SP9863A-1H10 Board > +Required root node properties: > + - compatible = "sprd,sp9863a-1h10", "sprd,sc9863a"; > -- > 2.20.1 > >
On Wed, 30 Oct 2019 at 05:46, Rob Herring <robh@kernel.org> wrote: > > On Fri, Oct 25, 2019 at 06:29:14PM +0800, Chunyan Zhang wrote: > > > > Added bindings for Unisoc's SC9863A board and SC9863A SoC. > > > > Signed-off-by: Chunyan Zhang <chunyan.zhang@unisoc.com> > > --- > > Documentation/devicetree/bindings/arm/sprd.txt | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > Can you please convert this to DT schema first. See > Documentation/devicetree/writing-schema.rst. Ok, will do, thanks. Chunyan > > > > > diff --git a/Documentation/devicetree/bindings/arm/sprd.txt b/Documentation/devicetree/bindings/arm/sprd.txt > > index 3df034b13e28..c244c911f8df 100644 > > --- a/Documentation/devicetree/bindings/arm/sprd.txt > > +++ b/Documentation/devicetree/bindings/arm/sprd.txt > > @@ -12,3 +12,11 @@ Required root node properties: > > SP9860G 3GFHD Board > > Required root node properties: > > - compatible = "sprd,sp9860g-1h10", "sprd,sc9860"; > > + > > +SC9863A SoC > > +Required root node properties: > > + - compatible = "sprd,sc9863a" > > + > > +SP9863A-1H10 Board > > +Required root node properties: > > + - compatible = "sprd,sp9863a-1h10", "sprd,sc9863a"; > > -- > > 2.20.1 > > > >
diff --git a/Documentation/devicetree/bindings/arm/sprd.txt b/Documentation/devicetree/bindings/arm/sprd.txt index 3df034b13e28..c244c911f8df 100644 --- a/Documentation/devicetree/bindings/arm/sprd.txt +++ b/Documentation/devicetree/bindings/arm/sprd.txt @@ -12,3 +12,11 @@ Required root node properties: SP9860G 3GFHD Board Required root node properties: - compatible = "sprd,sp9860g-1h10", "sprd,sc9860"; + +SC9863A SoC +Required root node properties: + - compatible = "sprd,sc9863a" + +SP9863A-1H10 Board +Required root node properties: + - compatible = "sprd,sp9863a-1h10", "sprd,sc9863a";
Added bindings for Unisoc's SC9863A board and SC9863A SoC. Signed-off-by: Chunyan Zhang <chunyan.zhang@unisoc.com> --- Documentation/devicetree/bindings/arm/sprd.txt | 8 ++++++++ 1 file changed, 8 insertions(+)