[v2,1/2] gpio: em: Use proper irq_chip name
diff mbox series

Message ID 20191024122224.11776-2-geert+renesas@glider.be
State New
Headers show
Series
  • gpio: renesas: Use proper irq_chip name
Related show

Commit Message

Geert Uytterhoeven Oct. 24, 2019, 12:22 p.m. UTC
The irq_chip .name field should contain the device's class name, not the
instance's name.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Untested due to lack of hardware.
.parent_device not filled in as this driver doesn't use Runtime PM.

v2:
  - No changes.

---
 drivers/gpio/gpio-em.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Linus Walleij Nov. 4, 2019, 3:10 p.m. UTC | #1
On Thu, Oct 24, 2019 at 2:22 PM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:

> The irq_chip .name field should contain the device's class name, not the
> instance's name.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Untested due to lack of hardware.
> .parent_device not filled in as this driver doesn't use Runtime PM.
>
> v2:
>   - No changes.

Patch applied.

Yours,
Linus Walleij
Bartosz Golaszewski Nov. 4, 2019, 3:21 p.m. UTC | #2
pon., 4 lis 2019 o 16:10 Linus Walleij <linus.walleij@linaro.org> napisał(a):
>
> On Thu, Oct 24, 2019 at 2:22 PM Geert Uytterhoeven
> <geert+renesas@glider.be> wrote:
>
> > The irq_chip .name field should contain the device's class name, not the
> > instance's name.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> > Untested due to lack of hardware.
> > .parent_device not filled in as this driver doesn't use Runtime PM.
> >
> > v2:
> >   - No changes.
>
> Patch applied.
>

Oops I already have those in my tree. I'll back them out before the next PR.

Bart

> Yours,
> Linus Walleij
Linus Walleij Nov. 5, 2019, 2:35 p.m. UTC | #3
On Mon, Nov 4, 2019 at 4:21 PM Bartosz Golaszewski
<bgolaszewski@baylibre.com> wrote:
> pon., 4 lis 2019 o 16:10 Linus Walleij <linus.walleij@linaro.org> napisał(a):
> >
> > On Thu, Oct 24, 2019 at 2:22 PM Geert Uytterhoeven
> > <geert+renesas@glider.be> wrote:
> >
> > > The irq_chip .name field should contain the device's class name, not the
> > > instance's name.
> > >
> > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > ---
> > > Untested due to lack of hardware.
> > > .parent_device not filled in as this driver doesn't use Runtime PM.
> > >
> > > v2:
> > >   - No changes.
> >
> > Patch applied.
> >
>
> Oops I already have those in my tree. I'll back them out before the next PR.

I noticed they were in your tree later, so I backed them out of mine,
just keep your commit history.

Linus

Patch
diff mbox series

diff --git a/drivers/gpio/gpio-em.c b/drivers/gpio/gpio-em.c
index 620f25b7efb402c1..cc4416310dc9a6fe 100644
--- a/drivers/gpio/gpio-em.c
+++ b/drivers/gpio/gpio-em.c
@@ -326,7 +326,7 @@  static int em_gio_probe(struct platform_device *pdev)
 	gpio_chip->ngpio = ngpios;
 
 	irq_chip = &p->irq_chip;
-	irq_chip->name = name;
+	irq_chip->name = "gpio-em";
 	irq_chip->irq_mask = em_gio_irq_disable;
 	irq_chip->irq_unmask = em_gio_irq_enable;
 	irq_chip->irq_set_type = em_gio_irq_set_type;