Patchwork qlogicpti: increase timeout

login
register
mail settings
Submitter Meelis Roos
Date Oct. 7, 2011, 7:53 a.m.
Message ID <alpine.SOC.1.00.1110071050080.648@math.ut.ee>
Download mbox | patch
Permalink /patch/118263/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Meelis Roos - Oct. 7, 2011, 7:53 a.m.
qlogicpti times out for some tape library operations (like mtx 
inventory). It seems SCSI command timeout is hardcoded into the driver. 
So let's increase it to some arbitrary higher value that Works For 
Me(tm).

Signed-off-by: Meelis Roos <mroos@linux.ee>
James Bottomley - Oct. 7, 2011, 2:16 p.m.
On Fri, 2011-10-07 at 10:53 +0300, Meelis Roos wrote:
> qlogicpti times out for some tape library operations (like mtx 
> inventory). It seems SCSI command timeout is hardcoded into the driver. 
> So let's increase it to some arbitrary higher value that Works For 
> Me(tm).
> 
> Signed-off-by: Meelis Roos <mroos@linux.ee>
> 
> diff --git a/drivers/scsi/qlogicpti.c b/drivers/scsi/qlogicpti.c
> index 9689d41c..4290141 100644
> --- a/drivers/scsi/qlogicpti.c
> +++ b/drivers/scsi/qlogicpti.c
> @@ -880,7 +880,7 @@ static inline void cmd_frob(struct Command_Entry *cmd, struct scsi_cmnd *Cmnd,
>  		cmd->control_flags |= CFLAG_WRITE;
>  	else
>  		cmd->control_flags |= CFLAG_READ;
> -	cmd->time_out = 30;
> +	cmd->time_out = 120;

What about just using the actual command specific timeout:

cmd->time_out = Cmnd->request->timeout/HZ;

?

James


James


--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/scsi/qlogicpti.c b/drivers/scsi/qlogicpti.c
index 9689d41c..4290141 100644
--- a/drivers/scsi/qlogicpti.c
+++ b/drivers/scsi/qlogicpti.c
@@ -880,7 +880,7 @@  static inline void cmd_frob(struct Command_Entry *cmd, struct scsi_cmnd *Cmnd,
 		cmd->control_flags |= CFLAG_WRITE;
 	else
 		cmd->control_flags |= CFLAG_READ;
-	cmd->time_out = 30;
+	cmd->time_out = 120;
 	memcpy(cmd->cdb, Cmnd->cmnd, Cmnd->cmd_len);
 }