Patchwork [v2,09/23] i8259: Do not update IRQ output after spurious pic_poll_read

login
register
mail settings
Submitter Jan Kiszka
Date Oct. 7, 2011, 7:19 a.m.
Message ID <e22360eac17dd4d989629a81b7d0f45c9c5cc6d8.1317971994.git.jan.kiszka@siemens.com>
Download mbox | patch
Permalink /patch/118236/
State New
Headers show

Comments

Jan Kiszka - Oct. 7, 2011, 7:19 a.m.
If pic_poll_read finds no pending IRQ and return a spurious one instead,
no PIC state is changed, thus we do not need to call pic_update_irq.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 hw/i8259.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

Patch

diff --git a/hw/i8259.c b/hw/i8259.c
index 65123bd..cddd3c7 100644
--- a/hw/i8259.c
+++ b/hw/i8259.c
@@ -393,7 +393,6 @@  static uint32_t pic_poll_read(PicState *s)
             pic_update_irq(s->pics_state);
     } else {
         ret = 0x07;
-        pic_update_irq(s->pics_state);
     }
 
     return ret;