diff mbox series

[v2,2/2] package/ofono: use target ell library if enabled

Message ID 20191022134341.34426-2-nicolas.serafini@sensefly.com
State Superseded, archived
Headers show
Series [v2,1/2] package/ofono: remove forced autoreconf | expand

Commit Message

Nicolas Serafini Oct. 22, 2019, 1:44 p.m. UTC 
Signed-off-by: Nicolas Serafini <nicolas.serafini@sensefly.com>

---
Changes v1 -> v2:
  - Remove forced autoreconf into another patch
  - Add missing OFONO_DEPENDENCIES
  - Add disable option if ell is not selected

Signed-off-by: Nicolas Serafini <nicolas.serafini@sensefly.com>
---
 package/ofono/ofono.mk | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Thomas Petazzoni Oct. 22, 2019, 8:18 p.m. UTC | #1 
Hello Nicolas,

On Tue, 22 Oct 2019 13:44:08 +0000
Nicolas Serafini <nicolas.serafini@sensefly.com> wrote:

> +ifeq ($(BR2_PACKAGE_ELL),y)
> +OFONO_DEPENDENCIES += ell
> +OFONO_CONF_OPTS += --enable-external-ell
> +else
> +OFONO_CONF_OPTS += --disable-external-ell
> +endif

If I understand correctly the code, ell is in fact always needed by
ofono. If ell is not available externally, it uses a bundled version of
ell.

In this case, Buildroot prefers to always use the external library, so
could you turn ell into a mandatory dependency of ofono, and pass
--enable-external-ell unconditionally?

Thanks!

Thomas
Nicolas Serafini Oct. 23, 2019, 8:37 a.m. UTC | #2 
Hello Thomas,

On Tue, 22 Oct 2019 22:18:00 +0200 Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:

>Hello Nicolas,
>
>On Tue, 22 Oct 2019 13:44:08 +0000
>Nicolas Serafini <nicolas.serafini@sensefly.com> wrote:
>
>> +ifeq ($(BR2_PACKAGE_ELL),y)
>> +OFONO_DEPENDENCIES += ell
>> +OFONO_CONF_OPTS += --enable-external-ell
>> +else
>> +OFONO_CONF_OPTS += --disable-external-ell
>> +endif
>
>If I understand correctly the code, ell is in fact always needed by
>ofono. If ell is not available externally, it uses a bundled version of
>ell.

Yes, that's right.

>
>In this case, Buildroot prefers to always use the external library, so
>could you turn ell into a mandatory dependency of ofono, and pass
>--enable-external-ell unconditionally?

I also prefer to use only the external library.
In case of a bug it avoids maintaining a patch in two different packages.
I'm preparing a v3.

Thanks

Nicolas

>
>Thanks!
>
>Thomas
diff mbox series

Patch

diff --git a/package/ofono/ofono.mk b/package/ofono/ofono.mk
index 756998687b..00c5ffbbe4 100644
--- a/package/ofono/ofono.mk
+++ b/package/ofono/ofono.mk
@@ -49,5 +49,11 @@  else
 OFONO_CONF_OPTS += --disable-bluetooth
 endif
 
+ifeq ($(BR2_PACKAGE_ELL),y)
+OFONO_DEPENDENCIES += ell
+OFONO_CONF_OPTS += --enable-external-ell
+else
+OFONO_CONF_OPTS += --disable-external-ell
+endif
 
 $(eval $(autotools-package))