Patchwork [testsuite] Don't XFAIL gcc.dg/uninit-B.c etc. (PR middle-end/50125)

login
register
mail settings
Submitter Rainer Orth
Date Oct. 6, 2011, 3:57 p.m.
Message ID <yddaa9ecdv4.fsf@manam.CeBiTec.Uni-Bielefeld.DE>
Download mbox | patch
Permalink /patch/118114/
State New
Headers show

Comments

Rainer Orth - Oct. 6, 2011, 3:57 p.m.
After almost two months, two tests are still XPASSing everywhere:

XPASS: gcc.dg/uninit-B.c uninit i warning (test for warnings, line 12)
XPASS: gcc.dg/uninit-pr19430.c  (test for warnings, line 32)
XPASS: gcc.dg/uninit-pr19430.c uninitialized (test for warnings, line 41)

I think it's time to remove the xfail's.

Tested with the appropriate runtest invocation on i386-pc-solaris2.10,
ok for mainline?

	Rainer


2011-10-06  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

	PR middle-end/50125
	* gcc.dg/uninit-B.c (baz): Remove xfail *-*-*.
	* gcc.dg/uninit-pr19430.c (main): Remove xfail *-*-*.
	(bar3): Likewise.
Richard Guenther - Oct. 7, 2011, 8:53 a.m.
On Thu, Oct 6, 2011 at 5:57 PM, Rainer Orth <ro@cebitec.uni-bielefeld.de> wrote:
> After almost two months, two tests are still XPASSing everywhere:
>
> XPASS: gcc.dg/uninit-B.c uninit i warning (test for warnings, line 12)
> XPASS: gcc.dg/uninit-pr19430.c  (test for warnings, line 32)
> XPASS: gcc.dg/uninit-pr19430.c uninitialized (test for warnings, line 41)
>
> I think it's time to remove the xfail's.
>
> Tested with the appropriate runtest invocation on i386-pc-solaris2.10,
> ok for mainline?

Ok

Thanks,
Richard.

>        Rainer
>
>
> 2011-10-06  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
>
>        PR middle-end/50125
>        * gcc.dg/uninit-B.c (baz): Remove xfail *-*-*.
>        * gcc.dg/uninit-pr19430.c (main): Remove xfail *-*-*.
>        (bar3): Likewise.
>
>
>
>
> --
> -----------------------------------------------------------------------------
> Rainer Orth, Center for Biotechnology, Bielefeld University
>
>

Patch

# HG changeset patch
# Parent 60c73f26147c2e549be69d750637ed45ca48e93c
Don't XFAIL gcc.dg/uninit-B.c etc. (PR middle-end/50125)

diff --git a/gcc/testsuite/gcc.dg/uninit-B.c b/gcc/testsuite/gcc.dg/uninit-B.c
--- a/gcc/testsuite/gcc.dg/uninit-B.c
+++ b/gcc/testsuite/gcc.dg/uninit-B.c
@@ -9,7 +9,7 @@  void
 baz (void)
 {
   int i;
-  if (i) /* { dg-warning "is used uninitialized" "uninit i warning" { xfail *-*-* } } */
+  if (i) /* { dg-warning "is used uninitialized" "uninit i warning" } */
     bar (i);
   foo (&i);
 }
diff --git a/gcc/testsuite/gcc.dg/uninit-pr19430.c b/gcc/testsuite/gcc.dg/uninit-pr19430.c
--- a/gcc/testsuite/gcc.dg/uninit-pr19430.c
+++ b/gcc/testsuite/gcc.dg/uninit-pr19430.c
@@ -29,7 +29,7 @@  void frob(int *pi);
 int main(void)
 {
   int i; 
-  printf("i = %d\n", i); /* { dg-warning "'i' is used uninitialized in this function" "" { xfail *-*-* } } */
+  printf("i = %d\n", i); /* { dg-warning "'i' is used uninitialized in this function" "" } */
   frob(&i);
 
   return 0;
@@ -38,6 +38,6 @@  int main(void)
 void foo3(int*);
 void bar3(void) { 
   int x; 
-  if(x) /* { dg-warning "'x' is used uninitialized in this function" "uninitialized" { xfail *-*-* } } */
+  if(x) /* { dg-warning "'x' is used uninitialized in this function" "uninitialized" } */
     foo3(&x); 
 }