UBUNTU: [Packaging] include iavf/i40evf in generic
diff mbox series

Message ID 20191022022328.24348-1-nobuto.murata@canonical.com
State New
Headers show
Series
  • UBUNTU: [Packaging] include iavf/i40evf in generic
Related show

Commit Message

Nobuto Murata Oct. 22, 2019, 2:23 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1848481

Intel's VF drivers such as igbvf and ixgbevf are already available in
generic. It makes sense to add iavf/i40evf especially for SR-IOV enabled
clouds with Intel X710/XXV710/XL710.

Signed-off-by: Nobuto Murata <nobuto.murata@canonical.com>
---
 debian.master/control.d/generic.inclusion-list | 1 +
 1 file changed, 1 insertion(+)

Comments

Seth Forshee Oct. 22, 2019, 8:38 p.m. UTC | #1
On Tue, Oct 22, 2019 at 11:23:28AM +0900, Nobuto Murata wrote:
> BugLink: https://bugs.launchpad.net/bugs/1848481
> 
> Intel's VF drivers such as igbvf and ixgbevf are already available in
> generic. It makes sense to add iavf/i40evf especially for SR-IOV enabled
> clouds with Intel X710/XXV710/XL710.
> 
> Signed-off-by: Nobuto Murata <nobuto.murata@canonical.com>

You didn't indicate what series you are targeting with this patch. It
should go into the development series in any case, so I've applied it to
unstable/master. If you're submitting this for SRU to any stable
releases, you'll need to specify which releases you are targeting.

Thanks,
Seth
Nobuto Murata Oct. 23, 2019, 2:35 p.m. UTC | #2
On Wed, Oct 23, 2019 at 5:38 AM Seth Forshee <seth.forshee@canonical.com> wrote:
>
> On Tue, Oct 22, 2019 at 11:23:28AM +0900, Nobuto Murata wrote:
> > BugLink: https://bugs.launchpad.net/bugs/1848481
> >
> > Intel's VF drivers such as igbvf and ixgbevf are already available in
> > generic. It makes sense to add iavf/i40evf especially for SR-IOV enabled
> > clouds with Intel X710/XXV710/XL710.
> >
> > Signed-off-by: Nobuto Murata <nobuto.murata@canonical.com>
>
> You didn't indicate what series you are targeting with this patch. It
> should go into the development series in any case, so I've applied it to
> unstable/master. If you're submitting this for SRU to any stable
> releases, you'll need to specify which releases you are targeting.

Noted with thanks. That was intended for the development series indeed.
Gavin Guo Oct. 28, 2019, 4:43 a.m. UTC | #3
Add Gerald to the list as he will be helping on the Bionic/Disco/Eoan SRU
process.

On Wed, Oct 23, 2019 at 10:36 PM Nobuto Murata <nobuto.murata@canonical.com>
wrote:

> On Wed, Oct 23, 2019 at 5:38 AM Seth Forshee <seth.forshee@canonical.com>
> wrote:
> >
> > On Tue, Oct 22, 2019 at 11:23:28AM +0900, Nobuto Murata wrote:
> > > BugLink: https://bugs.launchpad.net/bugs/1848481
> > >
> > > Intel's VF drivers such as igbvf and ixgbevf are already available in
> > > generic. It makes sense to add iavf/i40evf especially for SR-IOV
> enabled
> > > clouds with Intel X710/XXV710/XL710.
> > >
> > > Signed-off-by: Nobuto Murata <nobuto.murata@canonical.com>
> >
> > You didn't indicate what series you are targeting with this patch. It
> > should go into the development series in any case, so I've applied it to
> > unstable/master. If you're submitting this for SRU to any stable
> > releases, you'll need to specify which releases you are targeting.
>
> Noted with thanks. That was intended for the development series indeed.
>
> --
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
>
Gerald Yang Oct. 29, 2019, 2:55 a.m. UTC | #4
We also need to SRU this patch to Disco and Eoan, in case customers try to
install hwe kernel on their environment for testing

The module was renamed from i40evf to iavf since kernel 4.20, so I will
send another SRU for Bionic.

On Mon, Oct 28, 2019 at 12:44 PM Gavin Guo <gavin.guo@canonical.com> wrote:

> Add Gerald to the list as he will be helping on the Bionic/Disco/Eoan SRU
> process.
>
> On Wed, Oct 23, 2019 at 10:36 PM Nobuto Murata <
> nobuto.murata@canonical.com> wrote:
>
>> On Wed, Oct 23, 2019 at 5:38 AM Seth Forshee <seth.forshee@canonical.com>
>> wrote:
>> >
>> > On Tue, Oct 22, 2019 at 11:23:28AM +0900, Nobuto Murata wrote:
>> > > BugLink: https://bugs.launchpad.net/bugs/1848481
>> > >
>> > > Intel's VF drivers such as igbvf and ixgbevf are already available in
>> > > generic. It makes sense to add iavf/i40evf especially for SR-IOV
>> enabled
>> > > clouds with Intel X710/XXV710/XL710.
>> > >
>> > > Signed-off-by: Nobuto Murata <nobuto.murata@canonical.com>
>> >
>> > You didn't indicate what series you are targeting with this patch. It
>> > should go into the development series in any case, so I've applied it to
>> > unstable/master. If you're submitting this for SRU to any stable
>> > releases, you'll need to specify which releases you are targeting.
>>
>> Noted with thanks. That was intended for the development series indeed.
>>
>> --
>> kernel-team mailing list
>> kernel-team@lists.ubuntu.com
>> https://lists.ubuntu.com/mailman/listinfo/kernel-team
>>
>
Gerald Yang Nov. 4, 2019, 2:20 a.m. UTC | #5
Hi Seth,

Could you please help to apply this to Disco and Eoan? thanks!

On Tue, Oct 29, 2019 at 10:55 AM Gerald Yang <gerald.yang@canonical.com>
wrote:

> We also need to SRU this patch to Disco and Eoan, in case customers try to
> install hwe kernel on their environment for testing
>
> The module was renamed from i40evf to iavf since kernel 4.20, so I will
> send another SRU for Bionic.
>
> On Mon, Oct 28, 2019 at 12:44 PM Gavin Guo <gavin.guo@canonical.com>
> wrote:
>
>> Add Gerald to the list as he will be helping on the Bionic/Disco/Eoan SRU
>> process.
>>
>> On Wed, Oct 23, 2019 at 10:36 PM Nobuto Murata <
>> nobuto.murata@canonical.com> wrote:
>>
>>> On Wed, Oct 23, 2019 at 5:38 AM Seth Forshee <seth.forshee@canonical.com>
>>> wrote:
>>> >
>>> > On Tue, Oct 22, 2019 at 11:23:28AM +0900, Nobuto Murata wrote:
>>> > > BugLink: https://bugs.launchpad.net/bugs/1848481
>>> > >
>>> > > Intel's VF drivers such as igbvf and ixgbevf are already available in
>>> > > generic. It makes sense to add iavf/i40evf especially for SR-IOV
>>> enabled
>>> > > clouds with Intel X710/XXV710/XL710.
>>> > >
>>> > > Signed-off-by: Nobuto Murata <nobuto.murata@canonical.com>
>>> >
>>> > You didn't indicate what series you are targeting with this patch. It
>>> > should go into the development series in any case, so I've applied it
>>> to
>>> > unstable/master. If you're submitting this for SRU to any stable
>>> > releases, you'll need to specify which releases you are targeting.
>>>
>>> Noted with thanks. That was intended for the development series indeed.
>>>
>>> --
>>> kernel-team mailing list
>>> kernel-team@lists.ubuntu.com
>>> https://lists.ubuntu.com/mailman/listinfo/kernel-team
>>>
>>
Seth Forshee Nov. 4, 2019, 8:21 p.m. UTC | #6
On Mon, Nov 04, 2019 at 10:20:58AM +0800, Gerald Yang wrote:
> Hi Seth,
> 
> Could you please help to apply this to Disco and Eoan? thanks!

For stable releases we require two acks, but you never indicated that
this patch was targeted to any stable releases. Typically this will be
indicated in the subject, e.g.:

 [PATCH][SRU][D/E] UBUNTU: [Packaging] include iavf/i40evf in generic

If you resend the patch like this it will get reviewed and applied.

> 
> On Tue, Oct 29, 2019 at 10:55 AM Gerald Yang <gerald.yang@canonical.com>
> wrote:
> 
> > We also need to SRU this patch to Disco and Eoan, in case customers try to
> > install hwe kernel on their environment for testing
> >
> > The module was renamed from i40evf to iavf since kernel 4.20, so I will
> > send another SRU for Bionic.
> >
> > On Mon, Oct 28, 2019 at 12:44 PM Gavin Guo <gavin.guo@canonical.com>
> > wrote:
> >
> >> Add Gerald to the list as he will be helping on the Bionic/Disco/Eoan SRU
> >> process.
> >>
> >> On Wed, Oct 23, 2019 at 10:36 PM Nobuto Murata <
> >> nobuto.murata@canonical.com> wrote:
> >>
> >>> On Wed, Oct 23, 2019 at 5:38 AM Seth Forshee <seth.forshee@canonical.com>
> >>> wrote:
> >>> >
> >>> > On Tue, Oct 22, 2019 at 11:23:28AM +0900, Nobuto Murata wrote:
> >>> > > BugLink: https://bugs.launchpad.net/bugs/1848481
> >>> > >
> >>> > > Intel's VF drivers such as igbvf and ixgbevf are already available in
> >>> > > generic. It makes sense to add iavf/i40evf especially for SR-IOV
> >>> enabled
> >>> > > clouds with Intel X710/XXV710/XL710.
> >>> > >
> >>> > > Signed-off-by: Nobuto Murata <nobuto.murata@canonical.com>
> >>> >
> >>> > You didn't indicate what series you are targeting with this patch. It
> >>> > should go into the development series in any case, so I've applied it
> >>> to
> >>> > unstable/master. If you're submitting this for SRU to any stable
> >>> > releases, you'll need to specify which releases you are targeting.
> >>>
> >>> Noted with thanks. That was intended for the development series indeed.
> >>>
> >>> --
> >>> kernel-team mailing list
> >>> kernel-team@lists.ubuntu.com
> >>> https://lists.ubuntu.com/mailman/listinfo/kernel-team
> >>>
> >>

Patch
diff mbox series

diff --git a/debian.master/control.d/generic.inclusion-list b/debian.master/control.d/generic.inclusion-list
index e5b770975186..64b06051f0dc 100644
--- a/debian.master/control.d/generic.inclusion-list
+++ b/debian.master/control.d/generic.inclusion-list
@@ -93,6 +93,7 @@  drivers/net/ethernet/ibm/*
 drivers/net/ethernet/intel/e1000/e1000.ko
 drivers/net/ethernet/intel/e1000e/e1000e.ko
 drivers/net/ethernet/intel/i40e/*
+drivers/net/ethernet/intel/iavf/iavf.ko
 drivers/net/ethernet/intel/igb/*
 drivers/net/ethernet/intel/igbvf/igbvf.ko
 drivers/net/ethernet/intel/ixgbe/*