[RESEND,net-next] net: sched: taprio: fix -Wmissing-prototypes warnings
diff mbox series

Message ID 1571702262-25929-1-git-send-email-wang.yi59@zte.com.cn
State Accepted
Delegated to: David Miller
Headers show
Series
  • [RESEND,net-next] net: sched: taprio: fix -Wmissing-prototypes warnings
Related show

Commit Message

Yi Wang Oct. 21, 2019, 11:57 p.m. UTC
We get one warnings when build kernel W=1:
net/sched/sch_taprio.c:1155:6: warning: no previous prototype for ‘taprio_offload_config_changed’ [-Wmissing-prototypes]

Make the function static to fix this.

Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
Acked-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
---
 net/sched/sch_taprio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jakub Kicinski Oct. 22, 2019, 8:39 p.m. UTC | #1
On Tue, 22 Oct 2019 07:57:42 +0800, Yi Wang wrote:
> We get one warnings when build kernel W=1:
> net/sched/sch_taprio.c:1155:6: warning: no previous prototype for ‘taprio_offload_config_changed’ [-Wmissing-prototypes]
> 
> Make the function static to fix this.
> 
> Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
> Acked-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>

Thank you!

I've added Fixes tag and applied this to the net tree, since the warning
is already present there.

Patch
diff mbox series

diff --git a/net/sched/sch_taprio.c b/net/sched/sch_taprio.c
index 6719a65..2121187 100644
--- a/net/sched/sch_taprio.c
+++ b/net/sched/sch_taprio.c
@@ -1152,7 +1152,7 @@  void taprio_offload_free(struct tc_taprio_qopt_offload *offload)
  * offload state (PENDING, ACTIVE, INACTIVE) so it can be visible in dump().
  * This is left as TODO.
  */
-void taprio_offload_config_changed(struct taprio_sched *q)
+static void taprio_offload_config_changed(struct taprio_sched *q)
 {
 	struct sched_gate_list *oper, *admin;