[OpenWrt-Devel,v2] mac80211: add rtw88 driver
diff mbox series

Message ID 20191021204712.30307-1-mail@david-bauer.net
State Accepted, archived
Delegated to: David Bauer
Headers show
Series
  • [OpenWrt-Devel,v2] mac80211: add rtw88 driver
Related show

Commit Message

David Bauer Oct. 21, 2019, 8:47 p.m. UTC
This commits adds packaging for the new RTW88 driver from Realtek.
It supports the Realtek 8822BE/8822CE PCIe wireless chips.

For operation, the complementary firmware has to be loaded.

Signed-off-by: David Bauer <mail@david-bauer.net>
---
 package/kernel/mac80211/realtek.mk | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

Comments

Hauke Mehrtens Oct. 21, 2019, 9:20 p.m. UTC | #1
On 10/21/19 10:47 PM, David Bauer wrote:
> This commits adds packaging for the new RTW88 driver from Realtek.
> It supports the Realtek 8822BE/8822CE PCIe wireless chips.
> 
> For operation, the complementary firmware has to be loaded.
> 
> Signed-off-by: David Bauer <mail@david-bauer.net>
> ---
>  package/kernel/mac80211/realtek.mk | 13 ++++++++++++-
>  1 file changed, 12 insertions(+), 1 deletion(-)
> 
> diff --git a/package/kernel/mac80211/realtek.mk b/package/kernel/mac80211/realtek.mk
> index e7eb9e3117..c14b0bd8f7 100644
> --- a/package/kernel/mac80211/realtek.mk
> +++ b/package/kernel/mac80211/realtek.mk
> @@ -2,7 +2,7 @@ PKG_DRIVERS += \
>  	rtl8180 rtl8187 \
>  	rtlwifi rtlwifi-pci rtlwifi-btcoexist rtlwifi-usb rtl8192c-common \
>  	rtl8192ce rtl8192se rtl8192de rtl8192cu rtl8821ae \
> -	rtl8xxxu
> +	rtl8xxxu rtw88
>  
>  config-$(call config_package,rtl8180) += RTL8180
>  config-$(call config_package,rtl8187) += RTL8187
> @@ -22,6 +22,8 @@ config-$(CONFIG_PACKAGE_RTLWIFI_DEBUG) += RTLWIFI_DEBUG
>  config-$(call config_package,rtl8xxxu) += RTL8XXXU
>  config-y += RTL8XXXU_UNTESTED
>  
> +config-$(call config_package,rtw88) += RTW88 RTW88_CORE RTW88_PCI RTW88_8822BE RTW88_8822CE
> +
>  define KernelPackage/rtl818x/Default
>    $(call KernelPackage/mac80211/Default)
>    TITLE:=Realtek Drivers for RTL818x devices
> @@ -168,3 +170,12 @@ define KernelPackage/rtl8xxxu/description
>  
>    Please report your results!
>  endef
> +
> +define KernelPackage/rtw88
> +  $(call KernelPackage/mac80211/Default)
> +  TITLE:=Realtek RTL8822BE/RTL8822CE
> +  DEPENDS+= @(PCI_SUPPORT) +kmod-mac80211 +@DRIVER_11N_SUPPORT +@DRIVER_11W_SUPPORT

Please add +@DRIVER_11AC_SUPPORT

> +  FILES:=$(PKG_BUILD_DIR)/drivers/net/wireless/realtek/rtw88/rtw88.ko	\
> +	$(PKG_BUILD_DIR)/drivers/net/wireless/realtek/rtw88/rtwpci.ko
> +  AUTOLOAD:=$(call AutoProbe,rtwpci)
> +endef
>
John Crispin Oct. 21, 2019, 9:40 p.m. UTC | #2
On 21/10/2019 23:20, Hauke Mehrtens wrote:
>> +define KernelPackage/rtw88
>> +  $(call KernelPackage/mac80211/Default)
>> +  TITLE:=Realtek RTL8822BE/RTL8822CE
>> +  DEPENDS+= @(PCI_SUPPORT) +kmod-mac80211 +@DRIVER_11N_SUPPORT +@DRIVER_11W_SUPPORT
> Please add +@DRIVER_11AC_SUPPORT
> 

V3 here we go ....
David Bauer Oct. 21, 2019, 9:41 p.m. UTC | #3
On 10/21/19 11:40 PM, John Crispin wrote:
> On 21/10/2019 23:20, Hauke Mehrtens wrote:
>>> +define KernelPackage/rtw88
>>> +  $(call KernelPackage/mac80211/Default)
>>> +  TITLE:=Realtek RTL8822BE/RTL8822CE
>>> +  DEPENDS+= @(PCI_SUPPORT) +kmod-mac80211 +@DRIVER_11N_SUPPORT +@DRIVER_11W_SUPPORT
>> Please add +@DRIVER_11AC_SUPPORT
>>
> 
> V3 here we go ....

I will leave this v2 here and wait for further feedback to accumulate.

Best wishes
David
John Crispin Oct. 21, 2019, 9:44 p.m. UTC | #4
On 21/10/2019 23:41, David Bauer wrote:
> 
> 
> On 10/21/19 11:40 PM, John Crispin wrote:
>> On 21/10/2019 23:20, Hauke Mehrtens wrote:
>>>> +define KernelPackage/rtw88
>>>> +  $(call KernelPackage/mac80211/Default)
>>>> +  TITLE:=Realtek RTL8822BE/RTL8822CE
>>>> +  DEPENDS+= @(PCI_SUPPORT) +kmod-mac80211 +@DRIVER_11N_SUPPORT +@DRIVER_11W_SUPPORT
>>> Please add +@DRIVER_11AC_SUPPORT
>>>
>>
>> V3 here we go ....
> 
> I will leave this v2 here and wait for further feedback to accumulate.
> 
> Best wishes
> David
> 

doubt there will be more, if you send a a V3 with haukes suggestions 
folded i'll merge it
	John
David Bauer Oct. 21, 2019, 9:57 p.m. UTC | #5
Hello John,

On 10/21/19 11:44 PM, John Crispin wrote:
> On 21/10/2019 23:41, David Bauer wrote:
>>
>>
>> On 10/21/19 11:40 PM, John Crispin wrote:
>>> On 21/10/2019 23:20, Hauke Mehrtens wrote:
>>>>> +define KernelPackage/rtw88
>>>>> +  $(call KernelPackage/mac80211/Default)
>>>>> +  TITLE:=Realtek RTL8822BE/RTL8822CE
>>>>> +  DEPENDS+= @(PCI_SUPPORT) +kmod-mac80211 +@DRIVER_11N_SUPPORT +@DRIVER_11W_SUPPORT
>>>> Please add +@DRIVER_11AC_SUPPORT
>>>>
>>>
>>> V3 here we go ....
>>
>> I will leave this v2 here and wait for further feedback to accumulate.
>>
>> Best wishes
>> David
>>
> 
> doubt there will be more, if you send a a V3 with haukes suggestions folded i'll merge it

I'll push a version including Haukes suggestions to master later this week.

Best wishes
David

>     John

Patch
diff mbox series

diff --git a/package/kernel/mac80211/realtek.mk b/package/kernel/mac80211/realtek.mk
index e7eb9e3117..c14b0bd8f7 100644
--- a/package/kernel/mac80211/realtek.mk
+++ b/package/kernel/mac80211/realtek.mk
@@ -2,7 +2,7 @@  PKG_DRIVERS += \
 	rtl8180 rtl8187 \
 	rtlwifi rtlwifi-pci rtlwifi-btcoexist rtlwifi-usb rtl8192c-common \
 	rtl8192ce rtl8192se rtl8192de rtl8192cu rtl8821ae \
-	rtl8xxxu
+	rtl8xxxu rtw88
 
 config-$(call config_package,rtl8180) += RTL8180
 config-$(call config_package,rtl8187) += RTL8187
@@ -22,6 +22,8 @@  config-$(CONFIG_PACKAGE_RTLWIFI_DEBUG) += RTLWIFI_DEBUG
 config-$(call config_package,rtl8xxxu) += RTL8XXXU
 config-y += RTL8XXXU_UNTESTED
 
+config-$(call config_package,rtw88) += RTW88 RTW88_CORE RTW88_PCI RTW88_8822BE RTW88_8822CE
+
 define KernelPackage/rtl818x/Default
   $(call KernelPackage/mac80211/Default)
   TITLE:=Realtek Drivers for RTL818x devices
@@ -168,3 +170,12 @@  define KernelPackage/rtl8xxxu/description
 
   Please report your results!
 endef
+
+define KernelPackage/rtw88
+  $(call KernelPackage/mac80211/Default)
+  TITLE:=Realtek RTL8822BE/RTL8822CE
+  DEPENDS+= @(PCI_SUPPORT) +kmod-mac80211 +@DRIVER_11N_SUPPORT +@DRIVER_11W_SUPPORT
+  FILES:=$(PKG_BUILD_DIR)/drivers/net/wireless/realtek/rtw88/rtw88.ko	\
+	$(PKG_BUILD_DIR)/drivers/net/wireless/realtek/rtw88/rtwpci.ko
+  AUTOLOAD:=$(call AutoProbe,rtwpci)
+endef